From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v2 05/18] acpi: add aml_create_field
Date: Sun, 6 Sep 2015 13:32:16 +0800 [thread overview]
Message-ID: <55EBCFE0.5060805@linux.intel.com> (raw)
In-Reply-To: <20150902131046.2240eae2@nial.brq.redhat.com>
On 09/02/2015 07:10 PM, Igor Mammedov wrote:
> On Fri, 14 Aug 2015 22:51:58 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> Implement CreateField term which are used by NVDIMM _DSM method in later patch
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>> ---
>> hw/acpi/aml-build.c | 14 ++++++++++++++
>> include/hw/acpi/aml-build.h | 1 +
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
>> index a526eed..debdad2 100644
>> --- a/hw/acpi/aml-build.c
>> +++ b/hw/acpi/aml-build.c
>> @@ -1151,6 +1151,20 @@ Aml *aml_sizeof(Aml *arg)
>> return var;
>> }
>>
>> +/* ACPI 6.0: 20.2.5.2 Named Objects Encoding: DefCreateField */
> ditto, refer to to the first revision where it's appeared
Well do it.
>
>> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name)
> index and len could be only of 'Integer' type, so there is no point
> to pass them in as Aml, just use uintFOO_t here and convert
> them to aml_int() internally. That way call sites will be smaller
> and have less chance to pass a wrong Aml variable.
>
Good idea.
BTW, Igor, sorry for the delay reply since we got a holiday in this week.
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v2 05/18] acpi: add aml_create_field
Date: Sun, 6 Sep 2015 13:32:16 +0800 [thread overview]
Message-ID: <55EBCFE0.5060805@linux.intel.com> (raw)
In-Reply-To: <20150902131046.2240eae2@nial.brq.redhat.com>
On 09/02/2015 07:10 PM, Igor Mammedov wrote:
> On Fri, 14 Aug 2015 22:51:58 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> Implement CreateField term which are used by NVDIMM _DSM method in later patch
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>> ---
>> hw/acpi/aml-build.c | 14 ++++++++++++++
>> include/hw/acpi/aml-build.h | 1 +
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
>> index a526eed..debdad2 100644
>> --- a/hw/acpi/aml-build.c
>> +++ b/hw/acpi/aml-build.c
>> @@ -1151,6 +1151,20 @@ Aml *aml_sizeof(Aml *arg)
>> return var;
>> }
>>
>> +/* ACPI 6.0: 20.2.5.2 Named Objects Encoding: DefCreateField */
> ditto, refer to to the first revision where it's appeared
Well do it.
>
>> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name)
> index and len could be only of 'Integer' type, so there is no point
> to pass them in as Aml, just use uintFOO_t here and convert
> them to aml_int() internally. That way call sites will be smaller
> and have less chance to pass a wrong Aml variable.
>
Good idea.
BTW, Igor, sorry for the delay reply since we got a holiday in this week.
next prev parent reply other threads:[~2015-09-06 5:32 UTC|newest]
Thread overview: 164+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 14:51 [PATCH v2 00/18] implement vNVDIMM Xiao Guangrong
2015-08-14 14:51 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:51 ` [PATCH v2 01/18] acpi: allow aml_operation_region() working on 64 bit offset Xiao Guangrong
2015-08-14 14:51 ` [Qemu-devel] " Xiao Guangrong
2015-09-02 8:05 ` Igor Mammedov
2015-09-02 8:05 ` [Qemu-devel] " Igor Mammedov
2015-08-14 14:51 ` [PATCH v2 02/18] i386/acpi-build: allow SSDT to operate on 64 bit Xiao Guangrong
2015-08-14 14:51 ` [Qemu-devel] " Xiao Guangrong
2015-09-02 10:06 ` Igor Mammedov
2015-09-02 10:06 ` [Qemu-devel] " Igor Mammedov
2015-09-02 10:43 ` Xiao Guangrong
2015-09-02 11:42 ` Igor Mammedov
2015-09-06 7:01 ` Xiao Guangrong
2015-09-02 12:05 ` Michael S. Tsirkin
2015-09-02 12:05 ` [Qemu-devel] " Michael S. Tsirkin
2015-08-14 14:51 ` [PATCH v2 03/18] acpi: add aml_derefof Xiao Guangrong
2015-08-14 14:51 ` [Qemu-devel] " Xiao Guangrong
2015-09-02 10:16 ` Igor Mammedov
2015-09-02 10:16 ` [Qemu-devel] " Igor Mammedov
2015-09-02 10:38 ` Xiao Guangrong
2015-09-02 10:38 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:51 ` [PATCH v2 04/18] acpi: add aml_sizeof Xiao Guangrong
2015-08-14 14:51 ` [Qemu-devel] " Xiao Guangrong
2015-09-02 10:18 ` Igor Mammedov
2015-09-02 10:18 ` [Qemu-devel] " Igor Mammedov
2015-09-02 10:39 ` Xiao Guangrong
2015-09-02 10:39 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:51 ` [PATCH v2 05/18] acpi: add aml_create_field Xiao Guangrong
2015-08-14 14:51 ` [Qemu-devel] " Xiao Guangrong
2015-09-02 11:10 ` Igor Mammedov
2015-09-02 11:10 ` [Qemu-devel] " Igor Mammedov
2015-09-06 5:32 ` Xiao Guangrong [this message]
2015-09-06 5:32 ` Xiao Guangrong
2015-08-14 14:51 ` [PATCH v2 06/18] pc: implement NVDIMM device abstract Xiao Guangrong
2015-08-14 14:51 ` [Qemu-devel] " Xiao Guangrong
2015-08-25 14:57 ` Stefan Hajnoczi
2015-08-25 14:57 ` Stefan Hajnoczi
2015-08-26 9:37 ` Xiao Guangrong
2015-08-26 9:37 ` Xiao Guangrong
2015-09-02 9:58 ` Igor Mammedov
2015-09-02 9:58 ` Igor Mammedov
2015-09-02 10:36 ` Xiao Guangrong
2015-09-02 10:36 ` Xiao Guangrong
2015-09-02 11:31 ` Igor Mammedov
2015-09-02 11:31 ` Igor Mammedov
2015-09-06 6:07 ` Xiao Guangrong
2015-09-06 6:07 ` Xiao Guangrong
2015-09-07 13:40 ` Igor Mammedov
2015-09-07 13:40 ` Igor Mammedov
2015-09-08 14:03 ` Xiao Guangrong
2015-09-10 9:47 ` Igor Mammedov
2015-08-14 14:52 ` [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-25 15:12 ` Stefan Hajnoczi
2015-08-25 15:12 ` [Qemu-devel] " Stefan Hajnoczi
2015-08-26 9:39 ` Xiao Guangrong
2015-08-26 9:40 ` Xiao Guangrong
2015-08-26 9:40 ` Xiao Guangrong
2015-08-25 15:39 ` Stefan Hajnoczi
2015-08-25 15:39 ` [Qemu-devel] " Stefan Hajnoczi
2015-08-28 17:25 ` Eduardo Habkost
2015-08-28 17:25 ` [Qemu-devel] " Eduardo Habkost
2015-08-31 7:01 ` Xiao Guangrong
2015-08-31 7:01 ` [Qemu-devel] " Xiao Guangrong
2015-09-04 12:02 ` Igor Mammedov
2015-09-04 12:02 ` [Qemu-devel] " Igor Mammedov
2015-09-06 7:22 ` Xiao Guangrong
2015-09-06 7:22 ` Xiao Guangrong
2015-08-14 14:52 ` [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-25 16:03 ` Stefan Hajnoczi
2015-08-25 16:03 ` [Qemu-devel] " Stefan Hajnoczi
2015-08-26 10:40 ` Xiao Guangrong
2015-08-26 10:40 ` [Qemu-devel] " Xiao Guangrong
2015-08-28 11:58 ` Stefan Hajnoczi
2015-08-28 11:58 ` [Qemu-devel] " Stefan Hajnoczi
2015-08-31 6:23 ` Xiao Guangrong
2015-08-31 6:23 ` [Qemu-devel] " Xiao Guangrong
2015-09-01 9:14 ` Stefan Hajnoczi
2015-09-01 9:14 ` [Qemu-devel] " Stefan Hajnoczi
2015-09-15 16:10 ` Paolo Bonzini
2015-09-15 16:10 ` [Qemu-devel] " Paolo Bonzini
2015-09-17 8:39 ` Xiao Guangrong
2015-09-17 8:39 ` [Qemu-devel] " Xiao Guangrong
2015-09-17 9:04 ` Igor Mammedov
2015-09-17 9:04 ` [Qemu-devel] " Igor Mammedov
2015-09-17 9:14 ` Xiao Guangrong
2015-09-17 9:14 ` [Qemu-devel] " Xiao Guangrong
2015-09-17 9:34 ` Paolo Bonzini
2015-09-17 9:34 ` [Qemu-devel] " Paolo Bonzini
2015-09-17 12:43 ` Xiao Guangrong
2015-09-15 16:07 ` Paolo Bonzini
2015-09-15 16:07 ` [Qemu-devel] " Paolo Bonzini
2015-09-17 8:23 ` Xiao Guangrong
2015-09-17 8:23 ` [Qemu-devel] " Xiao Guangrong
2015-09-15 16:06 ` Paolo Bonzini
2015-09-15 16:06 ` [Qemu-devel] " Paolo Bonzini
2015-09-17 8:21 ` Xiao Guangrong
2015-09-17 8:21 ` [Qemu-devel] " Xiao Guangrong
2015-09-07 14:11 ` Igor Mammedov
2015-09-07 14:11 ` Igor Mammedov
2015-09-08 13:38 ` Xiao Guangrong
2015-09-10 10:35 ` Igor Mammedov
2015-09-15 16:11 ` Paolo Bonzini
2015-08-14 14:52 ` [PATCH v2 09/18] nvdimm: build ACPI NFIT table Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-09-15 16:12 ` Paolo Bonzini
2015-09-15 16:12 ` [Qemu-devel] " Paolo Bonzini
2015-09-15 17:35 ` Igor Mammedov
2015-09-15 17:35 ` [Qemu-devel] " Igor Mammedov
2015-08-14 14:52 ` [PATCH v2 10/18] nvdimm: init the address region used by DSM method Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-25 16:11 ` Stefan Hajnoczi
2015-08-25 16:11 ` [Qemu-devel] " Stefan Hajnoczi
2015-08-26 10:41 ` Xiao Guangrong
2015-08-26 10:41 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:52 ` [PATCH v2 11/18] nvdimm: build ACPI nvdimm devices Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:52 ` [PATCH v2 12/18] nvdimm: save arg3 for NVDIMM device _DSM method Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:52 ` [PATCH v2 13/18] nvdimm: build namespace config data Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-25 16:16 ` Stefan Hajnoczi
2015-08-25 16:16 ` Stefan Hajnoczi
2015-08-26 10:42 ` Xiao Guangrong
2015-08-26 10:42 ` Xiao Guangrong
2015-08-28 11:59 ` Stefan Hajnoczi
2015-08-28 11:59 ` Stefan Hajnoczi
2015-08-31 6:25 ` Xiao Guangrong
2015-08-31 6:25 ` Xiao Guangrong
2015-08-14 14:52 ` [PATCH v2 14/18] nvdimm: support NFIT_CMD_IMPLEMENTED function Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-25 16:23 ` Stefan Hajnoczi
2015-08-25 16:23 ` [Qemu-devel] " Stefan Hajnoczi
2015-08-26 10:46 ` Xiao Guangrong
2015-08-26 10:46 ` [Qemu-devel] " Xiao Guangrong
2015-08-28 12:01 ` Stefan Hajnoczi
2015-08-28 12:01 ` [Qemu-devel] " Stefan Hajnoczi
2015-08-31 6:51 ` Xiao Guangrong
2015-08-31 6:51 ` Xiao Guangrong
2015-09-01 9:16 ` Stefan Hajnoczi
2015-09-01 9:16 ` Stefan Hajnoczi
2015-08-14 14:52 ` [PATCH v2 15/18] nvdimm: support NFIT_CMD_GET_CONFIG_SIZE function Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-25 16:24 ` Stefan Hajnoczi
2015-08-25 16:24 ` [Qemu-devel] " Stefan Hajnoczi
2015-08-26 10:47 ` Xiao Guangrong
2015-08-26 10:47 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:52 ` [PATCH v2 16/18] nvdimm: support NFIT_CMD_GET_CONFIG_DATA Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:52 ` [PATCH v2 17/18] nvdimm: support NFIT_CMD_SET_CONFIG_DATA Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-14 14:52 ` [PATCH v2 18/18] nvdimm: add maintain info Xiao Guangrong
2015-08-14 14:52 ` [Qemu-devel] " Xiao Guangrong
2015-08-25 16:26 ` [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM Stefan Hajnoczi
2015-08-25 16:26 ` Stefan Hajnoczi
2015-08-26 10:49 ` Xiao Guangrong
2015-08-26 10:49 ` Xiao Guangrong
2015-10-07 14:02 ` Stefan Hajnoczi
2015-10-07 14:02 ` Stefan Hajnoczi
2015-10-07 14:43 ` Xiao Guangrong
2015-10-07 14:43 ` Xiao Guangrong
2015-10-09 10:38 ` Stefan Hajnoczi
2015-10-09 10:38 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EBCFE0.5060805@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.