From: Andrzej Pietrasiewicz <andrzej.p-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Joel Becker <jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pratyush Anand
<pratyush.anand-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 06/23] usb-gadget/ether: use per-attribute show and store methods
Date: Mon, 28 Sep 2015 13:40:30 +0200 [thread overview]
Message-ID: <5609272E.20702@samsung.com> (raw)
In-Reply-To: <1443189000-13398-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze:
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/usb/gadget/function/f_ecm.c | 8 ++---
> drivers/usb/gadget/function/f_eem.c | 8 ++---
> drivers/usb/gadget/function/f_ncm.c | 8 ++---
> drivers/usb/gadget/function/f_rndis.c | 8 ++---
> drivers/usb/gadget/function/f_subset.c | 8 ++---
> drivers/usb/gadget/function/u_ether_configfs.h | 44 +++++++++++---------------
> 6 files changed, 38 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/function/f_ecm.c
> index 7b7424f..0106de8 100644
> --- a/drivers/usb/gadget/function/f_ecm.c
> +++ b/drivers/usb/gadget/function/f_ecm.c
> @@ -855,10 +855,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(ecm);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(ecm);
>
> static struct configfs_attribute *ecm_attrs[] = {
> - &f_ecm_opts_dev_addr.attr,
> - &f_ecm_opts_host_addr.attr,
> - &f_ecm_opts_qmult.attr,
> - &f_ecm_opts_ifname.attr,
> + &ecm_opts_attr_dev_addr,
> + &ecm_opts_attr_host_addr,
> + &ecm_opts_attr_qmult,
> + &ecm_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/f_eem.c b/drivers/usb/gadget/function/f_eem.c
> index c9e90de..f965403 100644
> --- a/drivers/usb/gadget/function/f_eem.c
> +++ b/drivers/usb/gadget/function/f_eem.c
> @@ -555,10 +555,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(eem);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(eem);
>
> static struct configfs_attribute *eem_attrs[] = {
> - &f_eem_opts_dev_addr.attr,
> - &f_eem_opts_host_addr.attr,
> - &f_eem_opts_qmult.attr,
> - &f_eem_opts_ifname.attr,
> + &eem_opts_attr_dev_addr,
> + &eem_opts_attr_host_addr,
> + &eem_opts_attr_qmult,
> + &eem_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/function/f_ncm.c
> index 3f05c6bd..01a99e5 100644
> --- a/drivers/usb/gadget/function/f_ncm.c
> +++ b/drivers/usb/gadget/function/f_ncm.c
> @@ -1503,10 +1503,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(ncm);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(ncm);
>
> static struct configfs_attribute *ncm_attrs[] = {
> - &f_ncm_opts_dev_addr.attr,
> - &f_ncm_opts_host_addr.attr,
> - &f_ncm_opts_qmult.attr,
> - &f_ncm_opts_ifname.attr,
> + &ncm_opts_attr_dev_addr,
> + &ncm_opts_attr_host_addr,
> + &ncm_opts_attr_qmult,
> + &ncm_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/f_rndis.c b/drivers/usb/gadget/function/f_rndis.c
> index 32985da..a04b526 100644
> --- a/drivers/usb/gadget/function/f_rndis.c
> +++ b/drivers/usb/gadget/function/f_rndis.c
> @@ -878,10 +878,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(rndis);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(rndis);
>
> static struct configfs_attribute *rndis_attrs[] = {
> - &f_rndis_opts_dev_addr.attr,
> - &f_rndis_opts_host_addr.attr,
> - &f_rndis_opts_qmult.attr,
> - &f_rndis_opts_ifname.attr,
> + &rndis_opts_attr_dev_addr,
> + &rndis_opts_attr_host_addr,
> + &rndis_opts_attr_qmult,
> + &rndis_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/f_subset.c b/drivers/usb/gadget/function/f_subset.c
> index e3dfa67..055e4ea 100644
> --- a/drivers/usb/gadget/function/f_subset.c
> +++ b/drivers/usb/gadget/function/f_subset.c
> @@ -413,10 +413,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(gether);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(gether);
>
> static struct configfs_attribute *gether_attrs[] = {
> - &f_gether_opts_dev_addr.attr,
> - &f_gether_opts_host_addr.attr,
> - &f_gether_opts_qmult.attr,
> - &f_gether_opts_ifname.attr,
> + &gether_opts_attr_dev_addr,
> + &gether_opts_attr_host_addr,
> + &gether_opts_attr_qmult,
> + &gether_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/u_ether_configfs.h b/drivers/usb/gadget/function/u_ether_configfs.h
> index bcbd301..4f47289 100644
> --- a/drivers/usb/gadget/function/u_ether_configfs.h
> +++ b/drivers/usb/gadget/function/u_ether_configfs.h
> @@ -17,9 +17,6 @@
> #define __U_ETHER_CONFIGFS_H
>
> #define USB_ETHERNET_CONFIGFS_ITEM(_f_) \
> - CONFIGFS_ATTR_STRUCT(f_##_f_##_opts); \
> - CONFIGFS_ATTR_OPS(f_##_f_##_opts); \
> - \
> static void _f_##_attr_release(struct config_item *item) \
> { \
> struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> @@ -29,14 +26,13 @@
> \
> static struct configfs_item_operations _f_##_item_ops = { \
> .release = _f_##_attr_release, \
> - .show_attribute = f_##_f_##_opts_attr_show, \
> - .store_attribute = f_##_f_##_opts_attr_store, \
> }
>
> #define USB_ETHERNET_CONFIGFS_ITEM_ATTR_DEV_ADDR(_f_) \
> - static ssize_t _f_##_opts_dev_addr_show(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_dev_addr_show(struct config_item *item, \
> char *page) \
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int result; \
> \
> mutex_lock(&opts->lock); \
> @@ -46,9 +42,10 @@
> return result; \
> } \
> \
> - static ssize_t _f_##_opts_dev_addr_store(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_dev_addr_store(struct config_item *item, \
> const char *page, size_t len)\
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int ret; \
> \
> mutex_lock(&opts->lock); \
> @@ -64,15 +61,13 @@
> return ret; \
> } \
> \
> - static struct f_##_f_##_opts_attribute f_##_f_##_opts_dev_addr = \
> - __CONFIGFS_ATTR(dev_addr, S_IRUGO | S_IWUSR, \
> - _f_##_opts_dev_addr_show, \
> - _f_##_opts_dev_addr_store)
> + CONFIGFS_ATTR(_f_##_opts_, dev_addr)
>
> #define USB_ETHERNET_CONFIGFS_ITEM_ATTR_HOST_ADDR(_f_) \
> - static ssize_t _f_##_opts_host_addr_show(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_host_addr_show(struct config_item *item, \
> char *page) \
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int result; \
> \
> mutex_lock(&opts->lock); \
> @@ -82,9 +77,10 @@
> return result; \
> } \
> \
> - static ssize_t _f_##_opts_host_addr_store(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_host_addr_store(struct config_item *item, \
> const char *page, size_t len)\
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int ret; \
> \
> mutex_lock(&opts->lock); \
> @@ -100,15 +96,13 @@
> return ret; \
> } \
> \
> - static struct f_##_f_##_opts_attribute f_##_f_##_opts_host_addr = \
> - __CONFIGFS_ATTR(host_addr, S_IRUGO | S_IWUSR, \
> - _f_##_opts_host_addr_show, \
> - _f_##_opts_host_addr_store)
> + CONFIGFS_ATTR(_f_##_opts_, host_addr)
>
> #define USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(_f_) \
> - static ssize_t _f_##_opts_qmult_show(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_qmult_show(struct config_item *item, \
> char *page) \
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> unsigned qmult; \
> \
> mutex_lock(&opts->lock); \
> @@ -117,9 +111,10 @@
> return sprintf(page, "%d", qmult); \
> } \
> \
> - static ssize_t _f_##_opts_qmult_store(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_qmult_store(struct config_item *item, \
> const char *page, size_t len)\
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> u8 val; \
> int ret; \
> \
> @@ -140,15 +135,13 @@ out: \
> return ret; \
> } \
> \
> - static struct f_##_f_##_opts_attribute f_##_f_##_opts_qmult = \
> - __CONFIGFS_ATTR(qmult, S_IRUGO | S_IWUSR, \
> - _f_##_opts_qmult_show, \
> - _f_##_opts_qmult_store)
> + CONFIGFS_ATTR(_f_##_opts_, qmult)
>
> #define USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(_f_) \
> - static ssize_t _f_##_opts_ifname_show(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_ifname_show(struct config_item *item, \
> char *page) \
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int ret; \
> \
> mutex_lock(&opts->lock); \
> @@ -158,7 +151,6 @@ out: \
> return ret; \
> } \
> \
> - static struct f_##_f_##_opts_attribute f_##_f_##_opts_ifname = \
> - __CONFIGFS_ATTR_RO(ifname, _f_##_opts_ifname_show)
> + CONFIGFS_ATTR_RO(_f_##_opts_, ifname)
>
> #endif /* __U_ETHER_CONFIGFS_H */
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 06/23] usb-gadget/ether: use per-attribute show and store methods
Date: Mon, 28 Sep 2015 13:40:30 +0200 [thread overview]
Message-ID: <5609272E.20702@samsung.com> (raw)
In-Reply-To: <1443189000-13398-7-git-send-email-hch@lst.de>
W dniu 25.09.2015 o 15:49, Christoph Hellwig pisze:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> ---
> drivers/usb/gadget/function/f_ecm.c | 8 ++---
> drivers/usb/gadget/function/f_eem.c | 8 ++---
> drivers/usb/gadget/function/f_ncm.c | 8 ++---
> drivers/usb/gadget/function/f_rndis.c | 8 ++---
> drivers/usb/gadget/function/f_subset.c | 8 ++---
> drivers/usb/gadget/function/u_ether_configfs.h | 44 +++++++++++---------------
> 6 files changed, 38 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/function/f_ecm.c
> index 7b7424f..0106de8 100644
> --- a/drivers/usb/gadget/function/f_ecm.c
> +++ b/drivers/usb/gadget/function/f_ecm.c
> @@ -855,10 +855,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(ecm);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(ecm);
>
> static struct configfs_attribute *ecm_attrs[] = {
> - &f_ecm_opts_dev_addr.attr,
> - &f_ecm_opts_host_addr.attr,
> - &f_ecm_opts_qmult.attr,
> - &f_ecm_opts_ifname.attr,
> + &ecm_opts_attr_dev_addr,
> + &ecm_opts_attr_host_addr,
> + &ecm_opts_attr_qmult,
> + &ecm_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/f_eem.c b/drivers/usb/gadget/function/f_eem.c
> index c9e90de..f965403 100644
> --- a/drivers/usb/gadget/function/f_eem.c
> +++ b/drivers/usb/gadget/function/f_eem.c
> @@ -555,10 +555,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(eem);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(eem);
>
> static struct configfs_attribute *eem_attrs[] = {
> - &f_eem_opts_dev_addr.attr,
> - &f_eem_opts_host_addr.attr,
> - &f_eem_opts_qmult.attr,
> - &f_eem_opts_ifname.attr,
> + &eem_opts_attr_dev_addr,
> + &eem_opts_attr_host_addr,
> + &eem_opts_attr_qmult,
> + &eem_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/function/f_ncm.c
> index 3f05c6bd..01a99e5 100644
> --- a/drivers/usb/gadget/function/f_ncm.c
> +++ b/drivers/usb/gadget/function/f_ncm.c
> @@ -1503,10 +1503,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(ncm);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(ncm);
>
> static struct configfs_attribute *ncm_attrs[] = {
> - &f_ncm_opts_dev_addr.attr,
> - &f_ncm_opts_host_addr.attr,
> - &f_ncm_opts_qmult.attr,
> - &f_ncm_opts_ifname.attr,
> + &ncm_opts_attr_dev_addr,
> + &ncm_opts_attr_host_addr,
> + &ncm_opts_attr_qmult,
> + &ncm_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/f_rndis.c b/drivers/usb/gadget/function/f_rndis.c
> index 32985da..a04b526 100644
> --- a/drivers/usb/gadget/function/f_rndis.c
> +++ b/drivers/usb/gadget/function/f_rndis.c
> @@ -878,10 +878,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(rndis);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(rndis);
>
> static struct configfs_attribute *rndis_attrs[] = {
> - &f_rndis_opts_dev_addr.attr,
> - &f_rndis_opts_host_addr.attr,
> - &f_rndis_opts_qmult.attr,
> - &f_rndis_opts_ifname.attr,
> + &rndis_opts_attr_dev_addr,
> + &rndis_opts_attr_host_addr,
> + &rndis_opts_attr_qmult,
> + &rndis_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/f_subset.c b/drivers/usb/gadget/function/f_subset.c
> index e3dfa67..055e4ea 100644
> --- a/drivers/usb/gadget/function/f_subset.c
> +++ b/drivers/usb/gadget/function/f_subset.c
> @@ -413,10 +413,10 @@ USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(gether);
> USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(gether);
>
> static struct configfs_attribute *gether_attrs[] = {
> - &f_gether_opts_dev_addr.attr,
> - &f_gether_opts_host_addr.attr,
> - &f_gether_opts_qmult.attr,
> - &f_gether_opts_ifname.attr,
> + &gether_opts_attr_dev_addr,
> + &gether_opts_attr_host_addr,
> + &gether_opts_attr_qmult,
> + &gether_opts_attr_ifname,
> NULL,
> };
>
> diff --git a/drivers/usb/gadget/function/u_ether_configfs.h b/drivers/usb/gadget/function/u_ether_configfs.h
> index bcbd301..4f47289 100644
> --- a/drivers/usb/gadget/function/u_ether_configfs.h
> +++ b/drivers/usb/gadget/function/u_ether_configfs.h
> @@ -17,9 +17,6 @@
> #define __U_ETHER_CONFIGFS_H
>
> #define USB_ETHERNET_CONFIGFS_ITEM(_f_) \
> - CONFIGFS_ATTR_STRUCT(f_##_f_##_opts); \
> - CONFIGFS_ATTR_OPS(f_##_f_##_opts); \
> - \
> static void _f_##_attr_release(struct config_item *item) \
> { \
> struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> @@ -29,14 +26,13 @@
> \
> static struct configfs_item_operations _f_##_item_ops = { \
> .release = _f_##_attr_release, \
> - .show_attribute = f_##_f_##_opts_attr_show, \
> - .store_attribute = f_##_f_##_opts_attr_store, \
> }
>
> #define USB_ETHERNET_CONFIGFS_ITEM_ATTR_DEV_ADDR(_f_) \
> - static ssize_t _f_##_opts_dev_addr_show(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_dev_addr_show(struct config_item *item, \
> char *page) \
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int result; \
> \
> mutex_lock(&opts->lock); \
> @@ -46,9 +42,10 @@
> return result; \
> } \
> \
> - static ssize_t _f_##_opts_dev_addr_store(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_dev_addr_store(struct config_item *item, \
> const char *page, size_t len)\
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int ret; \
> \
> mutex_lock(&opts->lock); \
> @@ -64,15 +61,13 @@
> return ret; \
> } \
> \
> - static struct f_##_f_##_opts_attribute f_##_f_##_opts_dev_addr = \
> - __CONFIGFS_ATTR(dev_addr, S_IRUGO | S_IWUSR, \
> - _f_##_opts_dev_addr_show, \
> - _f_##_opts_dev_addr_store)
> + CONFIGFS_ATTR(_f_##_opts_, dev_addr)
>
> #define USB_ETHERNET_CONFIGFS_ITEM_ATTR_HOST_ADDR(_f_) \
> - static ssize_t _f_##_opts_host_addr_show(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_host_addr_show(struct config_item *item, \
> char *page) \
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int result; \
> \
> mutex_lock(&opts->lock); \
> @@ -82,9 +77,10 @@
> return result; \
> } \
> \
> - static ssize_t _f_##_opts_host_addr_store(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_host_addr_store(struct config_item *item, \
> const char *page, size_t len)\
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int ret; \
> \
> mutex_lock(&opts->lock); \
> @@ -100,15 +96,13 @@
> return ret; \
> } \
> \
> - static struct f_##_f_##_opts_attribute f_##_f_##_opts_host_addr = \
> - __CONFIGFS_ATTR(host_addr, S_IRUGO | S_IWUSR, \
> - _f_##_opts_host_addr_show, \
> - _f_##_opts_host_addr_store)
> + CONFIGFS_ATTR(_f_##_opts_, host_addr)
>
> #define USB_ETHERNET_CONFIGFS_ITEM_ATTR_QMULT(_f_) \
> - static ssize_t _f_##_opts_qmult_show(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_qmult_show(struct config_item *item, \
> char *page) \
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> unsigned qmult; \
> \
> mutex_lock(&opts->lock); \
> @@ -117,9 +111,10 @@
> return sprintf(page, "%d", qmult); \
> } \
> \
> - static ssize_t _f_##_opts_qmult_store(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_qmult_store(struct config_item *item, \
> const char *page, size_t len)\
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> u8 val; \
> int ret; \
> \
> @@ -140,15 +135,13 @@ out: \
> return ret; \
> } \
> \
> - static struct f_##_f_##_opts_attribute f_##_f_##_opts_qmult = \
> - __CONFIGFS_ATTR(qmult, S_IRUGO | S_IWUSR, \
> - _f_##_opts_qmult_show, \
> - _f_##_opts_qmult_store)
> + CONFIGFS_ATTR(_f_##_opts_, qmult)
>
> #define USB_ETHERNET_CONFIGFS_ITEM_ATTR_IFNAME(_f_) \
> - static ssize_t _f_##_opts_ifname_show(struct f_##_f_##_opts *opts, \
> + static ssize_t _f_##_opts_ifname_show(struct config_item *item, \
> char *page) \
> { \
> + struct f_##_f_##_opts *opts = to_f_##_f_##_opts(item); \
> int ret; \
> \
> mutex_lock(&opts->lock); \
> @@ -158,7 +151,6 @@ out: \
> return ret; \
> } \
> \
> - static struct f_##_f_##_opts_attribute f_##_f_##_opts_ifname = \
> - __CONFIGFS_ATTR_RO(ifname, _f_##_opts_ifname_show)
> + CONFIGFS_ATTR_RO(_f_##_opts_, ifname)
>
> #endif /* __U_ETHER_CONFIGFS_H */
>
next prev parent reply other threads:[~2015-09-28 11:40 UTC|newest]
Thread overview: 162+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 13:49 simplify configfs attributes Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [PATCH 01/23] configfs: add show and store methods to struct configfs_attribute Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 14:28 ` Tejun Heo
2015-09-25 14:28 ` [Cluster-devel] " Tejun Heo
2015-09-25 17:41 ` Greg KH
2015-09-25 17:41 ` [Cluster-devel] " Greg KH
2015-09-25 17:41 ` [Ocfs2-devel] " Greg KH
2015-09-26 23:38 ` Nicholas A. Bellinger
2015-09-26 23:38 ` [Cluster-devel] " Nicholas A. Bellinger
2015-09-25 13:49 ` [PATCH 02/23] usb-gadget: use per-attribute show and store methods Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-27 15:47 ` Felipe Balbi
2015-09-27 15:47 ` [Cluster-devel] " Felipe Balbi
[not found] ` <20150927154752.GC16364-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-09-28 13:33 ` Christoph Hellwig
2015-09-28 13:33 ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:33 ` [Ocfs2-devel] " Christoph Hellwig
[not found] ` <20150928133328.GA30453-jcswGhMUV9g@public.gmane.org>
2015-10-01 17:23 ` Felipe Balbi
2015-10-01 17:23 ` [Cluster-devel] " Felipe Balbi
2015-09-27 15:50 ` Felipe Balbi
2015-09-27 15:50 ` [Cluster-devel] " Felipe Balbi
2015-09-28 13:35 ` Christoph Hellwig
2015-09-28 13:35 ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:35 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-30 16:19 ` Felipe Balbi
2015-09-30 16:19 ` [Cluster-devel] " Felipe Balbi
2015-09-30 16:20 ` Tejun Heo
2015-09-30 16:20 ` [Cluster-devel] " Tejun Heo
2015-09-30 16:32 ` Felipe Balbi
2015-09-30 16:32 ` [Cluster-devel] " Felipe Balbi
2015-09-30 16:35 ` Tejun Heo
2015-09-30 16:35 ` [Cluster-devel] " Tejun Heo
2015-09-30 16:43 ` Felipe Balbi
2015-09-30 16:43 ` [Cluster-devel] " Felipe Balbi
2015-09-30 16:59 ` Tejun Heo
2015-09-30 16:59 ` [Cluster-devel] " Tejun Heo
[not found] ` <1443189000-13398-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-28 10:54 ` Andrzej Pietrasiewicz
2015-09-28 10:54 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 03/23] usb-gadget/uvc: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
[not found] ` <1443189000-13398-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-28 11:35 ` Andrzej Pietrasiewicz
2015-09-28 11:35 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 13:39 ` Christoph Hellwig
2015-09-28 13:39 ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:39 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [PATCH 04/23] usb-gadget/f_hid: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:37 ` Andrzej Pietrasiewicz
2015-09-28 11:37 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 05/23] usb-gadget/f_acm: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:39 ` Andrzej Pietrasiewicz
2015-09-28 11:39 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 06/23] usb-gadget/ether: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
[not found] ` <1443189000-13398-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-28 11:40 ` Andrzej Pietrasiewicz [this message]
2015-09-28 11:40 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 08/23] usb-gadget/f_midi: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
[not found] ` <1443189000-13398-9-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-28 11:47 ` Andrzej Pietrasiewicz
2015-09-28 11:47 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 09/23] usb-gadget/f_printer: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:50 ` Andrzej Pietrasiewicz
2015-09-28 11:50 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 10/23] usb-gadget/f_sourcesink: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:51 ` Andrzej Pietrasiewicz
2015-09-28 11:51 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 11/23] usb-gadget/f_mass_storage: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:53 ` Andrzej Pietrasiewicz
2015-09-28 11:53 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 12/23] usb-gadget/f_ac1: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:56 ` Andrzej Pietrasiewicz
2015-09-28 11:56 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 13/23] usb-gadget/f_uac2: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:56 ` Andrzej Pietrasiewicz
2015-09-28 11:56 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 14/23] usb-gadget/f_obex: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:57 ` Andrzej Pietrasiewicz
2015-09-28 11:57 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 15/23] usb-gadget/f_phonet: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:59 ` Andrzej Pietrasiewicz
2015-09-28 11:59 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 16/23] usb-gadget/f_serial: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:59 ` Andrzej Pietrasiewicz
2015-09-28 11:59 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 17/23] dlm: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 14:49 ` David Teigland
2015-09-28 14:49 ` [Cluster-devel] " David Teigland
2015-09-28 14:49 ` [Ocfs2-devel] " David Teigland
2015-09-25 13:49 ` [PATCH 18/23] spear13xx_pcie_gadget: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [PATCH 19/23] target: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-26 23:35 ` Nicholas A. Bellinger
2015-09-26 23:35 ` [Cluster-devel] " Nicholas A. Bellinger
[not found] ` <1443189000-13398-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-09-25 13:49 ` [PATCH 07/23] usb-gadget/f_loopback: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 11:46 ` Andrzej Pietrasiewicz
2015-09-28 11:46 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 13:41 ` Christoph Hellwig
2015-09-28 13:41 ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:41 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 13:52 ` Andrzej Pietrasiewicz
2015-09-28 13:52 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-25 13:49 ` [PATCH 20/23] netconsole: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [PATCH 21/23] ocfs2/cluster: move locking into attribute " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:57 ` simplify configfs attributes Christoph Hellwig
2015-09-25 13:57 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:57 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:49 ` [PATCH 22/23] ocfs2/cluster: use per-attribute show and store methods Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:49 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-25 13:50 ` [PATCH 23/23] configfs: remove old API Christoph Hellwig
2015-09-25 13:50 ` [Cluster-devel] " Christoph Hellwig
2015-09-25 13:50 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 12:06 ` Andrzej Pietrasiewicz
2015-09-28 12:06 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-09-28 13:42 ` Christoph Hellwig
2015-09-28 13:42 ` [Cluster-devel] " Christoph Hellwig
2015-09-28 13:42 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-26 23:49 ` simplify configfs attributes Nicholas A. Bellinger
2015-09-26 23:49 ` [Cluster-devel] " Nicholas A. Bellinger
2015-09-27 6:30 ` Christoph Hellwig
2015-09-27 6:30 ` [Cluster-devel] " Christoph Hellwig
2015-09-27 6:30 ` [Ocfs2-devel] " Christoph Hellwig
2015-09-28 12:12 ` Andrzej Pietrasiewicz
2015-09-28 12:12 ` [Cluster-devel] " Andrzej Pietrasiewicz
2015-10-03 13:32 simplify configfs attributes V2 Christoph Hellwig
2015-10-03 13:32 ` [PATCH 06/23] usb-gadget/ether: use per-attribute show and store methods Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5609272E.20702@samsung.com \
--to=andrzej.p-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org \
--cc=pratyush.anand-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.