From: Xiao Guangrong <guangrong.xiao@linux.intel.com> To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, pbonzini@redhat.com, imammedo@redhat.com Cc: gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, eblake@redhat.com Subject: Re: [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Date: Mon, 2 Nov 2015 21:08:18 +0800 [thread overview] Message-ID: <56376042.4090002@linux.intel.com> (raw) In-Reply-To: <563754D5.2060401@virtuozzo.com> On 11/02/2015 08:19 PM, Vladimir Sementsov-Ogievskiy wrote: > On 02.11.2015 12:13, Xiao Guangrong wrote: >> Curretly, the memory region of backed memory is directly mapped to >> guest's address space, however, it is not true for nvdimm device >> >> This patch let dimm device realize this fact and use >> DIMMDeviceClass->get_memory_region method to get the mapped memory >> region >> >> Current code did not check the return value of get_memory_region as it >> assumed the backend memory of pc-dimm is always properly initialized, >> we make get_memory_region internally catch the case if something is >> wrong >> >> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> >> --- >> hw/mem/dimm.c | 3 ++- >> hw/mem/pc-dimm.c | 12 +++++++++++- >> 2 files changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/hw/mem/dimm.c b/hw/mem/dimm.c >> index 4a63409..498d380 100644 >> --- a/hw/mem/dimm.c >> +++ b/hw/mem/dimm.c >> @@ -377,8 +377,9 @@ static void dimm_get_size(Object *obj, Visitor *v, void *opaque, >> int64_t value; >> MemoryRegion *mr; >> DIMMDevice *dimm = DIMM(obj); >> + DIMMDeviceClass *ddc = DIMM_GET_CLASS(obj); >> - mr = host_memory_backend_get_memory(dimm->hostmem, errp); >> + mr = ddc->get_memory_region(dimm); >> value = memory_region_size(mr); >> visit_type_int(v, &value, name, errp); >> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c >> index 38323e9..e6b6a9f 100644 >> --- a/hw/mem/pc-dimm.c >> +++ b/hw/mem/pc-dimm.c >> @@ -22,7 +22,17 @@ >> static MemoryRegion *pc_dimm_get_memory_region(DIMMDevice *dimm) >> { >> - return host_memory_backend_get_memory(dimm->hostmem, &error_abort); >> + Error *local_err = NULL; >> + MemoryRegion *mr; >> + >> + mr = host_memory_backend_get_memory(dimm->hostmem, &local_err); >> + >> + /* >> + * plug a pc-dimm device whose backend memory was not properly >> + * initialized? >> + */ >> + assert(!local_err && mr); >> + return mr; >> } > > this should squashed into previous patch, I think You mean merger this patch with 19/35 (dimm: abstract dimm device from pc-dimm)? The 19/35 mostly ‘moves’ the things, this one changes the core logic, it is not a big deal. :D > >> static void pc_dimm_class_init(ObjectClass *oc, void *data) > > I've discovered suddenly, that > > MemoryRegion * > host_memory_backend_get_memory(HostMemoryBackend *backend, Error **errp) > { > return memory_region_size(&backend->mr) ? &backend->mr : NULL; > } > > - it doesn't use errp at all. In my opinion, this should be fixed globally, by deleting useless > parameter in separate patch. Or just squash your function into previous patch. > Yup, this is a globally interface so i prefer to make a separate patch to do the cleanup after this patchset.
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com> To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, pbonzini@redhat.com, imammedo@redhat.com Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net Subject: Re: [Qemu-devel] [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Date: Mon, 2 Nov 2015 21:08:18 +0800 [thread overview] Message-ID: <56376042.4090002@linux.intel.com> (raw) In-Reply-To: <563754D5.2060401@virtuozzo.com> On 11/02/2015 08:19 PM, Vladimir Sementsov-Ogievskiy wrote: > On 02.11.2015 12:13, Xiao Guangrong wrote: >> Curretly, the memory region of backed memory is directly mapped to >> guest's address space, however, it is not true for nvdimm device >> >> This patch let dimm device realize this fact and use >> DIMMDeviceClass->get_memory_region method to get the mapped memory >> region >> >> Current code did not check the return value of get_memory_region as it >> assumed the backend memory of pc-dimm is always properly initialized, >> we make get_memory_region internally catch the case if something is >> wrong >> >> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com> >> --- >> hw/mem/dimm.c | 3 ++- >> hw/mem/pc-dimm.c | 12 +++++++++++- >> 2 files changed, 13 insertions(+), 2 deletions(-) >> >> diff --git a/hw/mem/dimm.c b/hw/mem/dimm.c >> index 4a63409..498d380 100644 >> --- a/hw/mem/dimm.c >> +++ b/hw/mem/dimm.c >> @@ -377,8 +377,9 @@ static void dimm_get_size(Object *obj, Visitor *v, void *opaque, >> int64_t value; >> MemoryRegion *mr; >> DIMMDevice *dimm = DIMM(obj); >> + DIMMDeviceClass *ddc = DIMM_GET_CLASS(obj); >> - mr = host_memory_backend_get_memory(dimm->hostmem, errp); >> + mr = ddc->get_memory_region(dimm); >> value = memory_region_size(mr); >> visit_type_int(v, &value, name, errp); >> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c >> index 38323e9..e6b6a9f 100644 >> --- a/hw/mem/pc-dimm.c >> +++ b/hw/mem/pc-dimm.c >> @@ -22,7 +22,17 @@ >> static MemoryRegion *pc_dimm_get_memory_region(DIMMDevice *dimm) >> { >> - return host_memory_backend_get_memory(dimm->hostmem, &error_abort); >> + Error *local_err = NULL; >> + MemoryRegion *mr; >> + >> + mr = host_memory_backend_get_memory(dimm->hostmem, &local_err); >> + >> + /* >> + * plug a pc-dimm device whose backend memory was not properly >> + * initialized? >> + */ >> + assert(!local_err && mr); >> + return mr; >> } > > this should squashed into previous patch, I think You mean merger this patch with 19/35 (dimm: abstract dimm device from pc-dimm)? The 19/35 mostly ‘moves’ the things, this one changes the core logic, it is not a big deal. :D > >> static void pc_dimm_class_init(ObjectClass *oc, void *data) > > I've discovered suddenly, that > > MemoryRegion * > host_memory_backend_get_memory(HostMemoryBackend *backend, Error **errp) > { > return memory_region_size(&backend->mr) ? &backend->mr : NULL; > } > > - it doesn't use errp at all. In my opinion, this should be fixed globally, by deleting useless > parameter in separate patch. Or just squash your function into previous patch. > Yup, this is a globally interface so i prefer to make a separate patch to do the cleanup after this patchset.
next prev parent reply other threads:[~2015-11-02 13:15 UTC|newest] Thread overview: 200+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-02 9:13 [PATCH v7 00/35] implement vNVDIMM Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 01/35] acpi: add aml_derefof Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 02/35] acpi: add aml_sizeof Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 03/35] acpi: add aml_create_field Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-03 6:14 ` Shannon Zhao 2015-11-03 6:14 ` [Qemu-devel] " Shannon Zhao 2015-11-03 14:52 ` Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 04/35] acpi: add aml_concatenate Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 05/35] acpi: add aml_object_type Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 06/35] acpi: add aml_method_serialized Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-03 12:30 ` Igor Mammedov 2015-11-03 12:30 ` Igor Mammedov 2015-11-03 13:27 ` Xiao Guangrong 2015-11-03 13:27 ` Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 07/35] util: introduce qemu_file_get_page_size() Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 13:56 ` Vladimir Sementsov-Ogievskiy 2015-11-02 13:56 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-06 15:36 ` Eduardo Habkost 2015-11-06 15:36 ` [Qemu-devel] " Eduardo Habkost 2015-11-09 4:36 ` Xiao Guangrong 2015-11-09 4:36 ` [Qemu-devel] " Xiao Guangrong 2015-11-09 18:34 ` Eduardo Habkost 2015-11-09 18:34 ` [Qemu-devel] " Eduardo Habkost 2015-11-02 9:13 ` [PATCH v7 08/35] exec: allow memory to be allocated from any kind of path Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 14:51 ` Vladimir Sementsov-Ogievskiy 2015-11-02 14:51 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-02 15:22 ` Xiao Guangrong 2015-11-02 15:22 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 15:52 ` Vladimir Sementsov-Ogievskiy 2015-11-02 15:52 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-03 23:00 ` Eduardo Habkost 2015-11-03 23:00 ` [Qemu-devel] " Eduardo Habkost 2015-11-04 3:12 ` Xiao Guangrong 2015-11-04 3:12 ` [Qemu-devel] " Xiao Guangrong 2015-11-04 12:40 ` Eduardo Habkost 2015-11-04 12:40 ` [Qemu-devel] " Eduardo Habkost 2015-11-04 14:22 ` Xiao Guangrong 2015-11-04 14:22 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 09/35] exec: allow file_ram_alloc to work on file Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 15:12 ` Vladimir Sementsov-Ogievskiy 2015-11-02 15:12 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-02 15:25 ` Xiao Guangrong 2015-11-02 15:25 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 15:58 ` Vladimir Sementsov-Ogievskiy 2015-11-02 15:58 ` Vladimir Sementsov-Ogievskiy 2015-11-02 21:12 ` Paolo Bonzini 2015-11-02 21:12 ` [Qemu-devel] " Paolo Bonzini 2015-11-03 3:56 ` Xiao Guangrong 2015-11-03 3:56 ` [Qemu-devel] " Xiao Guangrong 2015-11-03 13:55 ` Paolo Bonzini 2015-11-03 13:55 ` [Qemu-devel] " Paolo Bonzini 2015-11-03 14:26 ` Xiao Guangrong 2015-11-03 14:26 ` [Qemu-devel] " Xiao Guangrong 2015-11-03 12:34 ` Igor Mammedov 2015-11-03 12:34 ` [Qemu-devel] " Igor Mammedov 2015-11-03 13:32 ` Xiao Guangrong 2015-11-03 13:32 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 10/35] hostmem-file: clean up memory allocation Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 11/35] util: introduce qemu_file_getlength() Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 15:26 ` Vladimir Sementsov-Ogievskiy 2015-11-02 15:26 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-03 23:21 ` Eduardo Habkost 2015-11-03 23:21 ` [Qemu-devel] " Eduardo Habkost 2015-11-04 3:17 ` Xiao Guangrong 2015-11-04 3:17 ` [Qemu-devel] " Xiao Guangrong 2015-11-04 14:44 ` Eduardo Habkost 2015-11-04 14:44 ` [Qemu-devel] " Eduardo Habkost 2015-11-04 14:44 ` Xiao Guangrong 2015-11-04 14:44 ` [Qemu-devel] " Xiao Guangrong 2015-11-06 15:50 ` Eduardo Habkost 2015-11-06 15:50 ` [Qemu-devel] " Eduardo Habkost 2015-11-09 4:44 ` Xiao Guangrong 2015-11-09 4:44 ` [Qemu-devel] " Xiao Guangrong 2015-11-09 19:21 ` Eduardo Habkost 2015-11-09 19:21 ` [Qemu-devel] " Eduardo Habkost 2015-11-02 9:13 ` [PATCH v7 12/35] util: let qemu_fd_getlength support block device Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 16:11 ` Vladimir Sementsov-Ogievskiy 2015-11-02 16:11 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-02 16:21 ` Xiao Guangrong 2015-11-02 16:21 ` [Qemu-devel] " Xiao Guangrong 2015-11-06 15:44 ` Eduardo Habkost 2015-11-06 15:44 ` [Qemu-devel] " Eduardo Habkost 2015-11-06 15:48 ` Eduardo Habkost 2015-11-06 15:48 ` [Qemu-devel] " Eduardo Habkost 2015-11-06 15:54 ` Eduardo Habkost 2015-11-06 15:54 ` [Qemu-devel] " Eduardo Habkost 2015-11-09 5:58 ` Xiao Guangrong 2015-11-09 5:58 ` [Qemu-devel] " Xiao Guangrong 2015-11-09 18:43 ` Eduardo Habkost 2015-11-09 18:43 ` [Qemu-devel] " Eduardo Habkost 2015-11-02 9:13 ` [PATCH v7 13/35] hostmem-file: use whole file size if possible Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 17:09 ` Vladimir Sementsov-Ogievskiy 2015-11-02 17:09 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-03 14:51 ` Xiao Guangrong 2015-11-03 14:51 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 14/35] pc-dimm: remove DEFAULT_PC_DIMMSIZE Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 15/35] pc-dimm: make pc_existing_dimms_capacity static and rename it Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 16/35] pc-dimm: drop the prefix of pc-dimm Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 17/35] stubs: rename qmp_pc_dimm_device_list.c Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 18/35] pc-dimm: rename pc-dimm.c and pc-dimm.h Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 19/35] dimm: abstract dimm device from pc-dimm Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 20/35] dimm: get mapped memory region from DIMMDeviceClass->get_memory_region Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 12:19 ` Vladimir Sementsov-Ogievskiy 2015-11-02 12:19 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-02 13:08 ` Xiao Guangrong [this message] 2015-11-02 13:08 ` Xiao Guangrong 2015-11-02 14:26 ` Vladimir Sementsov-Ogievskiy 2015-11-02 14:26 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-02 15:06 ` Xiao Guangrong 2015-11-02 15:06 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 16:16 ` Vladimir Sementsov-Ogievskiy 2015-11-02 16:16 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-03 14:47 ` Xiao Guangrong 2015-11-03 14:47 ` [Qemu-devel] " Xiao Guangrong 2015-11-05 8:53 ` Vladimir Sementsov-Ogievskiy 2015-11-05 8:53 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-05 17:29 ` Eduardo Habkost 2015-11-05 17:29 ` [Qemu-devel] " Eduardo Habkost 2015-11-06 2:50 ` Xiao Guangrong 2015-11-06 2:50 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 21/35] dimm: keep the state of the whole backend memory Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 22/35] dimm: introduce realize callback Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 23/35] nvdimm: implement NVDIMM device abstract Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-13 16:53 ` Vladimir Sementsov-Ogievskiy 2015-11-13 16:53 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy 2015-11-02 9:13 ` [PATCH v7 24/35] docs: add NVDIMM ACPI documentation Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-05 9:58 ` Igor Mammedov 2015-11-05 9:58 ` [Qemu-devel] " Igor Mammedov 2015-11-05 10:15 ` Xiao Guangrong 2015-11-05 10:15 ` [Qemu-devel] " Xiao Guangrong 2015-11-05 13:03 ` Igor Mammedov 2015-11-05 13:03 ` [Qemu-devel] " Igor Mammedov 2015-11-05 13:33 ` Xiao Guangrong 2015-11-05 13:33 ` [Qemu-devel] " Xiao Guangrong 2015-11-05 14:49 ` Igor Mammedov 2015-11-05 14:49 ` [Qemu-devel] " Igor Mammedov 2015-11-06 8:31 ` Xiao Guangrong 2015-11-06 8:31 ` [Qemu-devel] " Xiao Guangrong 2015-11-06 8:56 ` Xiao Guangrong 2015-11-06 8:56 ` [Qemu-devel] " Xiao Guangrong 2015-11-09 11:13 ` Igor Mammedov 2015-11-11 3:01 ` Ask for ACK (was Re: [PATCH v7 25/35] nvdimm acpi: init the resource used by NVDIMM ACPI) Xiao Guangrong 2015-11-11 3:01 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 26/35] nvdimm acpi: build ACPI NFIT table Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 27/35] nvdimm acpi: build ACPI nvdimm devices Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-03 13:13 ` Igor Mammedov 2015-11-03 13:13 ` [Qemu-devel] " Igor Mammedov 2015-11-03 14:22 ` Xiao Guangrong 2015-11-03 14:22 ` [Qemu-devel] " Xiao Guangrong 2015-11-04 8:56 ` Igor Mammedov 2015-11-04 8:56 ` [Qemu-devel] " Igor Mammedov 2015-11-04 14:11 ` Xiao Guangrong 2015-11-04 14:11 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 28/35] nvdimm acpi: save arg3 for NVDIMM device _DSM method Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 29/35] nvdimm acpi: support function 0 Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 30/35] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 31/35] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 32/35] nvdimm acpi: support Set " Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 33/35] nvdimm: allow using whole backend memory as pmem Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 34/35] nvdimm acpi: support _FIT method Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 9:13 ` [PATCH v7 35/35] nvdimm: add maintain info Xiao Guangrong 2015-11-02 9:13 ` [Qemu-devel] " Xiao Guangrong 2015-11-02 11:51 ` [PATCH v7 00/35] implement vNVDIMM Stefan Hajnoczi 2015-11-02 11:51 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56376042.4090002@linux.intel.com \ --to=guangrong.xiao@linux.intel.com \ --cc=dan.j.williams@intel.com \ --cc=eblake@redhat.com \ --cc=ehabkost@redhat.com \ --cc=gleb@kernel.org \ --cc=imammedo@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=stefanha@redhat.com \ --cc=vsementsov@virtuozzo.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.