From: Guenter Roeck <linux@roeck-us.net> To: Carlo Caione <carlo@endlessm.com> Cc: Carlo Caione <carlo@caione.org>, wim@iguana.be, linux-watchdog@vger.kernel.org, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, robh+dt@kernel.org, Daniel Drake <drake@endlessm.com>, Jerry Cao <jerry.cao@amlogic.com>, Victor Wan <victor.wan@amlogic.com>, romain.perier@gmail.com Subject: Re: [PATCH 1/4] watchdog: meson: Enable meson SoC specific data Date: Fri, 6 Nov 2015 16:02:43 -0800 [thread overview] Message-ID: <563D3FA3.8020305@roeck-us.net> (raw) In-Reply-To: <CAL9uMOH4i4ajkF2x7agHe2WZcHTJ=vs9cO+TGx8WGLOFVLZnig@mail.gmail.com> On 11/06/2015 02:47 PM, Carlo Caione wrote: > On Fri, Nov 6, 2015 at 11:15 PM, Guenter Roeck <linux@roeck-us.net> wrote: > [ ... ] >>> >>> static int meson_restart_handle(struct notifier_block *this, unsigned long mode, >>> void *cmd) >>> { >>> - u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN; >>> + u32 tc_reboot = MESON_WDT_DC_RESET; >>> struct meson_wdt_dev *meson_wdt = container_of(this, >>> struct meson_wdt_dev, >>> restart_handler); >>> + tc_reboot |= BIT(meson_wdt->data->shift_enable); >>> >> >> I am quite sure that this results in a checkpatch warning. >> Did you run your patch through checkpatch ? > > Yeah, no error/warnings on that line. > There should be a warning since there is no empty line after the declarations. Maybe checkpatch doesn't catch it because of the continuation line above. Still, the extra line would be appreciated. Thanks, Guenter
WARNING: multiple messages have this Message-ID (diff)
From: linux@roeck-us.net (Guenter Roeck) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/4] watchdog: meson: Enable meson SoC specific data Date: Fri, 6 Nov 2015 16:02:43 -0800 [thread overview] Message-ID: <563D3FA3.8020305@roeck-us.net> (raw) In-Reply-To: <CAL9uMOH4i4ajkF2x7agHe2WZcHTJ=vs9cO+TGx8WGLOFVLZnig@mail.gmail.com> On 11/06/2015 02:47 PM, Carlo Caione wrote: > On Fri, Nov 6, 2015 at 11:15 PM, Guenter Roeck <linux@roeck-us.net> wrote: > [ ... ] >>> >>> static int meson_restart_handle(struct notifier_block *this, unsigned long mode, >>> void *cmd) >>> { >>> - u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN; >>> + u32 tc_reboot = MESON_WDT_DC_RESET; >>> struct meson_wdt_dev *meson_wdt = container_of(this, >>> struct meson_wdt_dev, >>> restart_handler); >>> + tc_reboot |= BIT(meson_wdt->data->shift_enable); >>> >> >> I am quite sure that this results in a checkpatch warning. >> Did you run your patch through checkpatch ? > > Yeah, no error/warnings on that line. > There should be a warning since there is no empty line after the declarations. Maybe checkpatch doesn't catch it because of the continuation line above. Still, the extra line would be appreciated. Thanks, Guenter
next prev parent reply other threads:[~2015-11-07 0:02 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-06 21:55 [PATCH 0/4] watchdog: meson: Add meson8b watchdog Carlo Caione 2015-11-06 21:55 ` Carlo Caione 2015-11-06 21:55 ` [PATCH 1/4] watchdog: meson: Enable meson SoC specific data Carlo Caione 2015-11-06 21:55 ` Carlo Caione 2015-11-06 22:15 ` Guenter Roeck 2015-11-06 22:15 ` Guenter Roeck 2015-11-06 22:47 ` Carlo Caione 2015-11-06 22:47 ` Carlo Caione 2015-11-07 0:02 ` Guenter Roeck [this message] 2015-11-07 0:02 ` Guenter Roeck 2015-11-06 21:55 ` [PATCH 2/4] watchdog: meson: Add meson8b " Carlo Caione 2015-11-06 21:55 ` Carlo Caione 2015-11-06 21:55 ` [PATCH 3/4] Documentation: watchdog: Add new bindings for meson8b Carlo Caione 2015-11-06 21:55 ` Carlo Caione 2015-11-06 21:55 ` [PATCH 4/4] ARM: dts: meson8b: Add watchdog node Carlo Caione 2015-11-06 21:55 ` Carlo Caione
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=563D3FA3.8020305@roeck-us.net \ --to=linux@roeck-us.net \ --cc=carlo@caione.org \ --cc=carlo@endlessm.com \ --cc=drake@endlessm.com \ --cc=jerry.cao@amlogic.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=romain.perier@gmail.com \ --cc=victor.wan@amlogic.com \ --cc=wim@iguana.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.