All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: Timur Tabi <timur@codeaurora.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	cov@codeaurora.org, jcm@redhat.com,
	Andy Gross <agross@codeaurora.org>,
	linux-arm-msm@vger.kernel.org,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Doug Gilbert <dgilbert@interlog.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 2/3] scsi: fix compiler warning for sg
Date: Mon, 9 Nov 2015 23:51:35 -0500	[thread overview]
Message-ID: <564177D7.7070103@codeaurora.org> (raw)
In-Reply-To: <564163F7.2020109@codeaurora.org>



On 11/9/2015 10:26 PM, Timur Tabi wrote:
> Sinan Kaya wrote:
>>
>> I created this patch back in March with an older version of the compiler
>> and older kernel (3.19). I'm no longer able to reproduce this with this
>> compiler and linux-next.
>>
>> Thread model: posix
>> gcc version 4.8.3 20140401 (prerelease) (crosstool-NG
>> linaro-1.13.1-4.8-2014.04 - Linaro GCC 4.8-2014.04)
>>
>> I'll drop this patch.
>
> Are you sure the compiler handles the old macro correctly?  Maybe it's
> just quiescing the error message, but it's still broken?
>

The code says it is using these macros for small integers only which 
can't overflow. I was trying to get rid of compiler warning and it seems 
to have disappeared.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/3] scsi: fix compiler warning for sg
Date: Mon, 9 Nov 2015 23:51:35 -0500	[thread overview]
Message-ID: <564177D7.7070103@codeaurora.org> (raw)
In-Reply-To: <564163F7.2020109@codeaurora.org>



On 11/9/2015 10:26 PM, Timur Tabi wrote:
> Sinan Kaya wrote:
>>
>> I created this patch back in March with an older version of the compiler
>> and older kernel (3.19). I'm no longer able to reproduce this with this
>> compiler and linux-next.
>>
>> Thread model: posix
>> gcc version 4.8.3 20140401 (prerelease) (crosstool-NG
>> linaro-1.13.1-4.8-2014.04 - Linaro GCC 4.8-2014.04)
>>
>> I'll drop this patch.
>
> Are you sure the compiler handles the old macro correctly?  Maybe it's
> just quiescing the error message, but it's still broken?
>

The code says it is using these macros for small integers only which 
can't overflow. I was trying to get rid of compiler warning and it seems 
to have disappeared.

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project

  reply	other threads:[~2015-11-10  4:51 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09  1:57 [PATCH V2 0/3] scsi: mptxsas: updates for ARM64 Sinan Kaya
2015-11-09  1:57 ` Sinan Kaya
2015-11-09  1:57 ` [PATCH V2 1/3] scsi: mptxsas: try 64 bit DMA when 32 bit DMA fails Sinan Kaya
2015-11-09  1:57   ` Sinan Kaya
2015-11-09  7:09   ` Hannes Reinecke
2015-11-09  7:09     ` Hannes Reinecke
2015-11-09  8:59     ` Arnd Bergmann
2015-11-09  8:59       ` Arnd Bergmann
2015-11-09 14:07       ` Sinan Kaya
2015-11-09 14:07         ` Sinan Kaya
2015-11-09 14:33         ` Arnd Bergmann
2015-11-09 14:33           ` Arnd Bergmann
2015-11-09 23:22           ` Sinan Kaya
2015-11-09 23:22             ` Sinan Kaya
2015-11-09 23:29             ` Timur Tabi
2015-11-09 23:29               ` Timur Tabi
2015-11-10  8:38             ` Arnd Bergmann
2015-11-10  8:38               ` Arnd Bergmann
2015-11-10 16:06               ` Sinan Kaya
2015-11-10 16:06                 ` Sinan Kaya
2015-11-10 16:47                 ` Arnd Bergmann
2015-11-10 16:47                   ` Arnd Bergmann
2015-11-10 17:00                   ` Timur Tabi
2015-11-10 17:00                     ` Timur Tabi
2015-11-10 19:13                     ` Arnd Bergmann
2015-11-10 19:13                       ` Arnd Bergmann
2015-11-10 21:03                       ` Timur Tabi
2015-11-10 21:03                         ` Timur Tabi
2015-11-10 21:54                         ` Arnd Bergmann
2015-11-10 21:54                           ` Arnd Bergmann
2015-11-10 21:59                           ` Timur Tabi
2015-11-10 21:59                             ` Timur Tabi
2015-11-10 22:08                             ` Arnd Bergmann
2015-11-10 22:08                               ` Arnd Bergmann
2015-11-10 17:19                   ` Sinan Kaya
2015-11-10 17:19                     ` Sinan Kaya
2015-11-10 18:27                     ` James Bottomley
2015-11-10 18:27                       ` James Bottomley
2015-11-10 19:14                       ` Sinan Kaya
2015-11-10 19:14                         ` Sinan Kaya
2015-11-10 19:43                         ` James Bottomley
2015-11-10 19:43                           ` James Bottomley
2015-11-10 19:56                           ` Sinan Kaya
2015-11-10 19:56                             ` Sinan Kaya
2015-11-10 20:05                             ` James Bottomley
2015-11-10 20:05                               ` James Bottomley
2015-11-10 20:26                               ` Sinan Kaya
2015-11-10 20:26                                 ` Sinan Kaya
2015-11-10 20:35                                 ` James Bottomley
2015-11-10 20:35                                   ` James Bottomley
2015-11-10 19:56                     ` Arnd Bergmann
2015-11-10 19:56                       ` Arnd Bergmann
2015-11-10 20:58                       ` Sinan Kaya
2015-11-10 20:58                         ` Sinan Kaya
2015-11-10 22:06                         ` Arnd Bergmann
2015-11-10 22:06                           ` Arnd Bergmann
2015-11-09 14:00     ` Sinan Kaya
2015-11-09 14:00       ` Sinan Kaya
2015-11-09  1:57 ` [PATCH V2 2/3] scsi: fix compiler warning for sg Sinan Kaya
2015-11-09  1:57   ` Sinan Kaya
2015-11-09 14:14   ` Andy Shevchenko
2015-11-09 14:14     ` Andy Shevchenko
2015-11-10  3:21     ` Sinan Kaya
2015-11-10  3:21       ` Sinan Kaya
2015-11-10  3:21       ` Sinan Kaya
2015-11-10  3:26       ` Timur Tabi
2015-11-10  3:26         ` Timur Tabi
2015-11-10  4:51         ` Sinan Kaya [this message]
2015-11-10  4:51           ` Sinan Kaya
2015-11-10  4:53           ` Timur Tabi
2015-11-10  4:53             ` Timur Tabi
2015-11-10  9:23             ` Andy Shevchenko
2015-11-10  9:23               ` Andy Shevchenko
2015-11-10 10:09             ` Arnd Bergmann
2015-11-10 10:09               ` Arnd Bergmann
2015-11-09  1:57 ` [PATCH V2 3/3] scsi: mptxsas: offload IRQ execution Sinan Kaya
2015-11-09  1:57   ` Sinan Kaya
2015-11-09  7:15   ` Hannes Reinecke
2015-11-09  7:15     ` Hannes Reinecke
2015-11-09 14:01     ` Sinan Kaya
2015-11-09 14:01       ` Sinan Kaya
2015-11-10  5:59     ` Sinan Kaya
2015-11-10  5:59       ` Sinan Kaya
2015-11-10  5:59       ` Sinan Kaya
2016-03-16 15:31       ` Christopher Covington
2016-03-16 15:31         ` Christopher Covington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564177D7.7070103@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=JBottomley@odin.com \
    --cc=agross@codeaurora.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=cov@codeaurora.org \
    --cc=dgilbert@interlog.com \
    --cc=jcm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.