From: Mark yao <mark.yao@rock-chips.com>
To: Chris Zhong <zyw@rock-chips.com>,
heiko@sntech.de, linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
David Airlie <airlied@linux.ie>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/12] drm/rockchip: return a true clock rate to adjusted_mode
Date: Thu, 19 Nov 2015 15:08:29 +0800 [thread overview]
Message-ID: <564D756D.9050000@rock-chips.com> (raw)
In-Reply-To: <1447904131-29328-4-git-send-email-zyw@rock-chips.com>
On 2015年11月19日 11:35, Chris Zhong wrote:
> +
> + /*
> + * Sometimes the clock driver can not set a accurate clock_rate for vop,
> + * get the true rate of vop_dclk and set it back to adjusted_mode.
> + */
> + adjusted_mode->clock = clk_get_rate(vop->dclk) / 1000;
> out:
> ret_clk = clk_enable(vop->dclk);
> if (ret_clk < 0) {
Hi Chris
How about use clk_round_rate to check the clock rate first?
I think we can check it on vop_crtc_mode_fixup.
Thanks.
- Ｍark Yao
WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: Chris Zhong <zyw@rock-chips.com>,
heiko@sntech.de, linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 03/12] drm/rockchip: return a true clock rate to adjusted_mode
Date: Thu, 19 Nov 2015 15:08:29 +0800 [thread overview]
Message-ID: <564D756D.9050000@rock-chips.com> (raw)
In-Reply-To: <1447904131-29328-4-git-send-email-zyw@rock-chips.com>
On 2015年11月19日 11:35, Chris Zhong wrote:
> +
> + /*
> + * Sometimes the clock driver can not set a accurate clock_rate for vop,
> + * get the true rate of vop_dclk and set it back to adjusted_mode.
> + */
> + adjusted_mode->clock = clk_get_rate(vop->dclk) / 1000;
> out:
> ret_clk = clk_enable(vop->dclk);
> if (ret_clk < 0) {
Hi Chris
How about use clk_round_rate to check the clock rate first?
I think we can check it on vop_crtc_mode_fixup.
Thanks.
- Ｍark Yao
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/12] drm/rockchip: return a true clock rate to adjusted_mode
Date: Thu, 19 Nov 2015 15:08:29 +0800 [thread overview]
Message-ID: <564D756D.9050000@rock-chips.com> (raw)
In-Reply-To: <1447904131-29328-4-git-send-email-zyw@rock-chips.com>
On 2015?11?19? 11:35, Chris Zhong wrote:
> +
> + /*
> + * Sometimes the clock driver can not set a accurate clock_rate for vop,
> + * get the true rate of vop_dclk and set it back to adjusted_mode.
> + */
> + adjusted_mode->clock = clk_get_rate(vop->dclk) / 1000;
> out:
> ret_clk = clk_enable(vop->dclk);
> if (ret_clk < 0) {
Hi Chris
How about use clk_round_rate to check the clock rate first?
I think we can check it on vop_crtc_mode_fixup.
Thanks.
- ?ark Yao
next prev parent reply other threads:[~2015-11-19 7:08 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 3:35 [PATCH v3 00/12] Add mipi dsi support for rk3288 Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 3:35 ` [PATCH v3 01/12] clk: rockchip: add id for mipidsi sclk on rk3288 Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 3:35 ` [PATCH v3 02/12] clk: rockchip: add mipidsi clocks " Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 3:35 ` [PATCH v3 03/12] drm/rockchip: return a true clock rate to adjusted_mode Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 7:08 ` Mark yao [this message]
2015-11-19 7:08 ` Mark yao
2015-11-19 7:08 ` Mark yao
2015-11-19 8:10 ` Chris Zhong
2015-11-19 8:10 ` Chris Zhong
2015-11-19 3:35 ` [PATCH v3 04/12] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format Chris Zhong
2015-11-19 3:35 ` [PATCH v3 05/12] Documentation: dt-bindings: Add bindings for Synopsys DW MIPI DSI DRM bridge driver Chris Zhong
2015-11-19 15:12 ` Rob Herring
2015-11-19 15:12 ` Rob Herring
2015-11-19 3:35 ` [PATCH v3 06/12] drm/bridge: Add Synopsys DesignWare MIPI DSI host controller driver Chris Zhong
2015-11-19 4:25 ` kbuild test robot
2015-11-19 4:25 ` kbuild test robot
2015-11-19 4:33 ` kbuild test robot
2015-11-19 4:33 ` kbuild test robot
2015-11-19 5:29 ` kbuild test robot
2015-11-19 5:29 ` kbuild test robot
2015-11-19 3:35 ` [PATCH v3 07/12] drm: rockchip: Support Synopsys DesignWare MIPI DSI host controller Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 3:35 ` [PATCH v3 08/12] Documentation: dt-bindings: Add bindings for rk3288 DW MIPI DSI driver Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 17:19 ` Rob Herring
2015-11-19 17:19 ` Rob Herring
2015-11-19 17:19 ` Rob Herring
2015-11-19 3:35 ` [PATCH v3 09/12] ARM: dts: rockchip: add rk3288 mipi_dsi nodes Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 3:35 ` [PATCH v3 10/12] drm/panel: simple: Add support for BOE TV080WUM-NL0 Chris Zhong
2015-11-19 14:46 ` Emil Velikov
2015-11-19 14:46 ` Emil Velikov
2015-11-19 3:35 ` [PATCH v3 11/12] drm/panel: simple: Add boe,tv080wum-nl0 simple panel device tree binding Chris Zhong
2015-11-19 17:19 ` Rob Herring
2015-11-19 17:19 ` Rob Herring
2015-11-19 3:35 ` [PATCH v3 12/12] ARM: dts: rockchip: add support mipi panel tv080wum-nl0 for rk3288-evb Chris Zhong
2015-11-19 3:35 ` Chris Zhong
2015-11-19 14:41 ` [PATCH v3 00/12] Add mipi dsi support for rk3288 Emil Velikov
2015-11-19 14:41 ` Emil Velikov
2015-11-19 14:41 ` Emil Velikov
2015-11-19 14:41 ` Emil Velikov
2015-11-20 7:02 ` Chris Zhong
2015-11-20 7:02 ` Chris Zhong
2015-11-20 7:02 ` Chris Zhong
2015-11-20 12:19 ` Emil Velikov
2015-11-20 12:19 ` Emil Velikov
2015-11-20 12:19 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564D756D.9050000@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.