From: Kishon Vijay Abraham I <kishon@ti.com>
To: Caesar Wang <wxt@rock-chips.com>
Cc: Brian Norris <briannorris@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
<linux-rockchip@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Heiko Stuebner <heiko@sntech.de>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs
Date: Fri, 16 Feb 2018 17:33:48 +0530 [thread overview]
Message-ID: <56548710-6b9a-85bc-85de-221ae748d83c@ti.com> (raw)
In-Reply-To: <1515638427-15117-1-git-send-email-wxt@rock-chips.com>
On Thursday 11 January 2018 08:10 AM, Caesar Wang wrote:
> Hi Kishon,
>
> Since the Shawn isn't available, I take over this series patches for now.
>
> As the original bug had tracked on https://issuetracker.google.com/71561742.
> In some cases, the mmc phy power on failed during booting up.
> The log as below:
> ...
> [ 2.375333] rockchip_emmc_phy_power: caldone timeout.
> [ 2.377815] phy phy-ff770000.syscon:phy@f780.4: phy poweron failed --> -110
> ...
> [ 2.489295] mmc0: mmc_select_hs400es failed, error -110
> [ 2.489302] mmc0: error -110 whilst initialising MMC card
> ..
>
> The actual emulate, the wait 5us for calpad busy trimming, that's no enough.
> We need give the enough margin for it.
>
> Verified on url =
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4
> This series patches can apply and bring up with kernel-next on rk3399 chromebook.
merged now, thanks!
-Kishon
>
> -Caesar
>
>
> Changes in v3:
> - As Doug commented on both upstream and gerrit.
> Change "5, 50" to "0, 50", and the message of print.
> - As Doug commented on https://patchwork.kernel.org/patch/10154797,
> Change "1, 50" to "0, 50".
>
> Changes in v2:
> - print the return valut with regmap_read_poll_timeout failing.
> - As Brian commented on https://patchwork.kernel.org/patch/10139891/,
> changed the note and added to print error value with
> regmap_read_poll_timeout API.
>
> Shawn Lin (2):
> phy: rockchip-emmc: retry calpad busy trimming
> phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy
>
> drivers/phy/rockchip/phy-rockchip-emmc.c | 60 +++++++++++++++-----------------
> 1 file changed, 28 insertions(+), 32 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Caesar Wang <wxt@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Brian Norris <briannorris@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs
Date: Fri, 16 Feb 2018 17:33:48 +0530 [thread overview]
Message-ID: <56548710-6b9a-85bc-85de-221ae748d83c@ti.com> (raw)
In-Reply-To: <1515638427-15117-1-git-send-email-wxt@rock-chips.com>
On Thursday 11 January 2018 08:10 AM, Caesar Wang wrote:
> Hi Kishon,
>
> Since the Shawn isn't available, I take over this series patches for now.
>
> As the original bug had tracked on https://issuetracker.google.com/71561742.
> In some cases, the mmc phy power on failed during booting up.
> The log as below:
> ...
> [ 2.375333] rockchip_emmc_phy_power: caldone timeout.
> [ 2.377815] phy phy-ff770000.syscon:phy@f780.4: phy poweron failed --> -110
> ...
> [ 2.489295] mmc0: mmc_select_hs400es failed, error -110
> [ 2.489302] mmc0: error -110 whilst initialising MMC card
> ..
>
> The actual emulate, the wait 5us for calpad busy trimming, that's no enough.
> We need give the enough margin for it.
>
> Verified on url =
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4
> This series patches can apply and bring up with kernel-next on rk3399 chromebook.
merged now, thanks!
-Kishon
>
> -Caesar
>
>
> Changes in v3:
> - As Doug commented on both upstream and gerrit.
> Change "5, 50" to "0, 50", and the message of print.
> - As Doug commented on https://patchwork.kernel.org/patch/10154797,
> Change "1, 50" to "0, 50".
>
> Changes in v2:
> - print the return valut with regmap_read_poll_timeout failing.
> - As Brian commented on https://patchwork.kernel.org/patch/10139891/,
> changed the note and added to print error value with
> regmap_read_poll_timeout API.
>
> Shawn Lin (2):
> phy: rockchip-emmc: retry calpad busy trimming
> phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy
>
> drivers/phy/rockchip/phy-rockchip-emmc.c | 60 +++++++++++++++-----------------
> 1 file changed, 28 insertions(+), 32 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs
Date: Fri, 16 Feb 2018 17:33:48 +0530 [thread overview]
Message-ID: <56548710-6b9a-85bc-85de-221ae748d83c@ti.com> (raw)
In-Reply-To: <1515638427-15117-1-git-send-email-wxt@rock-chips.com>
On Thursday 11 January 2018 08:10 AM, Caesar Wang wrote:
> Hi Kishon,
>
> Since the Shawn isn't available, I take over this series patches for now.
>
> As the original bug had tracked on https://issuetracker.google.com/71561742.
> In some cases, the mmc phy power on failed during booting up.
> The log as below:
> ...
> [ 2.375333] rockchip_emmc_phy_power: caldone timeout.
> [ 2.377815] phy phy-ff770000.syscon:phy at f780.4: phy poweron failed --> -110
> ...
> [ 2.489295] mmc0: mmc_select_hs400es failed, error -110
> [ 2.489302] mmc0: error -110 whilst initialising MMC card
> ..
>
> The actual emulate, the wait 5us for calpad busy trimming, that's no enough.
> We need give the enough margin for it.
>
> Verified on url =
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.4
> This series patches can apply and bring up with kernel-next on rk3399 chromebook.
merged now, thanks!
-Kishon
>
> -Caesar
>
>
> Changes in v3:
> - As Doug commented on both upstream and gerrit.
> Change "5, 50" to "0, 50", and the message of print.
> - As Doug commented on https://patchwork.kernel.org/patch/10154797,
> Change "1, 50" to "0, 50".
>
> Changes in v2:
> - print the return valut with regmap_read_poll_timeout failing.
> - As Brian commented on https://patchwork.kernel.org/patch/10139891/,
> changed the note and added to print error value with
> regmap_read_poll_timeout API.
>
> Shawn Lin (2):
> phy: rockchip-emmc: retry calpad busy trimming
> phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy
>
> drivers/phy/rockchip/phy-rockchip-emmc.c | 60 +++++++++++++++-----------------
> 1 file changed, 28 insertions(+), 32 deletions(-)
>
next prev parent reply other threads:[~2018-02-16 12:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 2:40 [PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs Caesar Wang
2018-01-11 2:40 ` Caesar Wang
2018-01-11 2:40 ` [PATCH v3 1/2] phy: rockchip-emmc: retry calpad busy trimming Caesar Wang
2018-01-11 2:40 ` Caesar Wang
2018-01-11 3:22 ` Doug Anderson
2018-01-11 3:22 ` Doug Anderson
2018-01-11 2:40 ` [PATCH v3 2/2] phy: rockchip-emmc: use regmap_read_poll_timeout to poll dllrdy Caesar Wang
2018-01-11 2:40 ` Caesar Wang
2018-01-11 3:22 ` Doug Anderson
2018-01-11 3:22 ` Doug Anderson
2018-02-07 1:17 ` [PATCH v3 0/2] phy: rockchip-emmc: fixes emmc-phy power on failed with rk3399 SoCs Caesar Wang
2018-02-07 1:17 ` Caesar Wang
2018-02-07 5:31 ` Kishon Vijay Abraham I
2018-02-07 5:31 ` Kishon Vijay Abraham I
2018-02-07 5:31 ` Kishon Vijay Abraham I
2018-02-16 12:03 ` Kishon Vijay Abraham I [this message]
2018-02-16 12:03 ` Kishon Vijay Abraham I
2018-02-16 12:03 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56548710-6b9a-85bc-85de-221ae748d83c@ti.com \
--to=kishon@ti.com \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.