From: "Matias Bjørling" <m@bjorling.me>
To: Wenwei Tao <ww.tao0320@gmail.com>
Cc: keith.busch@intel.com, axboe@fb.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 1/3] lightnvm: missing nvm_lock acquire
Date: Fri, 27 Nov 2015 20:41:29 +0100 [thread overview]
Message-ID: <5658B1E9.2010700@bjorling.me> (raw)
In-Reply-To: <CACygaLAW23EbxN2Sw33K3Zzyq1P=mM4ouUq6SSxV=_2A0HJJjg@mail.gmail.com>
On 11/27/2015 01:04 PM, Wenwei Tao wrote:
> Hi Matias
> Previous version patch miss acquire lock before find supported manager
> in nvm_init().
> And find supported manager code is duplicated in nvm_init() and
> nvm_create_target(), we may move it into a function to make the code
> more clean.
> And find supported manager may blocked while holding the lock, this is
> not good.
>
Ok, thanks. I'll pick this one up instead then.
WARNING: multiple messages have this Message-ID (diff)
From: m@bjorling.me (Matias Bjørling)
Subject: [PATCH v2 1/3] lightnvm: missing nvm_lock acquire
Date: Fri, 27 Nov 2015 20:41:29 +0100 [thread overview]
Message-ID: <5658B1E9.2010700@bjorling.me> (raw)
In-Reply-To: <CACygaLAW23EbxN2Sw33K3Zzyq1P=mM4ouUq6SSxV=_2A0HJJjg@mail.gmail.com>
On 11/27/2015 01:04 PM, Wenwei Tao wrote:
> Hi Matias
> Previous version patch miss acquire lock before find supported manager
> in nvm_init().
> And find supported manager code is duplicated in nvm_init() and
> nvm_create_target(), we may move it into a function to make the code
> more clean.
> And find supported manager may blocked while holding the lock, this is
> not good.
>
Ok, thanks. I'll pick this one up instead then.
next prev parent reply other threads:[~2015-11-27 19:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 4:09 [PATCH v2 0/3] fixes for LightNVM Wenwei Tao
2015-11-27 4:09 ` Wenwei Tao
2015-11-27 4:09 ` [PATCH v2 1/3] lightnvm: missing nvm_lock acquire Wenwei Tao
2015-11-27 4:09 ` Wenwei Tao
2015-11-27 8:31 ` Matias Bjørling
2015-11-27 8:31 ` Matias Bjørling
2015-11-27 12:04 ` Wenwei Tao
2015-11-27 12:04 ` Wenwei Tao
2015-11-27 19:41 ` Matias Bjørling [this message]
2015-11-27 19:41 ` Matias Bjørling
2015-11-28 1:44 ` Wenwei Tao
2015-11-28 1:44 ` Wenwei Tao
2015-11-27 4:09 ` [PATCH v2 2/3] lightnvm: handle targets when corresponding nvm device exit Wenwei Tao
2015-11-27 4:09 ` Wenwei Tao
2015-11-27 4:09 ` [PATCH v2 3/3] nvme: change the interface between nvme and lightnvm Wenwei Tao
2015-11-27 4:09 ` Wenwei Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5658B1E9.2010700@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ww.tao0320@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.