From: Krzysztof Kozlowski <k.kozlowski@samsung.com> To: "Mutharaju, Prasanna (P.)" <mkarthi3@visteon.com>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: k.kozlowski.k@gmail.com, Kukjin Kim <kgene@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org> Subject: Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent Date: Mon, 30 Nov 2015 18:55:49 +0900 [thread overview] Message-ID: <565C1D25.602@samsung.com> (raw) In-Reply-To: <20151130095109.GA28767@jci-VirtualBox> W dniu 30.11.2015 o 18:52, Mutharaju, Prasanna (P.) pisze: > Remove unneeded variable used to store return value. > > Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com> Previous issues fixed, thanks! But now you changed the From field and it does not match exactly the Signed-off-by (email matches but name does not). Please fix this - signed-off-by should be the same as "From" (in previous versions it was ok...). Best regards, Krzysztof > > --- > v3: Modified subject and changelog comments > --- > --- > drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c > index e9eb935..ec6fb14 100644 > --- a/drivers/clk/samsung/clk-s3c2410-dclk.c > +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c > @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw) > static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index) > { > struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw); > - int ret = 0; > > s3c2410_modify_misccr((clkout->mask << clkout->shift), > (index << clkout->shift)); > > - return ret; > + return 0; > } > > static const struct clk_ops s3c24xx_clkout_ops = { >
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent Date: Mon, 30 Nov 2015 18:55:49 +0900 [thread overview] Message-ID: <565C1D25.602@samsung.com> (raw) In-Reply-To: <20151130095109.GA28767@jci-VirtualBox> W dniu 30.11.2015 o 18:52, Mutharaju, Prasanna (P.) pisze: > Remove unneeded variable used to store return value. > > Signed-off-by: Prasanna Karthik <mkarthi3@visteon.com> Previous issues fixed, thanks! But now you changed the From field and it does not match exactly the Signed-off-by (email matches but name does not). Please fix this - signed-off-by should be the same as "From" (in previous versions it was ok...). Best regards, Krzysztof > > --- > v3: Modified subject and changelog comments > --- > --- > drivers/clk/samsung/clk-s3c2410-dclk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-s3c2410-dclk.c b/drivers/clk/samsung/clk-s3c2410-dclk.c > index e9eb935..ec6fb14 100644 > --- a/drivers/clk/samsung/clk-s3c2410-dclk.c > +++ b/drivers/clk/samsung/clk-s3c2410-dclk.c > @@ -77,12 +77,11 @@ static u8 s3c24xx_clkout_get_parent(struct clk_hw *hw) > static int s3c24xx_clkout_set_parent(struct clk_hw *hw, u8 index) > { > struct s3c24xx_clkout *clkout = to_s3c24xx_clkout(hw); > - int ret = 0; > > s3c2410_modify_misccr((clkout->mask << clkout->shift), > (index << clkout->shift)); > > - return ret; > + return 0; > } > > static const struct clk_ops s3c24xx_clkout_ops = { >
next prev parent reply other threads:[~2015-11-30 9:55 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-30 9:52 [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent Mutharaju, Prasanna (P.) 2015-11-30 9:52 ` Mutharaju, Prasanna (P.) 2015-11-30 9:52 ` Mutharaju, Prasanna (P.) 2015-11-30 9:55 ` Krzysztof Kozlowski [this message] 2015-11-30 9:55 ` Krzysztof Kozlowski -- strict thread matches above, loose matches on Subject: below -- 2015-11-30 10:08 Mutharaju, Prasanna (P.) 2015-11-30 10:08 ` Mutharaju, Prasanna (P.) 2015-11-30 10:08 ` Mutharaju, Prasanna (P.) 2015-11-30 10:18 ` Krzysztof Kozlowski 2015-11-30 10:18 ` Krzysztof Kozlowski 2015-12-16 18:03 ` Sylwester Nawrocki 2015-12-16 18:03 ` Sylwester Nawrocki 2015-11-30 7:52 Mutharaju, Prasanna (P.) 2015-11-30 7:52 ` Mutharaju, Prasanna (P.) 2015-11-30 7:52 ` Mutharaju, Prasanna (P.) 2015-11-30 8:03 ` Krzysztof Kozlowski 2015-11-30 8:03 ` Krzysztof Kozlowski 2015-11-30 8:15 ` Uwe Kleine-König 2015-11-30 8:15 ` Uwe Kleine-König 2015-11-30 9:55 ` Mutharaju, Prasanna (P.) 2015-11-30 9:55 ` Mutharaju, Prasanna (P.) 2015-11-30 9:55 ` Mutharaju, Prasanna (P.)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=565C1D25.602@samsung.com \ --to=k.kozlowski@samsung.com \ --cc=k.kozlowski.k@gmail.com \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mkarthi3@visteon.com \ --cc=mturquette@baylibre.com \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@codeaurora.org \ --cc=tomasz.figa@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.