From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Geert Uytterhoeven <geert@linux-m68k.org>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Damien Zammit <damien@zamaudio.com>,
Robin Gareus <robin@gareus.org>
Subject: Re: [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt()
Date: Mon, 8 Feb 2016 20:22:00 +0900 [thread overview]
Message-ID: <56B87A58.6090304@sakamocchi.jp> (raw)
In-Reply-To: <1454854455-20894-1-git-send-email-geert@linux-m68k.org>
On Feb 7 2016 23:14, Geert Uytterhoeven wrote:
> sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type
>
> Drop the bogus "const" type qualifier on the return type of dot_scrt()
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Yep. It came from original code[1] and I overlooked.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> sound/firewire/digi00x/amdtp-dot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c
> index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644
> --- a/sound/firewire/digi00x/amdtp-dot.c
> +++ b/sound/firewire/digi00x/amdtp-dot.c
> @@ -63,7 +63,7 @@ struct amdtp_dot {
> #define BYTE_PER_SAMPLE (4)
> #define MAGIC_DOT_BYTE (2)
> #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE)
> -static const u8 dot_scrt(const u8 idx, const unsigned int off)
> +static u8 dot_scrt(const u8 idx, const unsigned int off)
> {
> /*
> * the length of the added pattern only depends on the lower nibble
Thanks
[1] https://github.com/x42/003amdtp
Takashi Sakamoto
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Geert Uytterhoeven <geert@linux-m68k.org>, Takashi Iwai <tiwai@suse.com>
Cc: Damien Zammit <damien@zamaudio.com>,
alsa-devel@alsa-project.org, Robin Gareus <robin@gareus.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt()
Date: Mon, 8 Feb 2016 20:22:00 +0900 [thread overview]
Message-ID: <56B87A58.6090304@sakamocchi.jp> (raw)
In-Reply-To: <1454854455-20894-1-git-send-email-geert@linux-m68k.org>
On Feb 7 2016 23:14, Geert Uytterhoeven wrote:
> sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type
>
> Drop the bogus "const" type qualifier on the return type of dot_scrt()
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Yep. It came from original code[1] and I overlooked.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> sound/firewire/digi00x/amdtp-dot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c
> index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644
> --- a/sound/firewire/digi00x/amdtp-dot.c
> +++ b/sound/firewire/digi00x/amdtp-dot.c
> @@ -63,7 +63,7 @@ struct amdtp_dot {
> #define BYTE_PER_SAMPLE (4)
> #define MAGIC_DOT_BYTE (2)
> #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE)
> -static const u8 dot_scrt(const u8 idx, const unsigned int off)
> +static u8 dot_scrt(const u8 idx, const unsigned int off)
> {
> /*
> * the length of the added pattern only depends on the lower nibble
Thanks
[1] https://github.com/x42/003amdtp
Takashi Sakamoto
next prev parent reply other threads:[~2016-02-08 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 14:14 [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt() Geert Uytterhoeven
2016-02-07 14:14 ` Geert Uytterhoeven
2016-02-08 11:22 ` Takashi Sakamoto [this message]
2016-02-08 11:22 ` Takashi Sakamoto
2016-02-09 11:17 ` Takashi Iwai
2016-02-09 11:17 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B87A58.6090304@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=damien@zamaudio.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin@gareus.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.