From: Harry Wentland <harry.wentland@amd.com>
To: Rob Clark <robdclark@gmail.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Cheng, Tony" <Tony.Cheng@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 08/29] drm/amd/dal: I2C Aux Manager
Date: Tue, 16 Feb 2016 22:23:45 -0500 [thread overview]
Message-ID: <56C3E7C1.2000700@amd.com> (raw)
In-Reply-To: <CAF6AEGvhc48p-Vf08g9TwE8wbTX6QgKbq4r6TPZkMPk_zbDA=A@mail.gmail.com>
Hi Rob,
that's a good point. We'll see if we can use DRM and existing amdgpu
code for i2c/aux and rip this one out.
Cheers,
Harry
On 2016-02-11 03:19 PM, Rob Clark wrote:
> On Thu, Feb 11, 2016 at 12:19 PM, Harry Wentland <harry.wentland@amd.com> wrote:
>> Implements low-level communication layer over I2C and Aux lines using
>> GPIO handles.
> so without actually looking too closely at this rather large patch (in
> a rather huge patchset).. I do wonder, why not i2c_adapter? Kernel
> already has an implementation of that on top of gpio's..
>
> BR,
> -R
>
>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>> ---
>> drivers/gpu/drm/amd/dal/dc/i2caux/Makefile | 33 +
>> drivers/gpu/drm/amd/dal/dc/i2caux/aux_engine.c | 567 ++++++++++++
>> drivers/gpu/drm/amd/dal/dc/i2caux/aux_engine.h | 119 +++
>> .../amd/dal/dc/i2caux/dce110/aux_engine_dce110.c | 788 +++++++++++++++++
>> .../amd/dal/dc/i2caux/dce110/aux_engine_dce110.h | 56 ++
>> .../i2caux/dce110/i2c_generic_hw_engine_dce110.h | 25 +
>> .../dal/dc/i2caux/dce110/i2c_hw_engine_dce110.c | 954 +++++++++++++++++++++
>> .../dal/dc/i2caux/dce110/i2c_hw_engine_dce110.h | 58 ++
>> .../dal/dc/i2caux/dce110/i2c_sw_engine_dce110.c | 172 ++++
>> .../dal/dc/i2caux/dce110/i2c_sw_engine_dce110.h | 43 +
>> .../drm/amd/dal/dc/i2caux/dce110/i2caux_dce110.c | 266 ++++++
>> .../drm/amd/dal/dc/i2caux/dce110/i2caux_dce110.h | 39 +
>> .../amd/dal/dc/i2caux/diagnostics/i2caux_diag.c | 112 +++
>> .../amd/dal/dc/i2caux/diagnostics/i2caux_diag.h | 33 +
>> drivers/gpu/drm/amd/dal/dc/i2caux/engine.h | 129 +++
>> drivers/gpu/drm/amd/dal/dc/i2caux/engine_base.c | 67 ++
>> drivers/gpu/drm/amd/dal/dc/i2caux/i2c_engine.c | 121 +++
>> drivers/gpu/drm/amd/dal/dc/i2caux/i2c_engine.h | 113 +++
>> .../drm/amd/dal/dc/i2caux/i2c_generic_hw_engine.c | 286 ++++++
>> .../drm/amd/dal/dc/i2caux/i2c_generic_hw_engine.h | 77 ++
>> drivers/gpu/drm/amd/dal/dc/i2caux/i2c_hw_engine.c | 246 ++++++
>> drivers/gpu/drm/amd/dal/dc/i2caux/i2c_hw_engine.h | 80 ++
>> drivers/gpu/drm/amd/dal/dc/i2caux/i2c_sw_engine.c | 614 +++++++++++++
>> drivers/gpu/drm/amd/dal/dc/i2caux/i2c_sw_engine.h | 81 ++
>> drivers/gpu/drm/amd/dal/dc/i2caux/i2caux.c | 529 ++++++++++++
>> drivers/gpu/drm/amd/dal/dc/i2caux/i2caux.h | 123 +++
>> 26 files changed, 5731 insertions(+)
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/Makefile
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/aux_engine.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/aux_engine.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/aux_engine_dce110.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/aux_engine_dce110.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/i2c_generic_hw_engine_dce110.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/i2c_hw_engine_dce110.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/i2c_hw_engine_dce110.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/i2c_sw_engine_dce110.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/i2c_sw_engine_dce110.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/i2caux_dce110.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/dce110/i2caux_dce110.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/diagnostics/i2caux_diag.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/diagnostics/i2caux_diag.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/engine.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/engine_base.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2c_engine.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2c_engine.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2c_generic_hw_engine.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2c_generic_hw_engine.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2c_hw_engine.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2c_hw_engine.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2c_sw_engine.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2c_sw_engine.h
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2caux.c
>> create mode 100644 drivers/gpu/drm/amd/dal/dc/i2caux/i2caux.h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-02-17 3:24 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 17:19 [PATCH 00/29] Enabling new DAL display driver for amdgpu on Carrizo and Tonga Harry Wentland
2016-02-11 17:19 ` [PATCH 01/29] drm/amd/dal: Add dal headers Harry Wentland
2016-02-11 17:19 ` [PATCH 02/29] drm/amd/dal: Add DAL Basic Types and Logger Harry Wentland
2016-02-11 17:19 ` [PATCH 03/29] drm/amd/dal: Fixed point arithmetic Harry Wentland
2016-02-11 17:19 ` [PATCH 04/29] drm/amd/dal: Asic Capabilities Harry Wentland
2016-02-11 17:19 ` [PATCH 05/29] drm/amd/dal: GPIO (General Purpose IO) Harry Wentland
2016-02-11 17:19 ` [PATCH 06/29] drm/amd/dal: Adapter Service Harry Wentland
2016-02-12 0:26 ` Dave Airlie
2016-02-12 14:30 ` Wentland, Harry
2016-02-11 17:19 ` [PATCH 07/29] drm/amd/dal: BIOS Parser Harry Wentland
2016-02-11 17:19 ` [PATCH 08/29] drm/amd/dal: I2C Aux Manager Harry Wentland
2016-02-11 20:19 ` Rob Clark
2016-02-11 20:52 ` Daniel Vetter
2016-02-17 3:23 ` Harry Wentland [this message]
2016-02-11 17:19 ` [PATCH 09/29] drm/amd/dal: IRQ Service Harry Wentland
2016-02-11 17:19 ` [PATCH 10/29] drm/amd/dal: GPU Harry Wentland
2016-02-11 17:19 ` [PATCH 11/29] drm/amd/dal: Audio Harry Wentland
2016-02-11 17:19 ` [PATCH 12/29] drm/amd/dal: Bandwidth calculations Harry Wentland
2016-02-11 17:19 ` [PATCH 13/29] drm/amd/dal: Add encoder HW programming Harry Wentland
2016-02-11 17:19 ` [PATCH 14/29] drm/amd/dal: Add clock source " Harry Wentland
2016-02-11 17:19 ` [PATCH 15/29] drm/amd/dal: Add timing generator " Harry Wentland
2016-02-11 17:19 ` [PATCH 16/29] drm/amd/dal: Add surface " Harry Wentland
2016-02-11 17:19 ` [PATCH 17/29] drm/amd/dal: Add framebuffer compression " Harry Wentland
2016-02-11 17:19 ` [PATCH 18/29] drm/amd/dal: Add input pixel processing " Harry Wentland
2016-02-11 17:19 ` [PATCH 19/29] drm/amd/dal: Add output " Harry Wentland
2016-02-11 17:20 ` [PATCH 20/29] drm/amd/dal: Add transform & scaler " Harry Wentland
2016-02-11 17:20 ` [PATCH 21/29] drm/amd/dal: Add Carrizo HW sequencer and resource Harry Wentland
2016-02-11 17:20 ` [PATCH 22/29] drm/amd/dal: Add Tonga/Fiji " Harry Wentland
2016-02-11 17:20 ` [PATCH 23/29] drm/amd/dal: Add empty encoder programming for virtual HW Harry Wentland
2016-02-11 17:20 ` [PATCH 24/29] drm/amd/dal: Add display core Harry Wentland
2016-02-11 17:20 ` [PATCH 25/29] drm/amd/dal: Adding amdgpu_dm for dal Harry Wentland
2016-02-11 17:20 ` [PATCH 26/29] drm/amdgpu: Use dal driver for Carrizo, Tonga, and Fiji Harry Wentland
2016-02-11 17:20 ` [PATCH 27/29] drm/amd/dal: Correctly interpret rotation as bit set Harry Wentland
2016-02-11 21:00 ` Oded Gabbay
2016-02-16 16:46 ` Harry Wentland
2016-02-11 17:20 ` [PATCH 28/29] drm/amd/dal: fix flip clean-up state Harry Wentland
2016-02-11 17:20 ` [PATCH 29/29] drm/amd/dal: Force bw programming for DCE 10 until we start calculate BW Harry Wentland
2016-02-11 20:02 ` [PATCH 00/29] Enabling new DAL display driver for amdgpu on Carrizo and Tonga Mike Lothian
2016-02-11 20:05 ` Wentland, Harry
2016-02-11 20:52 ` Dave Airlie
2016-02-11 21:06 ` Daniel Vetter
2016-02-12 0:57 ` Dave Airlie
2016-02-12 5:34 ` Daniel Vetter
2016-02-13 0:05 ` Wentland, Harry
2016-02-14 11:22 ` Jerome Glisse
2016-02-14 13:23 ` Daniel Vetter
2016-02-17 3:28 ` Harry Wentland
2016-02-14 13:32 ` Rob Clark
2016-02-14 13:51 ` Daniel Vetter
2016-02-17 3:26 ` Harry Wentland
2016-02-14 14:01 ` Daniel Vetter
2016-02-17 3:32 ` Harry Wentland
2016-02-14 21:44 ` Daniel Stone
2016-02-16 22:27 ` [PATCH v2 00/26] " Harry Wentland
2016-02-16 22:27 ` [PATCH v2 01/26] drm/amd/dal: Add dal headers Harry Wentland
2016-02-16 22:27 ` [PATCH v2 02/26] drm/amd/dal: Add DAL Basic Types and Logger Harry Wentland
2016-02-16 22:27 ` [PATCH v2 03/26] drm/amd/dal: Fixed point arithmetic Harry Wentland
2016-02-16 22:27 ` [PATCH v2 04/26] drm/amd/dal: Asic Capabilities Harry Wentland
2016-02-16 22:27 ` [PATCH v2 05/26] drm/amd/dal: GPIO (General Purpose IO) Harry Wentland
2016-02-16 22:27 ` [PATCH v2 06/26] drm/amd/dal: Adapter Service Harry Wentland
2016-02-16 22:27 ` [PATCH v2 07/26] drm/amd/dal: BIOS Parser Harry Wentland
2016-02-16 22:27 ` [PATCH v2 08/26] drm/amd/dal: I2C Aux Manager Harry Wentland
2016-02-16 22:27 ` [PATCH v2 09/26] drm/amd/dal: IRQ Service Harry Wentland
2016-02-16 22:27 ` [PATCH v2 10/26] drm/amd/dal: GPU Harry Wentland
2016-02-16 22:27 ` [PATCH v2 11/26] drm/amd/dal: Audio Harry Wentland
2016-02-16 22:27 ` [PATCH v2 12/26] drm/amd/dal: Bandwidth calculations Harry Wentland
2016-02-16 22:27 ` [PATCH v2 13/26] drm/amd/dal: Add encoder HW programming Harry Wentland
2016-02-16 22:27 ` [PATCH v2 14/26] drm/amd/dal: Add clock source " Harry Wentland
2016-02-16 22:27 ` [PATCH v2 15/26] drm/amd/dal: Add timing generator " Harry Wentland
2016-02-16 22:27 ` [PATCH v2 16/26] drm/amd/dal: Add surface " Harry Wentland
2016-02-16 22:27 ` [PATCH v2 17/26] drm/amd/dal: Add framebuffer compression " Harry Wentland
2016-02-16 22:27 ` [PATCH v2 18/26] drm/amd/dal: Add input pixel processing " Harry Wentland
2016-02-16 22:27 ` [PATCH v2 19/26] drm/amd/dal: Add output " Harry Wentland
2016-02-16 22:28 ` [PATCH v2 20/26] drm/amd/dal: Add transform & scaler " Harry Wentland
2016-02-16 22:28 ` [PATCH v2 21/26] drm/amd/dal: Add Carrizo HW sequencer and resource Harry Wentland
2016-02-16 22:28 ` [PATCH v2 22/26] drm/amd/dal: Add Tonga/Fiji " Harry Wentland
2016-02-16 22:28 ` [PATCH v2 23/26] drm/amd/dal: Add empty encoder programming for virtual HW Harry Wentland
2016-02-16 22:28 ` [PATCH v2 24/26] drm/amd/dal: Add display core Harry Wentland
2016-02-16 22:28 ` [PATCH v2 25/26] drm/amd/dal: Adding amdgpu_dm for dal Harry Wentland
2016-02-16 22:28 ` [PATCH v2 26/26] drm/amdgpu: Use dal driver for Carrizo, Tonga, and Fiji Harry Wentland
2016-02-29 21:56 ` [PATCH v3 00/26] Enabling new DAL display driver for amdgpu on Carrizo and Tonga Harry Wentland
2016-02-29 21:56 ` [PATCH v3 01/26] drm/amd/dal: Add dal headers Harry Wentland
2016-02-29 21:56 ` [PATCH v3 05/26] drm/amd/dal: GPIO (General Purpose IO) Harry Wentland
2016-02-29 21:56 ` [PATCH v3 07/26] drm/amd/dal: BIOS Parser Harry Wentland
2016-02-29 21:56 ` [PATCH v3 24/26] drm/amd/dal: Add display core Harry Wentland
2016-02-29 21:56 ` [PATCH v3 25/26] drm/amd/dal: Adding amdgpu_dm for dal Harry Wentland
2016-02-29 21:56 ` [PATCH v3 26/26] drm/amdgpu: Use dal driver for Carrizo, Tonga, and Fiji Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C3E7C1.2000700@amd.com \
--to=harry.wentland@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Tony.Cheng@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.