From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Anand Moon <linux.amoon@gmail.com>, Kukjin Kim <kgene@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: add support for gpio buttons for exynos5422-odroidxu3
Date: Tue, 23 Feb 2016 17:33:19 +0900 [thread overview]
Message-ID: <56CC194F.6080905@samsung.com> (raw)
In-Reply-To: <56CC167A.8040303@samsung.com>
On 23.02.2016 17:21, Krzysztof Kozlowski wrote:
> On 23.02.2016 17:01, Anand Moon wrote:
>> Add support for gpio-based button on Odroid-XU3 boards
>> for reboot/poweroff feature.
>>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>> changes rebase based on linux next-20160222.
>>
>> Tested on Odroid-XU4
>>
>> dmesg output.
>> [ 3.286068] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/power_key[0]' - status (0)
>> [ 3.286206] gpio-11 (power key): gpiod_set_debounce: missing set() or set_debounce() operations
>> [ 3.286600] input: gpio_keys as /devices/platform/gpio_keys/input/input0
>> ---
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 1bd507b..db9770b 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -11,6 +11,7 @@
>> */
>>
>> #include <dt-bindings/clock/samsung,s2mps11.h>
>> +#include <dt-bindings/input/input.h>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/sound/samsung-i2s.h>
>> @@ -54,6 +55,22 @@
>> #cooling-cells = <2>;
>> cooling-levels = <0 130 170 230>;
>> };
>> +
>> + gpio_keys {
>> + compatible = "gpio-keys";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&gpio_power_key>;
>> +
>> + power_key {
>> + interrupt-parent = <&gpx0>;
>> + interrupts = <3 IRQ_TYPE_NONE>;
>
> Hmmm.... why you specify the interrupts?
>
>> + gpios = <&gpx0 3 GPIO_ACTIVE_LOW>;
Please, explain it to me. The SW2 key is connected to PWRON of PMIC.
However you are adding a GPIO key for external interrupt source 3
(XE.INT3)... which comes from PMIC's ONOB.
It's interesting.... how does it work? The PMIC will generate ONOB
interrupt on PWRON low->high change (when PWRHOLD is high)?
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: add support for gpio buttons for exynos5422-odroidxu3
Date: Tue, 23 Feb 2016 17:33:19 +0900 [thread overview]
Message-ID: <56CC194F.6080905@samsung.com> (raw)
In-Reply-To: <56CC167A.8040303@samsung.com>
On 23.02.2016 17:21, Krzysztof Kozlowski wrote:
> On 23.02.2016 17:01, Anand Moon wrote:
>> Add support for gpio-based button on Odroid-XU3 boards
>> for reboot/poweroff feature.
>>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>> changes rebase based on linux next-20160222.
>>
>> Tested on Odroid-XU4
>>
>> dmesg output.
>> [ 3.286068] of_get_named_gpiod_flags: parsed 'gpios' property of node '/gpio_keys/power_key[0]' - status (0)
>> [ 3.286206] gpio-11 (power key): gpiod_set_debounce: missing set() or set_debounce() operations
>> [ 3.286600] input: gpio_keys as /devices/platform/gpio_keys/input/input0
>> ---
>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 1bd507b..db9770b 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -11,6 +11,7 @@
>> */
>>
>> #include <dt-bindings/clock/samsung,s2mps11.h>
>> +#include <dt-bindings/input/input.h>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/sound/samsung-i2s.h>
>> @@ -54,6 +55,22 @@
>> #cooling-cells = <2>;
>> cooling-levels = <0 130 170 230>;
>> };
>> +
>> + gpio_keys {
>> + compatible = "gpio-keys";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&gpio_power_key>;
>> +
>> + power_key {
>> + interrupt-parent = <&gpx0>;
>> + interrupts = <3 IRQ_TYPE_NONE>;
>
> Hmmm.... why you specify the interrupts?
>
>> + gpios = <&gpx0 3 GPIO_ACTIVE_LOW>;
Please, explain it to me. The SW2 key is connected to PWRON of PMIC.
However you are adding a GPIO key for external interrupt source 3
(XE.INT3)... which comes from PMIC's ONOB.
It's interesting.... how does it work? The PMIC will generate ONOB
interrupt on PWRON low->high change (when PWRHOLD is high)?
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-02-23 8:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 8:01 [PATCH] ARM: dts: add support for gpio buttons for exynos5422-odroidxu3 Anand Moon
2016-02-23 8:01 ` Anand Moon
2016-02-23 8:21 ` Krzysztof Kozlowski
2016-02-23 8:21 ` Krzysztof Kozlowski
2016-02-23 8:33 ` Krzysztof Kozlowski [this message]
2016-02-23 8:33 ` Krzysztof Kozlowski
2016-02-23 8:47 ` Krzysztof Kozlowski
2016-02-23 8:47 ` Krzysztof Kozlowski
2016-02-23 9:17 ` Anand Moon
2016-02-23 9:17 ` Anand Moon
2016-02-23 9:17 ` Anand Moon
2016-02-23 12:02 ` Krzysztof Kozlowski
2016-02-23 12:02 ` Krzysztof Kozlowski
2016-02-23 12:02 ` Krzysztof Kozlowski
2016-02-23 14:16 ` Anand Moon
2016-02-23 14:16 ` Anand Moon
2016-02-23 14:16 ` Anand Moon
2016-02-24 7:27 ` Krzysztof Kozlowski
2016-02-24 7:27 ` Krzysztof Kozlowski
2016-02-24 7:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC194F.6080905@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.