All of lore.kernel.org
 help / color / mirror / Atom feed
From: "PaX Team" <pageexec@freemail.hu>
To: Emese Revfy <re.emese@gmail.com>, Kees Cook <keescook@chromium.org>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
	Brad Spengler <spender@grsecurity.net>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	Michal Marek <mmarek@suse.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH v4 1/3] GCC plugin infrastructure
Date: Wed, 02 Mar 2016 22:33:20 +0100	[thread overview]
Message-ID: <56D75C20.3969.4578E077@pageexec.freemail.hu> (raw)
In-Reply-To: <CAGXu5j+_3g-DAucJz+CYLZPEUauqfy52FmFDquh4xPOGB3Ek1g@mail.gmail.com>

On 1 Mar 2016 at 14:50, Kees Cook wrote:

> > @@ -124,5 +159,37 @@ quiet_cmd_host-cxxobjs     = HOSTCXX $@
> >  $(host-cxxobjs): $(obj)/%.o: $(src)/%.cc FORCE
> >         $(call if_changed_dep,host-cxxobjs)
> >
> > +# Compile .c file, create position independent .o file
> > +# host-cshobjs -> .o
> > +quiet_cmd_host-cshobjs = HOSTCC  -fPIC $@
> 
> Is there a reason to include the -fPIC and -shared (below) in the
> "quiet" output?

this is how it used to be before the entire .so building infrastructure
was nuked from the upstream kernel some time last year IIRC, i only kept
it alive as it was in PaX. i guess the quiet command was more verbose to
make it easier to spot shared objects during make which at the time were
built as dependencies only, not as primary targets (as is the case now
with the gcc plugins). in any case, this is just a visual clue and i don't
particularly care about the color of this bikeshed :).


WARNING: multiple messages have this Message-ID (diff)
From: "PaX Team" <pageexec@freemail.hu>
To: Emese Revfy <re.emese@gmail.com>, Kees Cook <keescook@chromium.org>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
	Brad Spengler <spender@grsecurity.net>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	Michal Marek <mmarek@suse.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: [kernel-hardening] Re: [PATCH v4 1/3] GCC plugin infrastructure
Date: Wed, 02 Mar 2016 22:33:20 +0100	[thread overview]
Message-ID: <56D75C20.3969.4578E077@pageexec.freemail.hu> (raw)
In-Reply-To: <CAGXu5j+_3g-DAucJz+CYLZPEUauqfy52FmFDquh4xPOGB3Ek1g@mail.gmail.com>

On 1 Mar 2016 at 14:50, Kees Cook wrote:

> > @@ -124,5 +159,37 @@ quiet_cmd_host-cxxobjs     = HOSTCXX $@
> >  $(host-cxxobjs): $(obj)/%.o: $(src)/%.cc FORCE
> >         $(call if_changed_dep,host-cxxobjs)
> >
> > +# Compile .c file, create position independent .o file
> > +# host-cshobjs -> .o
> > +quiet_cmd_host-cshobjs = HOSTCC  -fPIC $@
> 
> Is there a reason to include the -fPIC and -shared (below) in the
> "quiet" output?

this is how it used to be before the entire .so building infrastructure
was nuked from the upstream kernel some time last year IIRC, i only kept
it alive as it was in PaX. i guess the quiet command was more verbose to
make it easier to spot shared objects during make which at the time were
built as dependencies only, not as primary targets (as is the case now
with the gcc plugins). in any case, this is just a visual clue and i don't
particularly care about the color of this bikeshed :).

  reply	other threads:[~2016-03-02 21:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 17:14 [PATCH v4 0/3] Introduce GCC plugin infrastructure Emese Revfy
2016-03-01 17:14 ` [kernel-hardening] " Emese Revfy
2016-03-01 17:15 ` [PATCH v4 1/3] " Emese Revfy
2016-03-01 17:15   ` [kernel-hardening] " Emese Revfy
2016-03-01 19:07   ` Kees Cook
2016-03-01 19:07     ` [kernel-hardening] " Kees Cook
2016-03-02 20:57     ` Emese Revfy
2016-03-02 20:57       ` [kernel-hardening] " Emese Revfy
2016-03-01 21:19   ` Kees Cook
2016-03-01 21:19     ` [kernel-hardening] " Kees Cook
2016-03-01 21:34     ` Kees Cook
2016-03-01 21:34       ` [kernel-hardening] " Kees Cook
2016-03-02 21:18       ` Emese Revfy
2016-03-02 21:18         ` [kernel-hardening] " Emese Revfy
2016-03-01 22:50   ` Kees Cook
2016-03-01 22:50     ` [kernel-hardening] " Kees Cook
2016-03-02 21:33     ` PaX Team [this message]
2016-03-02 21:33       ` PaX Team
2016-03-01 17:16 ` [PATCH v4 2/3] Add Cyclomatic complexity GCC plugin Emese Revfy
2016-03-01 17:16   ` [kernel-hardening] " Emese Revfy
2016-03-01 17:17 ` [PATCH v4 3/3] Documentation for the GCC plugin infrastructure Emese Revfy
2016-03-01 17:17   ` [kernel-hardening] " Emese Revfy
2016-03-01 19:09 ` [PATCH v4 0/3] Introduce " Kees Cook
2016-03-01 19:09   ` [kernel-hardening] " Kees Cook
2016-03-01 19:16   ` Kees Cook
2016-03-01 19:16     ` [kernel-hardening] " Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D75C20.3969.4578E077@pageexec.freemail.hu \
    --to=pageexec@freemail.hu \
    --cc=fengguang.wu@intel.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mmarek@suse.com \
    --cc=re.emese@gmail.com \
    --cc=spender@grsecurity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.