From: Julien Grall <julien.grall@arm.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com,
fu.wei@linaro.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, wei@redhat.com,
al.stone@linaro.org, Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure
Date: Wed, 9 Mar 2016 12:35:23 +0700 [thread overview]
Message-ID: <56DFB61B.4040707@arm.com> (raw)
In-Reply-To: <20160309032343.GE26583@lvm>
Hi Christoffer,
On 09/03/2016 10:23, Christoffer Dall wrote:
> On Tue, Mar 08, 2016 at 11:29:25AM +0000, Julien Grall wrote:
>> -static struct timecounter timecounter;
>> +static struct arch_timer_kvm_info arch_timer_kvm_info;
>> +
>> +struct arch_timer_kvm_info *arch_timer_get_kvm_info(void)
>
> borderline bikeshedding question:
>
> does it make sense that the info the arch timer code exports is labeled
> to be kvm-specific? In other words, could we imagine another subsystem
> using this timer info some time and is there a more generic term that
> would be more appropriate?
I can't see any other usage. I would keep the function name KVM specific
until someone really need similar information.
Cheers,
--
Julien Grall
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Christoffer Dall <christoffer.dall@linaro.org>
Cc: al.stone@linaro.org, kvm@vger.kernel.org, marc.zyngier@arm.com,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org, fu.wei@linaro.org,
Thomas Gleixner <tglx@linutronix.de>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure
Date: Wed, 9 Mar 2016 12:35:23 +0700 [thread overview]
Message-ID: <56DFB61B.4040707@arm.com> (raw)
In-Reply-To: <20160309032343.GE26583@lvm>
Hi Christoffer,
On 09/03/2016 10:23, Christoffer Dall wrote:
> On Tue, Mar 08, 2016 at 11:29:25AM +0000, Julien Grall wrote:
>> -static struct timecounter timecounter;
>> +static struct arch_timer_kvm_info arch_timer_kvm_info;
>> +
>> +struct arch_timer_kvm_info *arch_timer_get_kvm_info(void)
>
> borderline bikeshedding question:
>
> does it make sense that the info the arch timer code exports is labeled
> to be kvm-specific? In other words, could we imagine another subsystem
> using this timer info some time and is there a more generic term that
> would be more appropriate?
I can't see any other usage. I would keep the function name KVM specific
until someone really need similar information.
Cheers,
--
Julien Grall
WARNING: multiple messages have this Message-ID (diff)
From: julien.grall@arm.com (Julien Grall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure
Date: Wed, 9 Mar 2016 12:35:23 +0700 [thread overview]
Message-ID: <56DFB61B.4040707@arm.com> (raw)
In-Reply-To: <20160309032343.GE26583@lvm>
Hi Christoffer,
On 09/03/2016 10:23, Christoffer Dall wrote:
> On Tue, Mar 08, 2016 at 11:29:25AM +0000, Julien Grall wrote:
>> -static struct timecounter timecounter;
>> +static struct arch_timer_kvm_info arch_timer_kvm_info;
>> +
>> +struct arch_timer_kvm_info *arch_timer_get_kvm_info(void)
>
> borderline bikeshedding question:
>
> does it make sense that the info the arch timer code exports is labeled
> to be kvm-specific? In other words, could we imagine another subsystem
> using this timer info some time and is there a more generic term that
> would be more appropriate?
I can't see any other usage. I would keep the function name KVM specific
until someone really need similar information.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2016-03-09 5:35 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 11:29 [PATCH v3 0/9] arm64: Add support of KVM with ACPI Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` [PATCH v3 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 3:23 ` Christoffer Dall
2016-03-09 3:23 ` Christoffer Dall
2016-03-09 3:23 ` Christoffer Dall
2016-03-09 5:35 ` Julien Grall [this message]
2016-03-09 5:35 ` Julien Grall
2016-03-09 5:35 ` Julien Grall
2016-03-08 11:29 ` [PATCH v3 2/9] clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 3:27 ` Christoffer Dall
2016-03-09 3:27 ` Christoffer Dall
2016-03-09 3:27 ` Christoffer Dall
2016-03-09 5:52 ` Julien Grall
2016-03-09 5:52 ` Julien Grall
2016-03-08 11:29 ` [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 5:47 ` Christoffer Dall
2016-03-09 5:47 ` Christoffer Dall
2016-03-09 5:47 ` Christoffer Dall
2016-03-09 6:18 ` Julien Grall
2016-03-09 6:18 ` Julien Grall
2016-03-09 6:18 ` Julien Grall
2016-03-13 18:19 ` Christoffer Dall
2016-03-13 18:19 ` Christoffer Dall
2016-03-13 18:19 ` Christoffer Dall
2016-03-08 11:29 ` [PATCH v3 4/9] irqchip/gic-v2: Parse and export virtual GIC information Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 5:14 ` Christoffer Dall
2016-03-09 5:14 ` Christoffer Dall
2016-03-14 12:19 ` Julien Grall
2016-03-14 12:19 ` Julien Grall
2016-03-08 11:29 ` [PATCH v3 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 5:39 ` Christoffer Dall
2016-03-09 5:39 ` Christoffer Dall
2016-03-09 5:39 ` Christoffer Dall
2016-03-15 12:26 ` Julien Grall
2016-03-15 12:26 ` Julien Grall
2016-03-15 12:26 ` Julien Grall
2016-03-18 9:42 ` Christoffer Dall
2016-03-18 9:42 ` Christoffer Dall
2016-03-08 11:29 ` [PATCH v3 6/9] irqchip/gic-v3: Parse and export virtual GIC information Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 5:53 ` Christoffer Dall
2016-03-09 5:53 ` Christoffer Dall
2016-03-09 5:53 ` Christoffer Dall
2016-03-22 11:27 ` Graeme Gregory
2016-03-22 11:27 ` Graeme Gregory
2016-03-22 12:02 ` Julien Grall
2016-03-22 12:02 ` Julien Grall
2016-03-08 11:29 ` [PATCH v3 7/9] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 5:55 ` Christoffer Dall
2016-03-09 5:55 ` Christoffer Dall
2016-03-08 11:29 ` [PATCH v3 8/9] KVM: arm/arm64: vgic: Rely on the GIC driver " Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 6:02 ` Christoffer Dall
2016-03-09 6:02 ` Christoffer Dall
2016-03-08 11:29 ` [PATCH v3 9/9] clocksource: arm_arch_timer: Remove arch_timer_get_timecounter Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-08 11:29 ` Julien Grall
2016-03-09 6:02 ` Christoffer Dall
2016-03-09 6:02 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DFB61B.4040707@arm.com \
--to=julien.grall@arm.com \
--cc=al.stone@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=fu.wei@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.