All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@linaro.org>
To: Julien Grall <julien.grall@arm.com>,
	eric.auger@st.com, robin.murphy@arm.com,
	alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org,
	tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
	christoffer.dall@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Cc: patches@linaro.org, Manish.Jaggi@caviumnetworks.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [RFC v5 03/17] iommu: introduce a reserved iova cookie
Date: Tue, 29 Mar 2016 19:26:25 +0200	[thread overview]
Message-ID: <56FABAC1.1020506@linaro.org> (raw)
In-Reply-To: <56D865B7.7000404@arm.com>

Hi Julien,
On 03/03/2016 05:26 PM, Julien Grall wrote:
> Hi Eric,
> 
> On 01/03/16 18:27, Eric Auger wrote:
>> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
>> index 0e3b009..7b2bb94 100644
>> --- a/drivers/iommu/iommu.c
>> +++ b/drivers/iommu/iommu.c
>> @@ -1072,6 +1072,7 @@ static struct iommu_domain
>> *__iommu_domain_alloc(struct bus_type *bus,
>>
>>       domain->ops  = bus->iommu_ops;
>>       domain->type = type;
>> +    mutex_init(&domain->reserved_mutex);
> 
> For consistency, the RB-tree reserved_binding_list should be initialized
> too:
> 
> domain->reserved_binding_list = RB_ROOT;
Sure

Thank you

Eric
> 
> Cheers,
> 

WARNING: multiple messages have this Message-ID (diff)
From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC v5 03/17] iommu: introduce a reserved iova cookie
Date: Tue, 29 Mar 2016 19:26:25 +0200	[thread overview]
Message-ID: <56FABAC1.1020506@linaro.org> (raw)
In-Reply-To: <56D865B7.7000404@arm.com>

Hi Julien,
On 03/03/2016 05:26 PM, Julien Grall wrote:
> Hi Eric,
> 
> On 01/03/16 18:27, Eric Auger wrote:
>> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
>> index 0e3b009..7b2bb94 100644
>> --- a/drivers/iommu/iommu.c
>> +++ b/drivers/iommu/iommu.c
>> @@ -1072,6 +1072,7 @@ static struct iommu_domain
>> *__iommu_domain_alloc(struct bus_type *bus,
>>
>>       domain->ops  = bus->iommu_ops;
>>       domain->type = type;
>> +    mutex_init(&domain->reserved_mutex);
> 
> For consistency, the RB-tree reserved_binding_list should be initialized
> too:
> 
> domain->reserved_binding_list = RB_ROOT;
Sure

Thank you

Eric
> 
> Cheers,
> 

  reply	other threads:[~2016-03-29 17:27 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 18:27 [RFC v5 00/17] KVM PCIe/MSI passthrough on ARM/ARM64 Eric Auger
2016-03-01 18:27 ` Eric Auger
2016-03-01 18:27 ` Eric Auger
2016-03-01 18:27 ` [RFC v5 01/17] iommu: Add DOMAIN_ATTR_MSI_MAPPING attribute Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 02/17] iommu/arm-smmu: advertise " Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 03/17] iommu: introduce a reserved iova cookie Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-03 16:26   ` Julien Grall
2016-03-03 16:26     ` Julien Grall
2016-03-03 16:26     ` Julien Grall
2016-03-29 17:26     ` Eric Auger [this message]
2016-03-29 17:26       ` Eric Auger
2016-03-01 18:27 ` [RFC v5 04/17] dma-reserved-iommu: alloc/free_reserved_iova_domain Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 05/17] dma-reserved-iommu: reserved binding rb-tree and helpers Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 06/17] dma-reserved-iommu: iommu_get/put_single_reserved Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-10 11:52   ` Jean-Philippe Brucker
2016-03-10 11:52     ` Jean-Philippe Brucker
2016-03-10 11:52     ` Jean-Philippe Brucker
2016-03-29 17:07     ` Eric Auger
2016-03-29 17:07       ` Eric Auger
2016-03-29 17:07       ` Eric Auger
2016-03-01 18:27 ` [RFC v5 07/17] dma-reserved-iommu: iommu_unmap_reserved Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 08/17] msi: Add a new MSI_FLAG_IRQ_REMAPPING flag Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 09/17] irqchip/gic-v3-its: ITS advertises MSI_FLAG_IRQ_REMAPPING Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 10/17] msi: export msi_get_domain_info Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 11/17] msi: msi_compose wrapper Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 12/17] msi: IOMMU map the doorbell address when needed Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 13/17] vfio: introduce VFIO_IOVA_RESERVED vfio_dma type Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 14/17] vfio: allow the user to register reserved iova range for MSI mapping Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 15/17] vfio/type1: also check IRQ remapping capability at msi domain Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 16/17] iommu/arm-smmu: do not advertise IOMMU_CAP_INTR_REMAP Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27 ` [RFC v5 17/17] vfio/type1: return MSI mapping requirements with VFIO_IOMMU_GET_INFO Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-01 18:27   ` Eric Auger
2016-03-02  8:11 ` [RFC v5 00/17] KVM PCIe/MSI passthrough on ARM/ARM64 Jaggi, Manish
2016-03-02  8:11   ` Jaggi, Manish
2016-03-02  8:11   ` Jaggi, Manish
2016-03-02 12:30   ` Eric Auger
2016-03-02 12:30     ` Eric Auger
2016-03-02 12:30     ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FABAC1.1020506@linaro.org \
    --to=eric.auger@linaro.org \
    --cc=Manish.Jaggi@caviumnetworks.com \
    --cc=alex.williamson@redhat.com \
    --cc=christoffer.dall@linaro.org \
    --cc=eric.auger@st.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jason@lakedaemon.net \
    --cc=joro@8bytes.org \
    --cc=julien.grall@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=patches@linaro.org \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.