From: Thor Thayer <tthayer@opensource.altera.com> To: Lee Jones <lee.jones@linaro.org> Cc: <linus.walleij@linaro.org>, <gnurou@gmail.com>, <jdelvare@suse.com>, <linux@roeck-us.net>, <robh+dt@kernel.org>, <pawell.moll@arm.com>, <mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>, <dinguyen@opensource.altera.com>, <linux-gpio@vger.kernel.org>, <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org> Subject: Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings Date: Thu, 31 Mar 2016 13:21:02 -0500 [thread overview] Message-ID: <56FD6A8E.7030208@opensource.altera.com> (raw) In-Reply-To: <20160330113532.GI3323@x1> Hi Lee, On 03/30/2016 06:35 AM, Lee Jones wrote: > On Tue, 29 Mar 2016, tthayer@opensource.altera.com wrote: > >> From: Thor Thayer <tthayer@opensource.altera.com> >> [..snip..] >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt >> @@ -0,0 +1,35 @@ >> +* Altera Arria10 Development Kit System Resource Chip >> + >> +Required parent device properties: >> +- compatible : "altr,altr_a10sr" >> +- spi-max-frequency : Maximum SPI frequency. >> +- reg : the SPI Chip Select address for the Arria10 System Resource chip > > DT bindings are much easier to read in the following format: > > - compatible : "altr,altr_a10sr" > - spi-max-frequency : Maximum SPI frequency. > - reg : the SPI Chip Select address for the Arria10 System Resource chip > > ... also, sentences start with an uppercase char. > OK. >> +The A10SR consists of this varied group of sub-devices: >> + >> +Device Description >> +------ ---------- >> +altr_a10sr_gpio GPIO Controller >> +altr_a10sr_hwmon Hardware Monitor >> + >> +The LEDs are implemented entirely in the device tree using >> +the gpio-led framework. > > This is a Linuxisum and should not live in DT bindings. > I was following the format of other mfd binding documents such as Documentation/devicetree/bindings/mfd/da9055.txt so I'll need your help understanding this. I'm not familiar with the phrase Linuxisum. A Google search turns up several threads referencing Linuxisum but I can't seem to find the definition. One thread seems to imply that an existing driver such as GPIO is a Linuxisum and should not be re-defined. Am I understanding correctly? >> +Example: >> + >> + a10-sr: a10-sr@0 { > > Nodes should be named after their device 'type'. > > Does this device really start a address 0? OK. If I understand, this should be named after mfd then? > >> + compatible = "altr,altr-a10sr"; >> + reg = <0>; >> + spi-max-frequency = <100000>; >> + >> + a10sr_gpio: a10sr_gpio { > > Device type only please. And this would be a gpio? Thanks for your comments and for reviewing! > >> + compatible = "altr,a10sr-gpio"; >> + gpio-controller; >> + #gpio-cells = <2>; >> + ngpios = <16>; >> + }; >> + >> + a10sr_hwmon: a10sr_hwmon { > > Device type only please. > >> + compatible = "altr,a10sr-hwmon"; >> + }; >> + }; >
WARNING: multiple messages have this Message-ID (diff)
From: Thor Thayer <tthayer@opensource.altera.com> To: Lee Jones <lee.jones@linaro.org> Cc: linus.walleij@linaro.org, gnurou@gmail.com, jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org, pawell.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, dinguyen@opensource.altera.com, linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings Date: Thu, 31 Mar 2016 13:21:02 -0500 [thread overview] Message-ID: <56FD6A8E.7030208@opensource.altera.com> (raw) In-Reply-To: <20160330113532.GI3323@x1> Hi Lee, On 03/30/2016 06:35 AM, Lee Jones wrote: > On Tue, 29 Mar 2016, tthayer@opensource.altera.com wrote: > >> From: Thor Thayer <tthayer@opensource.altera.com> >> [..snip..] >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt >> @@ -0,0 +1,35 @@ >> +* Altera Arria10 Development Kit System Resource Chip >> + >> +Required parent device properties: >> +- compatible : "altr,altr_a10sr" >> +- spi-max-frequency : Maximum SPI frequency. >> +- reg : the SPI Chip Select address for the Arria10 System Resource chip > > DT bindings are much easier to read in the following format: > > - compatible : "altr,altr_a10sr" > - spi-max-frequency : Maximum SPI frequency. > - reg : the SPI Chip Select address for the Arria10 System Resource chip > > ... also, sentences start with an uppercase char. > OK. >> +The A10SR consists of this varied group of sub-devices: >> + >> +Device Description >> +------ ---------- >> +altr_a10sr_gpio GPIO Controller >> +altr_a10sr_hwmon Hardware Monitor >> + >> +The LEDs are implemented entirely in the device tree using >> +the gpio-led framework. > > This is a Linuxisum and should not live in DT bindings. > I was following the format of other mfd binding documents such as Documentation/devicetree/bindings/mfd/da9055.txt so I'll need your help understanding this. I'm not familiar with the phrase Linuxisum. A Google search turns up several threads referencing Linuxisum but I can't seem to find the definition. One thread seems to imply that an existing driver such as GPIO is a Linuxisum and should not be re-defined. Am I understanding correctly? >> +Example: >> + >> + a10-sr: a10-sr@0 { > > Nodes should be named after their device 'type'. > > Does this device really start a address 0? OK. If I understand, this should be named after mfd then? > >> + compatible = "altr,altr-a10sr"; >> + reg = <0>; >> + spi-max-frequency = <100000>; >> + >> + a10sr_gpio: a10sr_gpio { > > Device type only please. And this would be a gpio? Thanks for your comments and for reviewing! > >> + compatible = "altr,a10sr-gpio"; >> + gpio-controller; >> + #gpio-cells = <2>; >> + ngpios = <16>; >> + }; >> + >> + a10sr_hwmon: a10sr_hwmon { > > Device type only please. > >> + compatible = "altr,a10sr-hwmon"; >> + }; >> + }; >
next prev parent reply other threads:[~2016-03-31 18:21 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-29 19:13 [RFC] Addition of Altera Arria10 System Resource Chip tthayer 2016-03-29 19:13 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-03-29 19:13 ` [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings tthayer 2016-03-29 19:13 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-03-30 11:35 ` Lee Jones 2016-03-30 11:36 ` Lee Jones 2016-03-31 14:06 ` Rob Herring 2016-03-31 18:21 ` Thor Thayer [this message] 2016-03-31 18:21 ` Thor Thayer 2016-04-01 8:14 ` Lee Jones 2016-04-01 8:14 ` Lee Jones 2016-04-01 20:21 ` Thor Thayer 2016-04-01 20:21 ` Thor Thayer 2016-03-29 19:13 ` [RFC 2/8] MAINTAINERS: Addition of Altera Arria10 System Resource Chip tthayer 2016-03-29 19:13 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-03-30 8:19 ` Lee Jones 2016-03-30 8:19 ` Lee Jones 2016-03-29 19:13 ` [RFC 3/8] mfd: altr_a10sr: Add Altera Arria10 DevKit " tthayer 2016-03-29 19:13 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-03-30 11:51 ` Lee Jones 2016-03-30 11:51 ` Lee Jones 2016-03-30 14:52 ` Thor Thayer 2016-03-30 14:52 ` Thor Thayer 2016-03-30 14:52 ` Lee Jones 2016-03-30 14:52 ` Lee Jones 2016-03-30 16:10 ` Mark Brown 2016-03-31 9:10 ` Lee Jones 2016-03-31 9:11 ` Lee Jones 2016-03-29 19:13 ` [RFC 4/8] gpio: altera-a10sr: Add A10 System Resource Chip GPIO support tthayer 2016-03-29 19:13 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx [not found] ` <1459278791-3646-5-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-03-30 8:18 ` Lee Jones 2016-03-30 8:18 ` Lee Jones 2016-04-01 12:17 ` Linus Walleij 2016-04-01 20:34 ` Thor Thayer 2016-04-01 20:34 ` Thor Thayer 2016-04-08 11:39 ` Linus Walleij 2016-03-29 19:13 ` [RFC 5/8] ARM: socfpga: dts: Add Devkit A10-SR fields for Arria10 tthayer 2016-03-29 19:13 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-03-30 17:42 ` Dinh Nguyen 2016-03-30 17:42 ` Dinh Nguyen 2016-03-31 18:28 ` Thor Thayer 2016-03-31 18:28 ` Thor Thayer 2016-03-29 19:13 ` [RFC 6/8] ARM: socfpga: dts: Add LED framework to A10-SR GPIO tthayer 2016-03-29 19:13 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx 2016-03-29 19:13 ` [RFC 7/8] hwmon: Altera Arria10 System Resource Chip - HW Monitor tthayer 2016-03-29 19:13 ` tthayer 2016-03-29 20:16 ` Guenter Roeck 2016-03-29 21:43 ` Thor Thayer 2016-03-29 21:43 ` Thor Thayer 2016-03-29 22:29 ` Mark Brown 2016-03-29 22:30 ` Guenter Roeck 2016-03-30 8:17 ` Lee Jones 2016-03-30 8:18 ` Lee Jones 2016-03-29 19:13 ` [RFC 8/8] ARM: socfpga: dts: Add Devkit Arria10-SR HWMON tthayer 2016-03-29 19:13 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx [not found] ` <1459278791-3646-1-git-send-email-tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org> 2016-03-30 8:14 ` [RFC] Addition of Altera Arria10 System Resource Chip Lee Jones 2016-03-30 8:14 ` Lee Jones 2016-03-30 14:27 ` [RFC 7/8] hwmon: Altera Arria10 System Resource Chip - HW Monitor Thor Thayer 2016-03-30 14:31 ` Thor Thayer 2016-04-15 16:57 ` [RFC 1/8] dt-bindings: mfd: Add Altera Arria10 System Resource Chip bindings Thor Thayer 2016-04-15 17:02 ` Thor Thayer 2016-04-18 7:43 ` Lee Jones 2016-04-18 7:44 ` Lee Jones 2016-04-18 7:45 ` Lee Jones 2016-04-18 7:46 ` Lee Jones 2016-04-18 14:51 ` Thor Thayer 2016-04-18 14:55 ` Thor Thayer 2016-04-18 15:07 ` Thor Thayer 2016-04-18 15:12 ` Thor Thayer 2016-04-19 7:23 ` Lee Jones 2016-04-19 7:25 ` Lee Jones 2016-04-19 14:38 ` Thor Thayer 2016-04-19 14:38 ` Thor Thayer 2016-04-20 1:48 ` Guenter Roeck 2016-04-20 1:48 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56FD6A8E.7030208@opensource.altera.com \ --to=tthayer@opensource.altera.com \ --cc=devicetree@vger.kernel.org \ --cc=dinguyen@opensource.altera.com \ --cc=gnurou@gmail.com \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jdelvare@suse.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mark.rutland@arm.com \ --cc=pawell.moll@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.