From: Alim Akhtar <alim.akhtar@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-arm-kernel@lists.infradead.org
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, thomas.ab@samsung.com
Subject: Re: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7
Date: Wed, 13 Apr 2016 10:09:34 +0530 [thread overview]
Message-ID: <570DCD86.40208@samsung.com> (raw)
In-Reply-To: <570D00C6.9000203@samsung.com>
Hi Krzysztof,
On 04/12/2016 07:35 PM, Krzysztof Kozlowski wrote:
> On 04/12/2016 02:49 PM, Alim Akhtar wrote:
>> This patch adds device tree nodes for pdma0 and pdma1 controllers
>> found on exynos7 SoCs.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 29 +++++++++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>>
>
> I would prefer avoid adding all new stuff at the end because it is
> conflict-prone. Alphabetical order or by address... but none of these
> are used currently. How about putting it after 'gic' node?
>
hmm....ok will send v2 with suggested changes.
Looks like other platforms also put it below 'gic'.
> Anyway the code looks fine:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Best regards,
> Krzysztof
>
>
WARNING: multiple messages have this Message-ID (diff)
From: alim.akhtar@samsung.com (Alim Akhtar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7
Date: Wed, 13 Apr 2016 10:09:34 +0530 [thread overview]
Message-ID: <570DCD86.40208@samsung.com> (raw)
In-Reply-To: <570D00C6.9000203@samsung.com>
Hi Krzysztof,
On 04/12/2016 07:35 PM, Krzysztof Kozlowski wrote:
> On 04/12/2016 02:49 PM, Alim Akhtar wrote:
>> This patch adds device tree nodes for pdma0 and pdma1 controllers
>> found on exynos7 SoCs.
>>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> ---
>> arch/arm64/boot/dts/exynos/exynos7.dtsi | 29 +++++++++++++++++++++++++++++
>> 1 file changed, 29 insertions(+)
>>
>
> I would prefer avoid adding all new stuff at the end because it is
> conflict-prone. Alphabetical order or by address... but none of these
> are used currently. How about putting it after 'gic' node?
>
hmm....ok will send v2 with suggested changes.
Looks like other platforms also put it below 'gic'.
> Anyway the code looks fine:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Best regards,
> Krzysztof
>
>
next prev parent reply other threads:[~2016-04-13 4:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 12:49 [PATCH] arm64: dts: Add nodes for pdma0 and pdam1 for exynos7 Alim Akhtar
2016-04-12 12:49 ` Alim Akhtar
2016-04-12 14:05 ` Krzysztof Kozlowski
2016-04-12 14:05 ` Krzysztof Kozlowski
2016-04-13 4:39 ` Alim Akhtar [this message]
2016-04-13 4:39 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570DCD86.40208@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=thomas.ab@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.