From: Javier Martinez Canillas <javier@osg.samsung.com> To: Krzysztof Kozlowski <k.kozlowski@samsung.com>, Kukjin Kim <kgene@kernel.org>, Wolfram Sang <wsa@the-dreams.de>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Subject: Re: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup Date: Wed, 20 Apr 2016 09:59:52 -0400 [thread overview] Message-ID: <57178B58.7050104@osg.samsung.com> (raw) In-Reply-To: <1461144292-22141-2-git-send-email-k.kozlowski@samsung.com> Hello Krzysztof, On 04/20/2016 05:24 AM, Krzysztof Kozlowski wrote: > Cleanup the weird function-level comments and remove obvious > documentatoin for probe/remove. > s/documentatoin/documentation > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- I wonder if instead we should change to kernel-doc formatted documentation. All the functions are static so kernel-doc is not really required but still Documentation/kernel-doc-nano-HOWTO.txt says that is suggested for source code layout consistency. But I agree that's either kernel-doc format or minimal as your patch does: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup Date: Wed, 20 Apr 2016 09:59:52 -0400 [thread overview] Message-ID: <57178B58.7050104@osg.samsung.com> (raw) In-Reply-To: <1461144292-22141-2-git-send-email-k.kozlowski@samsung.com> Hello Krzysztof, On 04/20/2016 05:24 AM, Krzysztof Kozlowski wrote: > Cleanup the weird function-level comments and remove obvious > documentatoin for probe/remove. > s/documentatoin/documentation > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- I wonder if instead we should change to kernel-doc formatted documentation. All the functions are static so kernel-doc is not really required but still Documentation/kernel-doc-nano-HOWTO.txt says that is suggested for source code layout consistency. But I agree that's either kernel-doc format or minimal as your patch does: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
next prev parent reply other threads:[~2016-04-20 14:00 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-20 9:24 [PATCH 1/3] i2c: s3c2410: Add missing clock unprepare on probe() error path Krzysztof Kozlowski 2016-04-20 9:24 ` Krzysztof Kozlowski 2016-04-20 9:24 ` [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup Krzysztof Kozlowski 2016-04-20 9:24 ` Krzysztof Kozlowski 2016-04-20 13:59 ` Javier Martinez Canillas [this message] 2016-04-20 13:59 ` Javier Martinez Canillas 2016-04-21 7:01 ` Krzysztof Kozlowski 2016-04-21 7:01 ` Krzysztof Kozlowski 2016-04-20 9:24 ` [PATCH 3/3] i2c: s3c2410: Cleanup indentation and comment style Krzysztof Kozlowski 2016-04-20 9:24 ` Krzysztof Kozlowski 2016-04-20 14:02 ` Javier Martinez Canillas 2016-04-20 14:02 ` Javier Martinez Canillas 2016-04-20 13:47 ` [PATCH 1/3] i2c: s3c2410: Add missing clock unprepare on probe() error path Javier Martinez Canillas 2016-04-20 13:47 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57178B58.7050104@osg.samsung.com \ --to=javier@osg.samsung.com \ --cc=b.zolnierkie@samsung.com \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.