From: Lars-Peter Clausen <lars@metafoo.de>
To: Matthias Reichl <hias@horus.com>
Cc: alsa-devel@alsa-project.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Eric Anholt <eric@anholt.net>, Mark Brown <broonie@kernel.org>,
Florian Meier <florian.meier@koalo.de>,
linux-rpi-kernel@lists.infradead.org, kernel@martin.sperl.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ASoC: bcm2835: Register also as PCM device
Date: Tue, 26 Apr 2016 21:09:08 +0200 [thread overview]
Message-ID: <571FBCD4.3010407@metafoo.de> (raw)
In-Reply-To: <20160426180542.GA767@camel2.lan>
On 04/26/2016 08:05 PM, Matthias Reichl wrote:
[...]
>
> Ok, I think I got you now and I have to say that solution is really elegant.
> I wouldn't have thought that it could be that simple. V2 of the patch
> is below.
Looks good. One minor thing inline below. Please split this into two
patches, one adding support for the flag and the other using it in the bcm
diver and then send them to the ASoC maintainers.
[...]
> + hw.formats = GENMASK_ULL((int)SNDRV_PCM_FORMAT_LAST-1, 0);
setting it to 0 is OK. 0 is a special case that means all formats supported.
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 3/3] ASoC: bcm2835: Register also as PCM device
Date: Tue, 26 Apr 2016 21:09:08 +0200 [thread overview]
Message-ID: <571FBCD4.3010407@metafoo.de> (raw)
In-Reply-To: <20160426180542.GA767@camel2.lan>
On 04/26/2016 08:05 PM, Matthias Reichl wrote:
[...]
>
> Ok, I think I got you now and I have to say that solution is really elegant.
> I wouldn't have thought that it could be that simple. V2 of the patch
> is below.
Looks good. One minor thing inline below. Please split this into two
patches, one adding support for the flag and the other using it in the bcm
diver and then send them to the ASoC maintainers.
[...]
> + hw.formats = GENMASK_ULL((int)SNDRV_PCM_FORMAT_LAST-1, 0);
setting it to 0 is OK. 0 is a special case that means all formats supported.
next prev parent reply other threads:[~2016-04-26 19:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:39 [PATCH 1/3] ASoC: bcm2835: add 24bit support kernel
2016-04-25 13:39 ` kernel at martin.sperl.org
2016-04-25 13:39 ` [PATCH 2/3] ASoC: bcm2835: setup clock only if CPU is clock master kernel
2016-04-25 13:39 ` kernel at martin.sperl.org
2016-04-25 13:39 ` [PATCH 3/3] ASoC: bcm2835: Register also as PCM device kernel
2016-04-25 13:39 ` kernel at martin.sperl.org
2016-04-25 13:54 ` Lars-Peter Clausen
2016-04-25 13:54 ` Lars-Peter Clausen
2016-04-25 17:15 ` Matthias Reichl
2016-04-25 17:15 ` Matthias Reichl
2016-04-26 8:47 ` Lars-Peter Clausen
2016-04-26 8:47 ` [alsa-devel] " Lars-Peter Clausen
2016-04-26 13:09 ` Matthias Reichl
2016-04-26 13:09 ` [alsa-devel] " Matthias Reichl
2016-04-26 13:22 ` Lars-Peter Clausen
2016-04-26 13:22 ` [alsa-devel] " Lars-Peter Clausen
2016-04-26 15:18 ` Matthias Reichl
2016-04-26 15:18 ` [alsa-devel] " Matthias Reichl
2016-04-26 15:30 ` Lars-Peter Clausen
2016-04-26 15:30 ` [alsa-devel] " Lars-Peter Clausen
2016-04-26 18:05 ` Matthias Reichl
2016-04-26 18:05 ` [alsa-devel] " Matthias Reichl
2016-04-26 19:09 ` Lars-Peter Clausen [this message]
2016-04-26 19:09 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571FBCD4.3010407@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=eric@anholt.net \
--cc=florian.meier@koalo.de \
--cc=hias@horus.com \
--cc=kernel@martin.sperl.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.