From: Roger Quadros <rogerq@ti.com> To: Peter Chen <hzpeterchen@gmail.com> Cc: <stern@rowland.harvard.edu>, <balbi@kernel.org>, <gregkh@linuxfoundation.org>, <peter.chen@freescale.com>, <dan.j.williams@intel.com>, <jun.li@freescale.com>, <mathias.nyman@linux.intel.com>, <tony@atomide.com>, <Joao.Pinto@synopsys.com>, <abrestic@chromium.org>, <r.baldyga@samsung.com>, <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org> Subject: Re: [PATCH v6 11/12] usb: core: hub: Notify OTG fsm when A device sets b_hnp_enable Date: Wed, 27 Apr 2016 17:35:15 +0300 [thread overview] Message-ID: <5720CE23.7050305@ti.com> (raw) In-Reply-To: <20160418070842.GC4477@shlinux2.ap.freescale.net> On 18/04/16 10:08, Peter Chen wrote: > On Tue, Apr 05, 2016 at 05:05:16PM +0300, Roger Quadros wrote: >> This is the a_set_b_hnp_enable flag in the OTG state machine >> diagram and must be set when the A-Host has successfully set >> the b_hnp_enable feature of the OTG-B-Peripheral attached to it. >> >> When this bit changes we kick our OTG FSM to make note of the >> change and act accordingly. > > Since we have still not added fsm.a_set_b_hnp_en in OTG FSM, and this > patch set is mainly for DRD, would you please move out this patch from > this set? Sure. cheers, -roger > >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> drivers/usb/core/hub.c | 17 +++++++++++++++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c >> index 38cc4ba..27e3b4c 100644 >> --- a/drivers/usb/core/hub.c >> +++ b/drivers/usb/core/hub.c >> @@ -2273,6 +2273,7 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> && udev->parent == udev->bus->root_hub) { >> struct usb_otg_descriptor *desc = NULL; >> struct usb_bus *bus = udev->bus; >> + struct usb_hcd *hcd = bus_to_hcd(bus); >> unsigned port1 = udev->portnum; >> >> /* descriptor may appear anywhere in config */ >> @@ -2302,6 +2303,9 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> dev_err(&udev->dev, "can't set HNP mode: %d\n", >> err); >> bus->b_hnp_enable = 0; >> + } else { >> + /* notify OTG fsm about a_set_b_hnp_enable */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> } >> } else if (desc->bLength == sizeof >> (struct usb_otg_descriptor)) { >> @@ -2312,10 +2316,14 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> USB_DEVICE_A_ALT_HNP_SUPPORT, >> 0, NULL, 0, >> USB_CTRL_SET_TIMEOUT); >> - if (err < 0) >> + if (err < 0) { >> dev_err(&udev->dev, >> "set a_alt_hnp_support failed: %d\n", >> err); >> + } else { >> + /* notify OTG fsm about a_set_b_hnp_enable */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> + } >> } >> } >> #endif >> @@ -4355,8 +4363,13 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1, >> */ >> if (!hdev->parent) { >> delay = HUB_ROOT_RESET_TIME; >> - if (port1 == hdev->bus->otg_port) >> + if (port1 == hdev->bus->otg_port) { >> hdev->bus->b_hnp_enable = 0; >> +#ifdef CONFIG_USB_OTG >> + /* notify OTG fsm about a_set_b_hnp_enable change */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> +#endif >> + } >> } >> >> /* Some low speed devices have problems with the quick delay, so */ >> -- >> 2.5.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com> To: Peter Chen <hzpeterchen@gmail.com> Cc: stern@rowland.harvard.edu, balbi@kernel.org, gregkh@linuxfoundation.org, peter.chen@freescale.com, dan.j.williams@intel.com, jun.li@freescale.com, mathias.nyman@linux.intel.com, tony@atomide.com, Joao.Pinto@synopsys.com, abrestic@chromium.org, r.baldyga@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 11/12] usb: core: hub: Notify OTG fsm when A device sets b_hnp_enable Date: Wed, 27 Apr 2016 17:35:15 +0300 [thread overview] Message-ID: <5720CE23.7050305@ti.com> (raw) In-Reply-To: <20160418070842.GC4477@shlinux2.ap.freescale.net> On 18/04/16 10:08, Peter Chen wrote: > On Tue, Apr 05, 2016 at 05:05:16PM +0300, Roger Quadros wrote: >> This is the a_set_b_hnp_enable flag in the OTG state machine >> diagram and must be set when the A-Host has successfully set >> the b_hnp_enable feature of the OTG-B-Peripheral attached to it. >> >> When this bit changes we kick our OTG FSM to make note of the >> change and act accordingly. > > Since we have still not added fsm.a_set_b_hnp_en in OTG FSM, and this > patch set is mainly for DRD, would you please move out this patch from > this set? Sure. cheers, -roger > >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> drivers/usb/core/hub.c | 17 +++++++++++++++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c >> index 38cc4ba..27e3b4c 100644 >> --- a/drivers/usb/core/hub.c >> +++ b/drivers/usb/core/hub.c >> @@ -2273,6 +2273,7 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> && udev->parent == udev->bus->root_hub) { >> struct usb_otg_descriptor *desc = NULL; >> struct usb_bus *bus = udev->bus; >> + struct usb_hcd *hcd = bus_to_hcd(bus); >> unsigned port1 = udev->portnum; >> >> /* descriptor may appear anywhere in config */ >> @@ -2302,6 +2303,9 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> dev_err(&udev->dev, "can't set HNP mode: %d\n", >> err); >> bus->b_hnp_enable = 0; >> + } else { >> + /* notify OTG fsm about a_set_b_hnp_enable */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> } >> } else if (desc->bLength == sizeof >> (struct usb_otg_descriptor)) { >> @@ -2312,10 +2316,14 @@ static int usb_enumerate_device_otg(struct usb_device *udev) >> USB_DEVICE_A_ALT_HNP_SUPPORT, >> 0, NULL, 0, >> USB_CTRL_SET_TIMEOUT); >> - if (err < 0) >> + if (err < 0) { >> dev_err(&udev->dev, >> "set a_alt_hnp_support failed: %d\n", >> err); >> + } else { >> + /* notify OTG fsm about a_set_b_hnp_enable */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> + } >> } >> } >> #endif >> @@ -4355,8 +4363,13 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1, >> */ >> if (!hdev->parent) { >> delay = HUB_ROOT_RESET_TIME; >> - if (port1 == hdev->bus->otg_port) >> + if (port1 == hdev->bus->otg_port) { >> hdev->bus->b_hnp_enable = 0; >> +#ifdef CONFIG_USB_OTG >> + /* notify OTG fsm about a_set_b_hnp_enable change */ >> + usb_otg_kick_fsm(hcd->otg_dev); >> +#endif >> + } >> } >> >> /* Some low speed devices have problems with the quick delay, so */ >> -- >> 2.5.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2016-04-27 14:35 UTC|newest] Thread overview: 155+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-05 14:05 [PATCH v6 00/12] USB OTG/dual-role framework Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-05 14:05 ` [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0 Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-06 6:09 ` Felipe Balbi 2016-04-06 6:09 ` Felipe Balbi 2016-04-06 6:32 ` Roger Quadros 2016-04-06 6:32 ` Roger Quadros 2016-04-07 9:42 ` Peter Chen 2016-04-07 10:40 ` Roger Quadros 2016-04-07 10:40 ` Roger Quadros 2016-04-08 1:01 ` Peter Chen 2016-04-08 1:01 ` Peter Chen 2016-04-08 7:16 ` Roger Quadros 2016-04-08 7:16 ` Roger Quadros 2016-04-08 7:45 ` Peter Chen 2016-04-08 7:45 ` Peter Chen 2016-04-18 2:29 ` Peter Chen 2016-04-18 14:11 ` Alan Stern 2016-04-18 14:11 ` Alan Stern 2016-04-19 1:56 ` Peter Chen 2016-04-19 1:56 ` Peter Chen 2016-04-20 8:15 ` Roger Quadros 2016-04-20 8:15 ` Roger Quadros 2016-04-20 9:40 ` Peter Chen 2016-04-05 14:05 ` [PATCH v6 02/12] usb: hcd.h: Add OTG to HCD interface Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-18 7:41 ` Peter Chen 2016-04-05 14:05 ` [PATCH v6 03/12] usb: otg-fsm: use usb_otg wherever possible Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-18 7:42 ` Peter Chen 2016-04-05 14:05 ` [PATCH v6 04/12] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-18 8:00 ` Peter Chen 2016-04-18 8:00 ` Peter Chen 2016-04-05 14:05 ` [PATCH v6 05/12] usb: gadget.h: Add OTG to gadget interface Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-05 14:05 ` [PATCH v6 06/12] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-18 8:05 ` Peter Chen 2016-04-20 8:12 ` Roger Quadros 2016-04-20 8:12 ` Roger Quadros 2016-04-05 14:05 ` [PATCH v6 07/12] usb: otg: add OTG/dual-role core Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-07 8:52 ` Yoshihiro Shimoda 2016-04-07 11:45 ` Roger Quadros 2016-04-08 11:22 ` Yoshihiro Shimoda 2016-04-11 10:54 ` Roger Quadros 2016-04-14 8:36 ` Yoshihiro Shimoda 2016-04-14 10:59 ` Roger Quadros 2016-04-14 11:15 ` Yoshihiro Shimoda 2016-04-14 11:15 ` Yoshihiro Shimoda 2016-04-14 11:32 ` Roger Quadros 2016-04-14 11:32 ` Roger Quadros 2016-04-15 9:59 ` Yoshihiro Shimoda 2016-04-15 9:59 ` Yoshihiro Shimoda 2016-04-15 10:57 ` Roger Quadros 2016-04-15 10:57 ` Roger Quadros 2016-04-15 10:03 ` Yoshihiro Shimoda 2016-04-19 9:18 ` Peter Chen 2016-04-20 5:08 ` Yoshihiro Shimoda 2016-04-20 7:03 ` Roger Quadros 2016-04-22 6:05 ` Peter Chen 2016-04-22 6:05 ` Peter Chen 2016-04-22 1:26 ` Peter Chen 2016-04-22 3:34 ` Peter Chen 2016-04-22 3:34 ` Peter Chen 2016-04-22 5:57 ` Yoshihiro Shimoda 2016-04-22 5:57 ` Yoshihiro Shimoda 2016-04-15 9:25 ` Peter Chen 2016-04-15 9:25 ` Peter Chen 2016-04-15 11:00 ` Roger Quadros 2016-04-15 11:00 ` Roger Quadros 2016-04-18 2:09 ` Peter Chen 2016-04-20 6:54 ` Roger Quadros 2016-04-20 6:54 ` Roger Quadros 2016-04-20 9:26 ` Peter Chen 2016-04-19 8:06 ` Peter Chen 2016-04-20 7:02 ` Roger Quadros 2016-04-20 7:02 ` Roger Quadros 2016-04-20 9:39 ` Peter Chen 2016-04-21 6:52 ` Peter Chen 2016-04-21 6:52 ` Peter Chen 2016-04-25 14:05 ` Roger Quadros 2016-04-25 14:05 ` Roger Quadros 2016-04-26 2:07 ` Jun Li 2016-04-26 3:47 ` Peter Chen 2016-04-26 3:47 ` Peter Chen 2016-04-26 5:11 ` Jun Li 2016-04-26 5:11 ` Jun Li 2016-04-26 6:28 ` Peter Chen 2016-04-26 6:28 ` Peter Chen 2016-04-26 7:00 ` Jun Li 2016-04-26 7:00 ` Jun Li 2016-04-26 8:21 ` Peter Chen 2016-04-27 3:15 ` Peter Chen 2016-04-27 10:59 ` Roger Quadros 2016-04-27 10:59 ` Roger Quadros 2016-04-28 1:54 ` Peter Chen 2016-04-28 1:54 ` Peter Chen 2016-04-28 8:01 ` Roger Quadros 2016-04-28 8:01 ` Roger Quadros 2016-04-27 11:15 ` Roger Quadros 2016-04-05 14:05 ` [PATCH v6 08/12] usb: hcd: Adapt to OTG core Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-18 6:29 ` Peter Chen 2016-04-19 8:14 ` Peter Chen 2016-04-20 6:47 ` Roger Quadros 2016-04-20 6:47 ` Roger Quadros 2016-04-20 6:46 ` Roger Quadros 2016-04-20 6:46 ` Roger Quadros 2016-04-27 10:16 ` Jun Li 2016-04-27 11:00 ` Roger Quadros 2016-04-27 11:11 ` Roger Quadros 2016-04-27 12:49 ` Jun Li 2016-04-27 13:18 ` Jun Li 2016-04-05 14:05 ` [PATCH v6 09/12] usb: gadget: udc: adapt " Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-18 6:59 ` Peter Chen 2016-04-18 6:59 ` Peter Chen 2016-04-20 6:51 ` Roger Quadros 2016-04-20 6:51 ` Roger Quadros 2016-04-21 6:38 ` Jun Li 2016-04-25 14:04 ` Roger Quadros 2016-04-26 0:07 ` Jun Li 2016-04-27 11:22 ` Roger Quadros 2016-04-27 11:22 ` Roger Quadros 2016-04-28 9:54 ` Roger Quadros 2016-04-28 9:54 ` Roger Quadros 2016-04-28 10:23 ` Jun Li 2016-04-28 12:22 ` Roger Quadros 2016-05-03 7:06 ` Jun Li 2016-05-03 15:44 ` Roger Quadros 2016-05-04 1:47 ` Peter Chen 2016-05-04 1:47 ` Peter Chen 2016-05-04 3:35 ` Peter Chen 2016-05-04 6:37 ` Roger Quadros 2016-05-04 7:53 ` Peter Chen 2016-05-04 8:03 ` Jun Li 2016-05-04 8:40 ` Roger Quadros 2016-05-04 8:40 ` Roger Quadros 2016-05-04 8:39 ` Peter Chen 2016-04-05 14:05 ` [PATCH v6 10/12] usb: doc: dt-binding: Add otg-controller property Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-05 14:05 ` [PATCH v6 11/12] usb: core: hub: Notify OTG fsm when A device sets b_hnp_enable Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-18 7:08 ` Peter Chen 2016-04-27 14:35 ` Roger Quadros [this message] 2016-04-27 14:35 ` Roger Quadros 2016-04-05 14:05 ` [PATCH v6 12/12] usb: host: xhci-plat: Add otg device to platform data Roger Quadros 2016-04-05 14:05 ` Roger Quadros 2016-04-06 3:23 ` Yoshihiro Shimoda 2016-04-06 3:23 ` Yoshihiro Shimoda 2016-04-06 6:30 ` Roger Quadros 2016-04-06 6:30 ` Roger Quadros
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5720CE23.7050305@ti.com \ --to=rogerq@ti.com \ --cc=Joao.Pinto@synopsys.com \ --cc=abrestic@chromium.org \ --cc=balbi@kernel.org \ --cc=dan.j.williams@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=hzpeterchen@gmail.com \ --cc=jun.li@freescale.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@linux.intel.com \ --cc=peter.chen@freescale.com \ --cc=r.baldyga@samsung.com \ --cc=stern@rowland.harvard.edu \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.