From: Mike Christie <mchristi@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, konrad.wilk@oracle.com,
drbd-dev@lists.linbit.com, philipp.reisner@linbit.com,
lars.ellenberg@linbit.com, linux-raid@vger.kernel.org,
dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mtd@lists.infradead.org, target-devel@vger.kernel.org,
linux-btrfs@vger.kernel.org, osd-dev@open-osd.org,
xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs
Date: Wed, 4 May 2016 12:51:59 -0500 [thread overview]
Message-ID: <572A36BF.3070208@redhat.com> (raw)
In-Reply-To: <x49d1p2c1nx.fsf@segfault.boston.devel.redhat.com>
On 05/03/2016 03:44 PM, Jeff Moyer wrote:
> mchristi@redhat.com writes:
>
>> The following patches begin to cleanup the request->cmd_flags and
>> bio->bi_rw mess. We currently use cmd_flags to specify the operation,
>> attributes and state of the request. For bi_rw we use it for similar
>> info and also the priority but then also have another bi_flags field
>> for state. At some point, we abused them so much we just made cmd_flags
>> 64 bits, so we could add more.
>>
>> The following patches seperate the operation (read, write discard,
>> flush, etc) from cmd_flags/bi_rw.
>>
>> This patchset was made against linux-next from today April 15
>> (git tag next-20160415).
>>
>> I put a git tree here:
>> https://github.com/mikechristie/linux-kernel.git
>> The patches are in the op branch.
>
> Hi, Mike,
>
> That git tree doesn't seem to exist. I did manage to apply your patch
> set on top of next-20160415, though.
>
> So... what testing did you do? ;-) I ran into the following problems
I normally run xfstests and run it on my daily workstation and laptop. I
did not do this for every FS this time and hit a regression.
What FS were you using?
> - git clone fails
> - yum segfaults
In v7/v6, I missed a new submit_bio call, so I hit issues like the two
above. I have this fixed in the next version.
> - many blktrace/blkparse issues, including incorrect cpu recorded in
> traces, null task names, and blkparse outputting nothing for a trace
> file several gigabytes in size.
I will double check for these issues.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <mchristi@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com,
linux-scsi@vger.kernel.org, konrad.wilk@oracle.com,
linux-kernel@vger.kernel.org, philipp.reisner@linbit.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-raid@vger.kernel.org, dm-devel@redhat.com,
target-devel@vger.kernel.org, linux-mtd@lists.infradead.org,
osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org,
lars.ellenberg@linbit.com, linux-ext4@vger.kernel.org,
linux-btrfs@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs
Date: Wed, 4 May 2016 12:51:59 -0500 [thread overview]
Message-ID: <572A36BF.3070208@redhat.com> (raw)
In-Reply-To: <x49d1p2c1nx.fsf@segfault.boston.devel.redhat.com>
On 05/03/2016 03:44 PM, Jeff Moyer wrote:
> mchristi@redhat.com writes:
>
>> The following patches begin to cleanup the request->cmd_flags and
>> bio->bi_rw mess. We currently use cmd_flags to specify the operation,
>> attributes and state of the request. For bi_rw we use it for similar
>> info and also the priority but then also have another bi_flags field
>> for state. At some point, we abused them so much we just made cmd_flags
>> 64 bits, so we could add more.
>>
>> The following patches seperate the operation (read, write discard,
>> flush, etc) from cmd_flags/bi_rw.
>>
>> This patchset was made against linux-next from today April 15
>> (git tag next-20160415).
>>
>> I put a git tree here:
>> https://github.com/mikechristie/linux-kernel.git
>> The patches are in the op branch.
>
> Hi, Mike,
>
> That git tree doesn't seem to exist. I did manage to apply your patch
> set on top of next-20160415, though.
>
> So... what testing did you do? ;-) I ran into the following problems
I normally run xfstests and run it on my daily workstation and laptop. I
did not do this for every FS this time and hit a regression.
What FS were you using?
> - git clone fails
> - yum segfaults
In v7/v6, I missed a new submit_bio call, so I hit issues like the two
above. I have this fixed in the next version.
> - many blktrace/blkparse issues, including incorrect cpu recorded in
> traces, null task names, and blkparse outputting nothing for a trace
> file several gigabytes in size.
I will double check for these issues.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <mchristi@redhat.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, konrad.wilk@oracle.com,
drbd-dev@lists.linbit.com, philipp.reisner@linbit.com,
lars.ellenberg@linbit.com, linux-raid@vger.kernel.org,
dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-mtd@lists.infradead.org, target-devel@vger.kernel.org,
linux-btrfs@vger.kernel.org, osd-dev@open-osd.org,
xfs@oss.sgi.com, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 00/42] v7: separate operations from flags in the bio/request structs
Date: Wed, 4 May 2016 12:51:59 -0500 [thread overview]
Message-ID: <572A36BF.3070208@redhat.com> (raw)
In-Reply-To: <x49d1p2c1nx.fsf@segfault.boston.devel.redhat.com>
On 05/03/2016 03:44 PM, Jeff Moyer wrote:
> mchristi at redhat.com writes:
>
>> The following patches begin to cleanup the request->cmd_flags and
>> bio->bi_rw mess. We currently use cmd_flags to specify the operation,
>> attributes and state of the request. For bi_rw we use it for similar
>> info and also the priority but then also have another bi_flags field
>> for state. At some point, we abused them so much we just made cmd_flags
>> 64 bits, so we could add more.
>>
>> The following patches seperate the operation (read, write discard,
>> flush, etc) from cmd_flags/bi_rw.
>>
>> This patchset was made against linux-next from today April 15
>> (git tag next-20160415).
>>
>> I put a git tree here:
>> https://github.com/mikechristie/linux-kernel.git
>> The patches are in the op branch.
>
> Hi, Mike,
>
> That git tree doesn't seem to exist. I did manage to apply your patch
> set on top of next-20160415, though.
>
> So... what testing did you do? ;-) I ran into the following problems
I normally run xfstests and run it on my daily workstation and laptop. I
did not do this for every FS this time and hit a regression.
What FS were you using?
> - git clone fails
> - yum segfaults
In v7/v6, I missed a new submit_bio call, so I hit issues like the two
above. I have this fixed in the next version.
> - many blktrace/blkparse issues, including incorrect cpu recorded in
> traces, null task names, and blkparse outputting nothing for a trace
> file several gigabytes in size.
I will double check for these issues.
next prev parent reply other threads:[~2016-05-04 17:51 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 19:15 [PATCH 00/42] v7: separate operations from flags in the bio/request structs mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 01/42] block/fs/drivers: remove rw argument from submit_bio mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 02/42] block: add REQ_OP definitions and bi_op/op fields mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 03/42] block, fs, mm, drivers: set bi_op to REQ_OP mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 04/42] fs: have submit_bh users pass in op and flags separately mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 05/42] fs: have ll_rw_block " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 06/42] direct-io: set bi_op to REQ_OP mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 07/42] btrfs: have submit_one_bio users setup bio bi_op mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 08/42] btrfs: set bi_op tp REQ_OP mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 09/42] btrfs: update __btrfs_map_block for bi_op transition mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 10/42] btrfs: use bio fields for op and flags mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 11/42] f2fs: set bi_op to REQ_OP mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 12/42] gfs2: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 13/42] xfs: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 14/42] hfsplus: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 15/42] mpage: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 16/42] nilfs: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-18 16:04 ` Ryusuke Konishi
2016-04-18 16:04 ` [Ocfs2-devel] " Ryusuke Konishi
2016-04-18 16:04 ` Ryusuke Konishi
2016-04-15 19:15 ` [PATCH 17/42] ocfs2: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 18/42] pm: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 19/42] dm: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 20/42] dm: pass dm stats data dir instead of bi_rw mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 21/42] bcache: set bi_op to REQ_OP mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 22/42] drbd: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:15 ` [PATCH 23/42] md/raid: " mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-23 23:05 ` [PATCH] RAID Cleanup for bio-split Shaun Tancheff
2016-04-23 23:05 ` [Ocfs2-devel] " Shaun Tancheff
2016-04-15 19:15 ` [PATCH 24/42] xen: set bi_op to REQ_OP mchristi
2016-04-15 19:15 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:15 ` mchristi
2016-04-15 19:16 ` [PATCH 25/42] target: " mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 26/42] block: copy bio op to request op mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 27/42] block: prepare request creation/destruction code to use REQ_OPs mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 28/42] block: prepare mq request creation " mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 29/42] block: prepare elevator " mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 30/42] blkg_rwstat: separate op from flags mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 31/42] block: convert merge/insert code to check for REQ_OPs mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 32/42] block: convert is_sync helpers to use REQ_OPs mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 33/42] block: convert rq_data_dir helper " mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 34/42] drivers: set request op to REQ_OP mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 35/42] blktrace: get op from req->op/bio->bi_op mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 36/42] ide cd: do not set REQ_WRITE on requests mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 37/42] block, fs, drivers: do use bi_rw/cmd_flags for REQ_OPs mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 38/42] block, fs: remove old REQ definitions mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 39/42] block: shrink bio/request fields mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 40/42] block, drivers: add REQ_OP_FLUSH operation mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:16 ` [PATCH 41/42] block: do not use REQ_FLUSH for tracking flush support mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-17 8:46 ` Juergen Gross
2016-04-17 8:46 ` [Ocfs2-devel] " Juergen Gross
2016-04-17 8:46 ` Juergen Gross
2016-04-15 19:16 ` [PATCH 42/42] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH mchristi
2016-04-15 19:16 ` [Ocfs2-devel] " mchristi at redhat.com
2016-04-15 19:16 ` mchristi
2016-04-15 19:44 ` [PATCH 00/42] v7: separate operations from flags in the bio/request structs Mike Snitzer
2016-04-15 19:44 ` [Ocfs2-devel] " Mike Snitzer
2016-04-15 19:44 ` Mike Snitzer
[not found] ` <1460747777-8479-1-git-send-email-mchristi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-03 20:44 ` Jeff Moyer
2016-05-03 20:44 ` [Ocfs2-devel] " Jeff Moyer
2016-05-03 20:44 ` Jeff Moyer
2016-05-03 20:44 ` Jeff Moyer
2016-05-04 17:51 ` Mike Christie [this message]
2016-05-04 17:51 ` [Ocfs2-devel] " Mike Christie
2016-05-04 17:51 ` Mike Christie
[not found] ` <572A36BF.3070208-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-04 17:58 ` Jeff Moyer
2016-05-04 17:58 ` [Ocfs2-devel] " Jeff Moyer
2016-05-04 17:58 ` Jeff Moyer
2016-05-04 17:58 ` Jeff Moyer
2016-05-04 18:04 ` Mike Christie
2016-05-04 18:04 ` [Ocfs2-devel] " Mike Christie
2016-05-04 18:04 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572A36BF.3070208@redhat.com \
--to=mchristi@redhat.com \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=jmoyer@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=osd-dev@open-osd.org \
--cc=philipp.reisner@linbit.com \
--cc=target-devel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.