From: Ben Greear <greearb@candelatech.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Subject: Re: [PATCH] ath10k: Fix 10.4 extended peer stats update
Date: Tue, 10 May 2016 10:10:11 -0700 [thread overview]
Message-ID: <573215F3.3050109@candelatech.com> (raw)
In-Reply-To: <20160510164049.GC21638@atheros-ThinkPad-T61>
On 05/10/2016 09:40 AM, Mohammed Shafi Shajakhan wrote:
> On Tue, May 10, 2016 at 09:34:55AM -0700, Ben Greear wrote:
>> On 05/10/2016 09:27 AM, Mohammed Shafi Shajakhan wrote:
>>> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>>>
>>> 10.4 'extended peer stats' will be not be appended with normal peer stats
>>> data and they shall be coming in separate chunks. Fix this by maintaining
>>> a separate linked list 'extender peer stats' for 10.4 and update
>>> rx_duration for per station statistics. Also parse through beacon filter
>>> (if enabled), to make sure we parse the extended peer stats properly.
>>> This issue was exposed when more than one client is connected and
>>> extended peer stats for 10.4 is enabled
>>
>> In general, maybe more of these stats should be kept in the driver instead
>> of the firmware? The firmware is very tight on RAM already, and if
>> we can pass the needed info back to the host, it could gather arbitrary
>> amounts of stats as needed.
>>
>
> [shafi] agreed, probably thats why we are tracking u64 counters like rx_duration
> etc in host while the firmware variable will wrap aroud in sometime
If firmware could be modified to return more per-frame info, then the driver
could do virtually all of the stats gathering. It would cost a bit of RAM
to hold that descriptor information, but over-all, the firmware might be a lot
simpler....
On the TX side, it would also allow intelligent host-based rate-ctrl. Especially
considering the complexity of mu-mimo, it might be nice to get rate-ctrl into the
kernel where more people can work on it in a more flexible manner.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Mohammed Shafi Shajakhan <mohammed@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
Subject: Re: [PATCH] ath10k: Fix 10.4 extended peer stats update
Date: Tue, 10 May 2016 10:10:11 -0700 [thread overview]
Message-ID: <573215F3.3050109@candelatech.com> (raw)
In-Reply-To: <20160510164049.GC21638@atheros-ThinkPad-T61>
On 05/10/2016 09:40 AM, Mohammed Shafi Shajakhan wrote:
> On Tue, May 10, 2016 at 09:34:55AM -0700, Ben Greear wrote:
>> On 05/10/2016 09:27 AM, Mohammed Shafi Shajakhan wrote:
>>> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>>>
>>> 10.4 'extended peer stats' will be not be appended with normal peer stats
>>> data and they shall be coming in separate chunks. Fix this by maintaining
>>> a separate linked list 'extender peer stats' for 10.4 and update
>>> rx_duration for per station statistics. Also parse through beacon filter
>>> (if enabled), to make sure we parse the extended peer stats properly.
>>> This issue was exposed when more than one client is connected and
>>> extended peer stats for 10.4 is enabled
>>
>> In general, maybe more of these stats should be kept in the driver instead
>> of the firmware? The firmware is very tight on RAM already, and if
>> we can pass the needed info back to the host, it could gather arbitrary
>> amounts of stats as needed.
>>
>
> [shafi] agreed, probably thats why we are tracking u64 counters like rx_duration
> etc in host while the firmware variable will wrap aroud in sometime
If firmware could be modified to return more per-frame info, then the driver
could do virtually all of the stats gathering. It would cost a bit of RAM
to hold that descriptor information, but over-all, the firmware might be a lot
simpler....
On the TX side, it would also allow intelligent host-based rate-ctrl. Especially
considering the complexity of mu-mimo, it might be nice to get rate-ctrl into the
kernel where more people can work on it in a more flexible manner.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-05-10 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 16:27 [PATCH] ath10k: Fix 10.4 extended peer stats update Mohammed Shafi Shajakhan
2016-05-10 16:27 ` Mohammed Shafi Shajakhan
2016-05-10 16:34 ` Ben Greear
2016-05-10 16:34 ` Ben Greear
2016-05-10 16:40 ` Mohammed Shafi Shajakhan
2016-05-10 16:40 ` Mohammed Shafi Shajakhan
2016-05-10 17:10 ` Ben Greear [this message]
2016-05-10 17:10 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573215F3.3050109@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mohammed@codeaurora.org \
--cc=mohammed@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.