From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Abhilash Kesavan <a.kesavan@samsung.com>
Cc: tomasz.figa@gmail.com, kgene.kim@samsung.com,
k.kozlowski@samsung.com, b.zolnierkie@samsung.com,
mturquette@baylibre.com, sboyd@codeaurora.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] clk: samsung: exynos7: Add clocks for atlas block
Date: Thu, 07 Jul 2016 12:26:54 +0200 [thread overview]
Message-ID: <577E2E6E.3040809@samsung.com> (raw)
In-Reply-To: <1467750561-13957-3-git-send-email-a.kesavan@samsung.com>
On 07/05/2016 10:29 PM, Abhilash Kesavan wrote:
> +static const struct samsung_pll_rate_table pll1450x_24mhz_tbl[] = {
> + /* rate, m, p, s */
> + PLL_35XX_RATE(2496000000, 208, 2, 0),
Please add U postfix to these constants to address compiler warning
as reported by kbuild-all@01.org:
>> drivers/clk/samsung/clk-exynos7.c:43:2: warning: this decimal constant is
unsigned only in ISO C90
PLL_35XX_RATE(2496000000, 208, 2, 0),
^~~~~~~~~~~~~
> +static void __init exynos7_clk_atlas_init(struct device_node *np)
> +{
> + void __iomem *reg_base;
> + struct samsung_clk_provider *ctx;
> +
> + reg_base = of_iomap(np, 0);
> + if (!reg_base) {
> + panic("%s: failed to map registers\n", __func__);
> + return;
> + }
> +
> + ctx = samsung_clk_init(np, reg_base, ATLAS_NR_CLK);
> + if (!ctx) {
> + panic("%s: unable to allocate ctx\n", __func__);
You can remove this panic() call, there is already one inside
samsung_clk_init().
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] clk: samsung: exynos7: Add clocks for atlas block
Date: Thu, 07 Jul 2016 12:26:54 +0200 [thread overview]
Message-ID: <577E2E6E.3040809@samsung.com> (raw)
In-Reply-To: <1467750561-13957-3-git-send-email-a.kesavan@samsung.com>
On 07/05/2016 10:29 PM, Abhilash Kesavan wrote:
> +static const struct samsung_pll_rate_table pll1450x_24mhz_tbl[] = {
> + /* rate, m, p, s */
> + PLL_35XX_RATE(2496000000, 208, 2, 0),
Please add U postfix to these constants to address compiler warning
as reported by kbuild-all at 01.org:
>> drivers/clk/samsung/clk-exynos7.c:43:2: warning: this decimal constant is
unsigned only in ISO C90
PLL_35XX_RATE(2496000000, 208, 2, 0),
^~~~~~~~~~~~~
> +static void __init exynos7_clk_atlas_init(struct device_node *np)
> +{
> + void __iomem *reg_base;
> + struct samsung_clk_provider *ctx;
> +
> + reg_base = of_iomap(np, 0);
> + if (!reg_base) {
> + panic("%s: failed to map registers\n", __func__);
> + return;
> + }
> +
> + ctx = samsung_clk_init(np, reg_base, ATLAS_NR_CLK);
> + if (!ctx) {
> + panic("%s: unable to allocate ctx\n", __func__);
You can remove this panic() call, there is already one inside
samsung_clk_init().
next prev parent reply other threads:[~2016-07-07 10:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 20:29 [PATCH v3 0/2] Add CPU clock support for Exynos7 Abhilash Kesavan
2016-07-05 20:29 ` Abhilash Kesavan
2016-07-05 20:29 ` [PATCH v3 1/2] clk: samsung: cpu: Prepare for addition for Exynos7 CPU clocks Abhilash Kesavan
2016-07-05 20:29 ` Abhilash Kesavan
2016-07-07 10:45 ` Sylwester Nawrocki
2016-07-07 10:45 ` Sylwester Nawrocki
2016-07-07 11:17 ` Bartlomiej Zolnierkiewicz
2016-07-07 11:17 ` Bartlomiej Zolnierkiewicz
2016-07-11 14:44 ` Abhilash Kesavan
2016-07-11 14:44 ` Abhilash Kesavan
2016-07-12 13:44 ` Bartlomiej Zolnierkiewicz
2016-07-12 13:44 ` Bartlomiej Zolnierkiewicz
2016-07-11 14:44 ` Abhilash Kesavan
2016-07-11 14:44 ` Abhilash Kesavan
2016-07-05 20:29 ` [PATCH v3 2/2] clk: samsung: exynos7: Add clocks for atlas block Abhilash Kesavan
2016-07-05 20:29 ` Abhilash Kesavan
2016-07-05 18:56 ` kbuild test robot
2016-07-05 18:56 ` kbuild test robot
2016-07-07 10:26 ` Sylwester Nawrocki [this message]
2016-07-07 10:26 ` Sylwester Nawrocki
2016-07-11 14:43 ` Abhilash Kesavan
2016-07-11 14:43 ` Abhilash Kesavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577E2E6E.3040809@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.kesavan@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.