From: Vladimir Murzin <vladimir.murzin@arm.com> To: Christoffer Dall <christoffer.dall@linaro.org> Cc: marc.zyngier@arm.com, andre.przywara@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/7] ARM: update MPIDR accessors macro Date: Tue, 6 Sep 2016 13:42:18 +0100 [thread overview] Message-ID: <57CEB9AA.6080109@arm.com> (raw) In-Reply-To: <20160905112909.GI26366@cbox> On 05/09/16 12:29, Christoffer Dall wrote: > The title of this patch is quite generic, especially the 'update'. > Perhaps say: > > "ARM: Change MPIDR_AFFINITY_LEVEL to ignore Aff3" > Fixed. > On Tue, Aug 16, 2016 at 11:46:55AM +0100, Vladimir Murzin wrote: >> vgic-v3 driver queries CPU affinity level up to Aff3, which is valid for arm64. >> However, for arm up to Aff2 levels are supported, so querying for 3rd level >> ends with upper bits of MPIDR are treated as valid affinity level which >> is not true. So, report zero for any affinity level above 2. >> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> >> --- >> arch/arm/include/asm/cputype.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/include/asm/cputype.h b/arch/arm/include/asm/cputype.h >> index 1ee94c7..96cef49 100644 >> --- a/arch/arm/include/asm/cputype.h >> +++ b/arch/arm/include/asm/cputype.h >> @@ -55,9 +55,10 @@ >> >> #define MPIDR_LEVEL_BITS 8 >> #define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1) >> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level) >> >> #define MPIDR_AFFINITY_LEVEL(mpidr, level) \ >> - ((mpidr >> (MPIDR_LEVEL_BITS * level)) & MPIDR_LEVEL_MASK) >> + ((level < 3) ? ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK) : 0) > > Instead of using a conditional here, you could just apply the > MPIDR_HWID_BITMASK to the mpidr argument instead. > Fixed. Thanks Vladimir >> >> #define ARM_CPU_IMP_ARM 0x41 >> #define ARM_CPU_IMP_INTEL 0x69 >> -- >> 1.7.9.5 >> > >
WARNING: multiple messages have this Message-ID (diff)
From: vladimir.murzin@arm.com (Vladimir Murzin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 4/7] ARM: update MPIDR accessors macro Date: Tue, 6 Sep 2016 13:42:18 +0100 [thread overview] Message-ID: <57CEB9AA.6080109@arm.com> (raw) In-Reply-To: <20160905112909.GI26366@cbox> On 05/09/16 12:29, Christoffer Dall wrote: > The title of this patch is quite generic, especially the 'update'. > Perhaps say: > > "ARM: Change MPIDR_AFFINITY_LEVEL to ignore Aff3" > Fixed. > On Tue, Aug 16, 2016 at 11:46:55AM +0100, Vladimir Murzin wrote: >> vgic-v3 driver queries CPU affinity level up to Aff3, which is valid for arm64. >> However, for arm up to Aff2 levels are supported, so querying for 3rd level >> ends with upper bits of MPIDR are treated as valid affinity level which >> is not true. So, report zero for any affinity level above 2. >> >> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com> >> --- >> arch/arm/include/asm/cputype.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/include/asm/cputype.h b/arch/arm/include/asm/cputype.h >> index 1ee94c7..96cef49 100644 >> --- a/arch/arm/include/asm/cputype.h >> +++ b/arch/arm/include/asm/cputype.h >> @@ -55,9 +55,10 @@ >> >> #define MPIDR_LEVEL_BITS 8 >> #define MPIDR_LEVEL_MASK ((1 << MPIDR_LEVEL_BITS) - 1) >> +#define MPIDR_LEVEL_SHIFT(level) (MPIDR_LEVEL_BITS * level) >> >> #define MPIDR_AFFINITY_LEVEL(mpidr, level) \ >> - ((mpidr >> (MPIDR_LEVEL_BITS * level)) & MPIDR_LEVEL_MASK) >> + ((level < 3) ? ((mpidr >> MPIDR_LEVEL_SHIFT(level)) & MPIDR_LEVEL_MASK) : 0) > > Instead of using a conditional here, you could just apply the > MPIDR_HWID_BITMASK to the mpidr argument instead. > Fixed. Thanks Vladimir >> >> #define ARM_CPU_IMP_ARM 0x41 >> #define ARM_CPU_IMP_INTEL 0x69 >> -- >> 1.7.9.5 >> > >
next prev parent reply other threads:[~2016-09-06 12:33 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-16 10:46 [PATCH v2 0/7] ARM: KVM: Support for vgic-v3 Vladimir Murzin 2016-08-16 10:46 ` Vladimir Murzin 2016-08-16 10:46 ` [PATCH v2 1/7] arm64: KVM: Move GIC accessors to arch_gicv3.h Vladimir Murzin 2016-08-16 10:46 ` Vladimir Murzin 2016-09-05 11:28 ` Christoffer Dall 2016-09-05 11:28 ` Christoffer Dall 2016-09-06 12:33 ` Vladimir Murzin 2016-09-06 12:33 ` Vladimir Murzin 2016-08-16 10:46 ` [PATCH v2 2/7] arm64: KVM: Move vgic-v3 save/restore to virt/kvm/arm/hyp Vladimir Murzin 2016-08-16 10:46 ` Vladimir Murzin 2016-08-16 10:46 ` [PATCH v2 3/7] KVM: arm: vgic-new: improve compatibility with 32-bit Vladimir Murzin 2016-08-16 10:46 ` Vladimir Murzin 2016-09-05 11:29 ` Christoffer Dall 2016-09-05 11:29 ` Christoffer Dall 2016-09-06 12:41 ` Vladimir Murzin 2016-09-06 12:41 ` Vladimir Murzin 2016-09-06 13:22 ` Christoffer Dall 2016-09-06 13:22 ` Christoffer Dall 2016-09-06 13:54 ` Vladimir Murzin 2016-09-06 13:54 ` Vladimir Murzin 2016-09-06 16:31 ` Christoffer Dall 2016-09-06 16:31 ` Christoffer Dall 2016-09-07 9:06 ` Vladimir Murzin 2016-09-07 9:06 ` Vladimir Murzin 2016-09-07 9:43 ` Christoffer Dall 2016-09-07 9:43 ` Christoffer Dall 2016-08-16 10:46 ` [PATCH v2 4/7] ARM: update MPIDR accessors macro Vladimir Murzin 2016-08-16 10:46 ` Vladimir Murzin 2016-09-05 11:29 ` Christoffer Dall 2016-09-05 11:29 ` Christoffer Dall 2016-09-06 12:42 ` Vladimir Murzin [this message] 2016-09-06 12:42 ` Vladimir Murzin 2016-08-16 10:46 ` [PATCH v2 5/7] ARM: move system register accessors to asm/cp15.h Vladimir Murzin 2016-08-16 10:46 ` Vladimir Murzin 2016-09-05 11:29 ` Christoffer Dall 2016-09-05 11:29 ` Christoffer Dall 2016-09-06 13:05 ` Vladimir Murzin 2016-09-06 13:05 ` Vladimir Murzin 2016-09-06 16:34 ` Christoffer Dall 2016-09-06 16:34 ` Christoffer Dall 2016-08-16 10:46 ` [PATCH v2 6/7] ARM: KVM: Get ready to use vgic-v3 Vladimir Murzin 2016-08-16 10:46 ` Vladimir Murzin 2016-09-05 11:29 ` Christoffer Dall 2016-09-05 11:29 ` Christoffer Dall 2016-09-06 13:12 ` Vladimir Murzin 2016-09-06 13:12 ` Vladimir Murzin 2016-09-06 16:49 ` Christoffer Dall 2016-09-06 16:49 ` Christoffer Dall 2016-08-16 10:46 ` [PATCH v2 7/7] ARM: KVM: Unlock vgic-v3 support Vladimir Murzin 2016-08-16 10:46 ` Vladimir Murzin 2016-09-05 11:29 ` Christoffer Dall 2016-09-05 11:29 ` Christoffer Dall 2016-09-06 13:08 ` Marc Zyngier 2016-09-06 13:08 ` Marc Zyngier 2016-09-06 13:18 ` Vladimir Murzin 2016-09-06 13:18 ` Vladimir Murzin 2016-09-06 16:52 ` Christoffer Dall 2016-09-06 16:52 ` Christoffer Dall 2016-09-06 13:23 ` Vladimir Murzin 2016-09-06 13:23 ` Vladimir Murzin 2016-09-06 16:55 ` Christoffer Dall 2016-09-06 16:55 ` Christoffer Dall 2016-09-07 10:48 ` Vladimir Murzin 2016-09-07 10:48 ` Vladimir Murzin 2016-09-07 12:58 ` Christoffer Dall 2016-09-07 12:58 ` Christoffer Dall 2016-09-07 14:20 ` Peter Maydell 2016-09-07 14:20 ` Peter Maydell 2016-09-07 14:47 ` Christoffer Dall 2016-09-07 14:47 ` Christoffer Dall 2016-09-05 11:28 ` [PATCH v2 0/7] ARM: KVM: Support for vgic-v3 Christoffer Dall 2016-09-05 11:28 ` Christoffer Dall 2016-09-06 12:32 ` Vladimir Murzin 2016-09-06 12:32 ` Vladimir Murzin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57CEB9AA.6080109@arm.com \ --to=vladimir.murzin@arm.com \ --cc=andre.przywara@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.