From: Hannes Reinecke <hare@suse.de>
To: Dmitry Monakhov <dmonakhov@openvz.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
martin.petersen@oracle.com
Subject: Re: [PATCH 9/9] bio-integrity: Restore original iterator on verify stage
Date: Wed, 5 Apr 2017 08:41:07 +0200 [thread overview]
Message-ID: <57ae8e22-9a7c-1fd9-82a2-96224786e1d2@suse.de> (raw)
In-Reply-To: <1491332201-26926-10-git-send-email-dmonakhov@openvz.org>
On 04/04/2017 08:56 PM, Dmitry Monakhov wrote:
> Currently ->verify_fn not woks at all because at the moment it is called
> bio->bi_iter.bi_size == 0, so we do not iterate integrity bvecs at all.
>
> In order to perform verification we need to know original data vector,
> with new bvec rewind API this is trivial.
>
> testcase: https://github.com/dmonakhov/xfstests/commit/3c6509eaa83b9c17cd0bc95d73fcdd76e1c54a85
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> block/bio-integrity.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: F. Imend�rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N�rnberg)
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Dmitry Monakhov <dmonakhov@openvz.org>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
martin.petersen@oracle.com
Subject: Re: [PATCH 9/9] bio-integrity: Restore original iterator on verify stage
Date: Wed, 5 Apr 2017 08:41:07 +0200 [thread overview]
Message-ID: <57ae8e22-9a7c-1fd9-82a2-96224786e1d2@suse.de> (raw)
In-Reply-To: <1491332201-26926-10-git-send-email-dmonakhov@openvz.org>
On 04/04/2017 08:56 PM, Dmitry Monakhov wrote:
> Currently ->verify_fn not woks at all because at the moment it is called
> bio->bi_iter.bi_size == 0, so we do not iterate integrity bvecs at all.
>
> In order to perform verification we need to know original data vector,
> with new bvec rewind API this is trivial.
>
> testcase: https://github.com/dmonakhov/xfstests/commit/3c6509eaa83b9c17cd0bc95d73fcdd76e1c54a85
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> block/bio-integrity.c | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-04-05 6:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 18:56 [PATCH 0/9] block: T10/DIF Fixes and cleanups v3 Dmitry Monakhov
2017-04-04 18:56 ` [PATCH 1/9] bio-integrity: Do not allocate integrity context for bio w/o data Dmitry Monakhov
2017-04-05 6:32 ` Hannes Reinecke
2017-04-05 6:32 ` Hannes Reinecke
2017-04-20 2:34 ` Martin K. Petersen
2017-04-04 18:56 ` [PATCH 2/9] bio-integrity: bio_trim should truncate integrity vector accordingly Dmitry Monakhov
2017-04-05 6:32 ` Hannes Reinecke
2017-04-05 6:32 ` Hannes Reinecke
2017-04-20 2:34 ` Martin K. Petersen
2017-04-04 18:56 ` [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed Dmitry Monakhov
2017-04-05 6:34 ` Hannes Reinecke
2017-04-05 6:34 ` Hannes Reinecke
2017-04-06 11:35 ` Christoph Hellwig
2017-04-20 2:36 ` Martin K. Petersen
2017-05-03 16:06 ` Dmitry Monakhov
2017-05-03 16:10 ` Martin K. Petersen
2017-04-04 18:56 ` [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2 Dmitry Monakhov
2017-04-05 6:36 ` Hannes Reinecke
2017-04-05 6:36 ` Hannes Reinecke
2017-04-06 11:36 ` Christoph Hellwig
2017-04-20 2:38 ` Martin K. Petersen
2017-04-04 18:56 ` [PATCH 5/9] bio-integrity: fold bio_integrity_enabled to bio_integrity_prep Dmitry Monakhov
2017-04-05 6:37 ` Hannes Reinecke
2017-04-05 6:37 ` Hannes Reinecke
2017-04-06 11:43 ` Christoph Hellwig
2017-04-20 2:40 ` Martin K. Petersen
2017-04-04 18:56 ` [PATCH 6/9] T10: Move opencoded contants to common header Dmitry Monakhov
2017-04-05 6:37 ` Hannes Reinecke
2017-04-05 6:37 ` Hannes Reinecke
2017-04-06 11:44 ` Christoph Hellwig
2017-04-20 2:44 ` Martin K. Petersen
2017-04-04 18:56 ` [PATCH 7/9] Guard bvec iteration logic v3 Dmitry Monakhov
2017-04-05 6:39 ` Hannes Reinecke
2017-04-05 6:39 ` Hannes Reinecke
2017-04-06 11:46 ` Christoph Hellwig
2017-04-04 18:56 ` [PATCH 8/9] bio: add bvec_iter rewind API Dmitry Monakhov
2017-04-05 6:39 ` Hannes Reinecke
2017-04-05 6:39 ` Hannes Reinecke
2017-04-06 11:49 ` Christoph Hellwig
2017-04-20 2:51 ` Martin K. Petersen
2017-04-04 18:56 ` [PATCH 9/9] bio-integrity: Restore original iterator on verify stage Dmitry Monakhov
2017-04-05 6:41 ` Hannes Reinecke [this message]
2017-04-05 6:41 ` Hannes Reinecke
2017-04-06 11:49 ` Christoph Hellwig
2017-05-02 7:31 ` [PATCH 0/9] block: T10/DIF Fixes and cleanups v3 Christoph Hellwig
2017-05-10 15:28 ` Dmitry Monakhov
2017-05-10 15:20 [PATCH 0/9] block: T10/DIF Fixes and cleanups v4 Dmitry Monakhov
2017-05-10 15:20 ` [PATCH 9/9] bio-integrity: Restore original iterator on verify stage Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57ae8e22-9a7c-1fd9-82a2-96224786e1d2@suse.de \
--to=hare@suse.de \
--cc=dmonakhov@openvz.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.