From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>, kernel test robot <lkp@intel.com>
Cc: linux-pm@vger.kernel.org, kbuild-all@lists.01.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
zhangqing@rock-chips.com, zyw@rock-chips.com,
jon.lin@rock-chips.com, sre@kernel.org, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
lee.jones@linaro.org, Chris Morgan <macromorgan@hotmail.com>,
Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [RESEND 3/4 v7] power: supply: Add charger driver for Rockchip RK817
Date: Mon, 1 Aug 2022 20:01:03 +0200 [thread overview]
Message-ID: <57faa0a7-301c-c60c-6831-00a351ed3ea5@linaro.org> (raw)
In-Reply-To: <20220729162828.GB102@wintermute.localdomain>
On 29/07/2022 18:28, Chris Morgan wrote:
> On Sun, Jul 24, 2022 at 10:58:00PM +0800, kernel test robot wrote:
>> Hi Chris,
>>
>> Thank you for the patch! Perhaps something to improve:
>
> I'm afraid I'm not sure the best way to fix this. The only thing I can
> think of is for now the driver should only be for systems with a
> Rockchip RK817 PMIC (to my knowledge only ARM based systems from
> Rockchip),
Why? We want to compile test everything everywhere,
> but it looks like the arch was set as parisc.
The arch itself does not matter unless the actual warning is specific to it.
> Even still,
> as long as some of the functions ahead of it don't error out each
> of those variables should be used. Is there a way to confirm these
> warnings?
Just compile and see by yourself. The error should be visible on
multiple archs. If not, then use parisc. Ubuntu provides most of cross
compilers so it's extra easy to use. The ones not provided by Ubuntu are
also here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>, kernel test robot <lkp@intel.com>
Cc: linux-pm@vger.kernel.org, kbuild-all@lists.01.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
zhangqing@rock-chips.com, zyw@rock-chips.com,
jon.lin@rock-chips.com, sre@kernel.org, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
lee.jones@linaro.org, Chris Morgan <macromorgan@hotmail.com>,
Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [RESEND 3/4 v7] power: supply: Add charger driver for Rockchip RK817
Date: Mon, 1 Aug 2022 20:01:03 +0200 [thread overview]
Message-ID: <57faa0a7-301c-c60c-6831-00a351ed3ea5@linaro.org> (raw)
In-Reply-To: <20220729162828.GB102@wintermute.localdomain>
On 29/07/2022 18:28, Chris Morgan wrote:
> On Sun, Jul 24, 2022 at 10:58:00PM +0800, kernel test robot wrote:
>> Hi Chris,
>>
>> Thank you for the patch! Perhaps something to improve:
>
> I'm afraid I'm not sure the best way to fix this. The only thing I can
> think of is for now the driver should only be for systems with a
> Rockchip RK817 PMIC (to my knowledge only ARM based systems from
> Rockchip),
Why? We want to compile test everything everywhere,
> but it looks like the arch was set as parisc.
The arch itself does not matter unless the actual warning is specific to it.
> Even still,
> as long as some of the functions ahead of it don't error out each
> of those variables should be used. Is there a way to confirm these
> warnings?
Just compile and see by yourself. The error should be visible on
multiple archs. If not, then use parisc. Ubuntu provides most of cross
compilers so it's extra easy to use. The ones not provided by Ubuntu are
also here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chris Morgan <macroalpha82@gmail.com>, kernel test robot <lkp@intel.com>
Cc: linux-pm@vger.kernel.org, kbuild-all@lists.01.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
zhangqing@rock-chips.com, zyw@rock-chips.com,
jon.lin@rock-chips.com, sre@kernel.org, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
lee.jones@linaro.org, Chris Morgan <macromorgan@hotmail.com>,
Maya Matuszczyk <maccraft123mc@gmail.com>
Subject: Re: [RESEND 3/4 v7] power: supply: Add charger driver for Rockchip RK817
Date: Mon, 1 Aug 2022 20:01:03 +0200 [thread overview]
Message-ID: <57faa0a7-301c-c60c-6831-00a351ed3ea5@linaro.org> (raw)
In-Reply-To: <20220729162828.GB102@wintermute.localdomain>
On 29/07/2022 18:28, Chris Morgan wrote:
> On Sun, Jul 24, 2022 at 10:58:00PM +0800, kernel test robot wrote:
>> Hi Chris,
>>
>> Thank you for the patch! Perhaps something to improve:
>
> I'm afraid I'm not sure the best way to fix this. The only thing I can
> think of is for now the driver should only be for systems with a
> Rockchip RK817 PMIC (to my knowledge only ARM based systems from
> Rockchip),
Why? We want to compile test everything everywhere,
> but it looks like the arch was set as parisc.
The arch itself does not matter unless the actual warning is specific to it.
> Even still,
> as long as some of the functions ahead of it don't error out each
> of those variables should be used. Is there a way to confirm these
> warnings?
Just compile and see by yourself. The error should be visible on
multiple archs. If not, then use parisc. Ubuntu provides most of cross
compilers so it's extra easy to use. The ones not provided by Ubuntu are
also here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: kbuild-all@lists.01.org
Subject: Re: [RESEND 3/4 v7] power: supply: Add charger driver for Rockchip RK817
Date: Mon, 01 Aug 2022 20:01:03 +0200 [thread overview]
Message-ID: <57faa0a7-301c-c60c-6831-00a351ed3ea5@linaro.org> (raw)
In-Reply-To: <20220729162828.GB102@wintermute.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]
On 29/07/2022 18:28, Chris Morgan wrote:
> On Sun, Jul 24, 2022 at 10:58:00PM +0800, kernel test robot wrote:
>> Hi Chris,
>>
>> Thank you for the patch! Perhaps something to improve:
>
> I'm afraid I'm not sure the best way to fix this. The only thing I can
> think of is for now the driver should only be for systems with a
> Rockchip RK817 PMIC (to my knowledge only ARM based systems from
> Rockchip),
Why? We want to compile test everything everywhere,
> but it looks like the arch was set as parisc.
The arch itself does not matter unless the actual warning is specific to it.
> Even still,
> as long as some of the functions ahead of it don't error out each
> of those variables should be used. Is there a way to confirm these
> warnings?
Just compile and see by yourself. The error should be visible on
multiple archs. If not, then use parisc. Ubuntu provides most of cross
compilers so it's extra easy to use. The ones not provided by Ubuntu are
also here:
https://mirrors.edge.kernel.org/pub/tools/crosstool/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-01 18:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 16:17 [RESEND 0/4 v7] power: supply: Add Support for RK817 Charger Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-21 16:17 ` [RESEND 1/4 v7] dt-bindings: Add Rockchip rk817 battery charger support Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-21 16:17 ` [RESEND 2/4 v7] mfd: " Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-21 16:17 ` [RESEND 3/4 v7] power: supply: Add charger driver for Rockchip RK817 Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-24 14:58 ` kernel test robot
2022-07-24 14:58 ` kernel test robot
2022-07-24 14:58 ` kernel test robot
2022-07-29 16:28 ` Chris Morgan
2022-07-29 16:28 ` Chris Morgan
2022-07-29 16:28 ` Chris Morgan
2022-07-29 16:28 ` Chris Morgan
2022-08-01 18:01 ` Krzysztof Kozlowski [this message]
2022-08-01 18:01 ` Krzysztof Kozlowski
2022-08-01 18:01 ` Krzysztof Kozlowski
2022-08-01 18:01 ` Krzysztof Kozlowski
2022-07-21 16:17 ` [RESEND 4/4 v7] arm64: dts: rockchip: add rk817 chg to Odroid Go Advance Chris Morgan
2022-07-21 16:17 ` Chris Morgan
2022-07-21 16:17 ` Chris Morgan
-- strict thread matches above, loose matches on Subject: below --
2022-05-20 18:30 [RESEND 0/4 v7] power: supply: Add Support for RK817 Charger Chris Morgan
2022-05-20 18:30 ` [RESEND 3/4 v7] power: supply: Add charger driver for Rockchip RK817 Chris Morgan
2022-05-20 18:30 ` Chris Morgan
2022-05-20 18:30 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57faa0a7-301c-c60c-6831-00a351ed3ea5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jon.lin@rock-chips.com \
--cc=kbuild-all@lists.01.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lkp@intel.com \
--cc=maccraft123mc@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.