All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hiep Cao Minh <cm-hiep@jinso.co.jp>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: broonie@kernel.org, geert+renesas@glider.be,
	linux-spi@vger.kernel.org, kuninori.morimoto.gx@renesas.com,
	yoshihiro.shimoda.uh@renesas.com, ryusuke.sakato.bx@renesas.com,
	linux-renesas-soc@vger.kernel.org, nv-dung@jinso.co.jp,
	h-inayoshi@jinso.co.jp
Subject: Re: [PATCH 1/1] ARM: spi supports 32bytes buffer for DUAL and QUAD
Date: Mon, 07 Nov 2016 09:27:44 +0900	[thread overview]
Message-ID: <581FCA80.7000007@jinso.co.jp> (raw)
In-Reply-To: <20161105073239.GA30888@bigcity.dyn.berto.se>

Hi Niklas,

Thanks for your comment.

On 11/05/2016 04:32 PM, Niklas S�derlund wrote:
> Hi Cao,
>
> On 2016-11-04 17:38:54 +0900, Cao Minh Hiep wrote:
>> From: Hiep Cao Minh <cm-hiep@jinso.co.jp>
>>
>> This patch supports 32bytes of buffer for DUAL and QUAD in QSPI by
>> Using Transmit/Receive Buffer Data Triggering Number.
>> In order to improve the DUAL and QUAD's performance of SPI
>> while transferring data in PIO mode, it sends/receives each 32bytes
>> data instead of each byte data as current situation.
>>
>> Signed-off-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
>> ---
>>   drivers/spi/spi-rspi.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++---
>>   1 file changed, 49 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
>> index a816f07..fb12bc5 100644
>> --- a/drivers/spi/spi-rspi.c
>> +++ b/drivers/spi/spi-rspi.c
>> @@ -413,7 +413,7 @@ static unsigned int qspi_set_send_trigger(struct rspi_data *rspi,
>>   	return n;
>>   }
>>   
>> -static void qspi_set_receive_trigger(struct rspi_data *rspi, unsigned int len)
>> +static int qspi_set_receive_trigger(struct rspi_data *rspi, unsigned int len)
>>   {
>>   	unsigned int n;
>>   
>> @@ -428,6 +428,7 @@ static void qspi_set_receive_trigger(struct rspi_data *rspi, unsigned int len)
>>   		qspi_update(rspi, SPBFCR_RXTRG_MASK,
>>   			     SPBFCR_RXTRG_1B, QSPI_SPBFCR);
>>   	}
>> +	return n;
>>   }
>>   
>>   #define set_config_register(spi, n) spi->ops->set_config_register(spi, n)
>> @@ -514,6 +515,51 @@ static int rspi_pio_transfer(struct rspi_data *rspi, const u8 *tx, u8 *rx,
>>   	return 0;
>>   }
>>   
>> +static int rspi_pio_transfer_in_or_our(struct rspi_data *rspi, const u8 *tx,
>> +				       u8 *rx, unsigned int n)
> Nitpicking, s/rspi_pio_transfer_in_or_our/rspi_pio_transfer_in_or_out/
> or am I missing something?
You're right!. It should be "rspi_pio_transfer_in_or_out"
I'll update it in an other patch.

Thanks.
Jinzai Solution Inc,
Hiep.

WARNING: multiple messages have this Message-ID (diff)
From: Hiep Cao Minh <cm-hiep@jinso.co.jp>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: broonie@kernel.org, geert+renesas@glider.be,
	linux-spi@vger.kernel.org, kuninori.morimoto.gx@renesas.com,
	yoshihiro.shimoda.uh@renesas.com, ryusuke.sakato.bx@renesas.com,
	linux-renesas-soc@vger.kernel.org, nv-dung@jinso.co.jp,
	h-inayoshi@jinso.co.jp
Subject: Re: [PATCH 1/1] ARM: spi supports 32bytes buffer for DUAL and QUAD
Date: Mon, 07 Nov 2016 09:27:44 +0900	[thread overview]
Message-ID: <581FCA80.7000007@jinso.co.jp> (raw)
In-Reply-To: <20161105073239.GA30888@bigcity.dyn.berto.se>

Hi Niklas,

Thanks for your comment.

On 11/05/2016 04:32 PM, Niklas Söderlund wrote:
> Hi Cao,
>
> On 2016-11-04 17:38:54 +0900, Cao Minh Hiep wrote:
>> From: Hiep Cao Minh <cm-hiep@jinso.co.jp>
>>
>> This patch supports 32bytes of buffer for DUAL and QUAD in QSPI by
>> Using Transmit/Receive Buffer Data Triggering Number.
>> In order to improve the DUAL and QUAD's performance of SPI
>> while transferring data in PIO mode, it sends/receives each 32bytes
>> data instead of each byte data as current situation.
>>
>> Signed-off-by: Hiep Cao Minh <cm-hiep@jinso.co.jp>
>> ---
>>   drivers/spi/spi-rspi.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++---
>>   1 file changed, 49 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c
>> index a816f07..fb12bc5 100644
>> --- a/drivers/spi/spi-rspi.c
>> +++ b/drivers/spi/spi-rspi.c
>> @@ -413,7 +413,7 @@ static unsigned int qspi_set_send_trigger(struct rspi_data *rspi,
>>   	return n;
>>   }
>>   
>> -static void qspi_set_receive_trigger(struct rspi_data *rspi, unsigned int len)
>> +static int qspi_set_receive_trigger(struct rspi_data *rspi, unsigned int len)
>>   {
>>   	unsigned int n;
>>   
>> @@ -428,6 +428,7 @@ static void qspi_set_receive_trigger(struct rspi_data *rspi, unsigned int len)
>>   		qspi_update(rspi, SPBFCR_RXTRG_MASK,
>>   			     SPBFCR_RXTRG_1B, QSPI_SPBFCR);
>>   	}
>> +	return n;
>>   }
>>   
>>   #define set_config_register(spi, n) spi->ops->set_config_register(spi, n)
>> @@ -514,6 +515,51 @@ static int rspi_pio_transfer(struct rspi_data *rspi, const u8 *tx, u8 *rx,
>>   	return 0;
>>   }
>>   
>> +static int rspi_pio_transfer_in_or_our(struct rspi_data *rspi, const u8 *tx,
>> +				       u8 *rx, unsigned int n)
> Nitpicking, s/rspi_pio_transfer_in_or_our/rspi_pio_transfer_in_or_out/
> or am I missing something?
You're right!. It should be "rspi_pio_transfer_in_or_out"
I'll update it in an other patch.

Thanks.
Jinzai Solution Inc,
Hiep.

  reply	other threads:[~2016-11-07  0:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04  8:38 [PATCH 0/1] ARM: spi supports 32bytes buffer for DUAL and QUAD Cao Minh Hiep
2016-11-04  8:38 ` [PATCH 1/1] " Cao Minh Hiep
2016-11-04  8:38   ` Cao Minh Hiep
2016-11-04 17:06   ` Mark Brown
2016-11-04 17:23   ` Applied "spi: rspi: supports 32bytes buffer for DUAL and QUAD" to the spi tree Mark Brown
2016-11-07  0:20     ` Hiep Cao Minh
2016-11-07  0:20       ` Hiep Cao Minh
2016-11-05  7:32   ` [PATCH 1/1] ARM: spi supports 32bytes buffer for DUAL and QUAD Niklas Söderlund
2016-11-05  7:32     ` Niklas Söderlund
2016-11-07  0:27     ` Hiep Cao Minh [this message]
2016-11-07  0:27       ` Hiep Cao Minh
2016-11-04 15:49 ` [PATCH 0/1] " Mark Brown
2016-11-04 15:49   ` Mark Brown
2016-11-07  0:17   ` Hiep Cao Minh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=581FCA80.7000007@jinso.co.jp \
    --to=cm-hiep@jinso.co.jp \
    --cc=broonie@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=h-inayoshi@jinso.co.jp \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=nv-dung@jinso.co.jp \
    --cc=ryusuke.sakato.bx@renesas.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.