From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Zhang Rui <rui.zhang@intel.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
"Len Brown" <lenb@kernel.org>,
"Vishal Kulkarni" <vishal@chelsio.com>,
"David S . Miller" <davem@davemloft.net>,
"Jiri Pirko" <jiri@mellanox.com>,
"Ido Schimmel" <idosch@mellanox.com>,
"Johannes Berg" <johannes.berg@intel.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Luca Coelho" <luciano.coelho@intel.com>,
"Intel Linux Wireless" <linuxwifi@intel.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Peter Kaestle" <peter@piie.net>,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Amit Kucheria" <amit.kucheria@verdurent.com>,
"Support Opensource" <support.opensource@diasemi.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Heiko Stuebner" <heiko@sntech.de>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang7@gmail.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Allison Randal" <allison@lohutok.net>,
"Enrico Weigelt" <info@metux.net>,
"Gayatri Kammela" <gayatri.kammela@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
kernel@collabora.com
Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices
Date: Fri, 3 Jul 2020 08:38:48 +0200 [thread overview]
Message-ID: <58265668-fc6d-729a-c126-0c73c2ea853b@linaro.org> (raw)
In-Reply-To: <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com>
On 03/07/2020 03:49, Zhang Rui wrote:
> On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote:
[ ... ]
>>> So the reason is that ->get_temp() is called while the mutex is
>>> held and
>>> thermal_zone_device_is_enabled() wants to take the same mutex.
>>
>> Yes, that's correct.
>>
>>> Is adding a comment to thermal_zone_device_is_enabled() to never
>>> call
>>> it while the mutex is held and adding another version of it which
>>> does
>>> not take the mutex ok?
>>
>> The thermal_zone_device_is_enabled() is only used in two places, acpi
>> and this imx driver, and given:
>>
>> 1. as soon as the mutex is released, there is no guarantee the
>> thermal
>> zone won't be changed right after, the lock is pointless, thus the
>> information also.
>>
>> 2. from a design point of view, I don't see why a driver should know
>> if
>> a thermal zone is disabled or not
>>
>> It would make sense to end with this function and do not give the
>> different drivers an opportunity to access this information.
>
> I agree.
>>
>> Why not add change_mode for the acpi in order to enable or disable
>> the
>> events
>
> thermal_zone_device_is_enabled() is invoked in acpi thermal driver
> because we only want to do thermal_zone_device_update() when the acpi
> thermal zone is enabled.
>
> As thermal_zone_device_update() can handle a disabled thermal zone now,
> we can just remove the check.
Ah yes, good point!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Zhang Rui <rui.zhang@intel.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Vishal Kulkarni <vishal@chelsio.com>,
"David S . Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
Kalle Valo <kvalo@codeaurora.org>, Peter Kaestle <peter@piie.net>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Sebastian Reichel <sre@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Support Opensource <support.opensource@diasemi.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices
Date: Fri, 3 Jul 2020 08:38:48 +0200 [thread overview]
Message-ID: <58265668-fc6d-729a-c126-0c73c2ea853b@linaro.org> (raw)
In-Reply-To: <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com>
On 03/07/2020 03:49, Zhang Rui wrote:
> On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote:
[ ... ]
>>> So the reason is that ->get_temp() is called while the mutex is
>>> held and
>>> thermal_zone_device_is_enabled() wants to take the same mutex.
>>
>> Yes, that's correct.
>>
>>> Is adding a comment to thermal_zone_device_is_enabled() to never
>>> call
>>> it while the mutex is held and adding another version of it which
>>> does
>>> not take the mutex ok?
>>
>> The thermal_zone_device_is_enabled() is only used in two places, acpi
>> and this imx driver, and given:
>>
>> 1. as soon as the mutex is released, there is no guarantee the
>> thermal
>> zone won't be changed right after, the lock is pointless, thus the
>> information also.
>>
>> 2. from a design point of view, I don't see why a driver should know
>> if
>> a thermal zone is disabled or not
>>
>> It would make sense to end with this function and do not give the
>> different drivers an opportunity to access this information.
>
> I agree.
>>
>> Why not add change_mode for the acpi in order to enable or disable
>> the
>> events
>
> thermal_zone_device_is_enabled() is invoked in acpi thermal driver
> because we only want to do thermal_zone_device_update() when the acpi
> thermal zone is enabled.
>
> As thermal_zone_device_update() can handle a disabled thermal zone now,
> we can just remove the check.
Ah yes, good point!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Zhang Rui <rui.zhang@intel.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org
Cc: "Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
"Vishal Kulkarni" <vishal@chelsio.com>,
"Luca Coelho" <luciano.coelho@intel.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
kernel@collabora.com, "Fabio Estevam" <festevam@gmail.com>,
"Amit Kucheria" <amit.kucheria@verdurent.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Allison Randal" <allison@lohutok.net>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Darren Hart" <dvhart@infradead.org>,
"Gayatri Kammela" <gayatri.kammela@intel.com>,
"Len Brown" <lenb@kernel.org>,
"Johannes Berg" <johannes.berg@intel.com>,
"Intel Linux Wireless" <linuxwifi@intel.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Ido Schimmel" <idosch@mellanox.com>,
"Baolin Wang" <baolin.wang7@gmail.com>,
"Jiri Pirko" <jiri@mellanox.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Support Opensource" <support.opensource@diasemi.com>,
"Enrico Weigelt" <info@metux.net>,
"Peter Kaestle" <peter@piie.net>,
"Sebastian Reichel" <sre@kernel.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Shawn Guo" <shawnguo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Andy Shevchenko" <andy@infradead.org>
Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices
Date: Fri, 3 Jul 2020 08:38:48 +0200 [thread overview]
Message-ID: <58265668-fc6d-729a-c126-0c73c2ea853b@linaro.org> (raw)
In-Reply-To: <44c622dd7de8c7bf143c4435c0edd1b98d09a3d6.camel@intel.com>
On 03/07/2020 03:49, Zhang Rui wrote:
> On Thu, 2020-07-02 at 19:49 +0200, Daniel Lezcano wrote:
[ ... ]
>>> So the reason is that ->get_temp() is called while the mutex is
>>> held and
>>> thermal_zone_device_is_enabled() wants to take the same mutex.
>>
>> Yes, that's correct.
>>
>>> Is adding a comment to thermal_zone_device_is_enabled() to never
>>> call
>>> it while the mutex is held and adding another version of it which
>>> does
>>> not take the mutex ok?
>>
>> The thermal_zone_device_is_enabled() is only used in two places, acpi
>> and this imx driver, and given:
>>
>> 1. as soon as the mutex is released, there is no guarantee the
>> thermal
>> zone won't be changed right after, the lock is pointless, thus the
>> information also.
>>
>> 2. from a design point of view, I don't see why a driver should know
>> if
>> a thermal zone is disabled or not
>>
>> It would make sense to end with this function and do not give the
>> different drivers an opportunity to access this information.
>
> I agree.
>>
>> Why not add change_mode for the acpi in order to enable or disable
>> the
>> events
>
> thermal_zone_device_is_enabled() is invoked in acpi thermal driver
> because we only want to do thermal_zone_device_update() when the acpi
> thermal zone is enabled.
>
> As thermal_zone_device_update() can handle a disabled thermal zone now,
> we can just remove the check.
Ah yes, good point!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-03 6:38 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 12:29 [PATCH v7 00/11] Stop monitoring disabled devices Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` [PATCH v7 01/11] acpi: thermal: Fix error handling in the register function Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` [PATCH v7 02/11] thermal: Store thermal mode in a dedicated enum Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` [PATCH v7 03/11] thermal: Add current mode to thermal zone device Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` [PATCH v7 04/11] thermal: Store device mode in struct thermal_zone_device Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` [PATCH v7 05/11] thermal: remove get_mode() operation of drivers Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` [PATCH v7 06/11] thermal: Add mode helpers Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` [PATCH v7 07/11] thermal: Use mode helpers in drivers Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:45 ` Amit Kucheria
2020-06-29 12:45 ` Amit Kucheria
2020-06-29 12:45 ` Amit Kucheria
2020-06-29 14:14 ` Bartlomiej Zolnierkiewicz
2020-06-29 14:14 ` Bartlomiej Zolnierkiewicz
2020-06-29 14:14 ` Bartlomiej Zolnierkiewicz
2020-06-29 12:29 ` [PATCH v7 08/11] thermal: Explicitly enable non-changing thermal zone devices Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 14:15 ` Bartlomiej Zolnierkiewicz
2020-06-29 14:15 ` Bartlomiej Zolnierkiewicz
2020-06-29 14:15 ` Bartlomiej Zolnierkiewicz
2020-06-30 5:07 ` Amit Kucheria
2020-06-30 5:07 ` Amit Kucheria
2020-06-30 5:07 ` Amit Kucheria
2020-06-29 12:29 ` [PATCH v7 09/11] thermal: core: Stop polling DISABLED thermal devices Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:46 ` Amit Kucheria
2020-06-29 12:46 ` Amit Kucheria
2020-06-29 12:46 ` Amit Kucheria
2020-06-29 12:29 ` [PATCH v7 10/11] thermal: Simplify or eliminate unnecessary set_mode() methods Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:47 ` Amit Kucheria
2020-06-29 12:47 ` Amit Kucheria
2020-06-29 12:47 ` Amit Kucheria
2020-06-29 12:29 ` [PATCH v7 11/11] thermal: Rename set_mode() to change_mode() Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:29 ` Andrzej Pietrasiewicz
2020-06-29 12:48 ` Amit Kucheria
2020-06-29 12:48 ` Amit Kucheria
2020-06-29 12:48 ` Amit Kucheria
2020-06-30 12:57 ` [PATCH v7 00/11] Stop monitoring disabled devices Daniel Lezcano
2020-06-30 12:57 ` Daniel Lezcano
2020-06-30 12:57 ` Daniel Lezcano
2020-06-30 13:43 ` Andrzej Pietrasiewicz
2020-06-30 13:43 ` Andrzej Pietrasiewicz
2020-06-30 13:43 ` Andrzej Pietrasiewicz
2020-06-30 14:53 ` Daniel Lezcano
2020-06-30 14:53 ` Daniel Lezcano
2020-06-30 14:53 ` Daniel Lezcano
2020-06-30 15:29 ` Andrzej Pietrasiewicz
2020-06-30 15:29 ` Andrzej Pietrasiewicz
2020-06-30 15:29 ` Andrzej Pietrasiewicz
2020-06-30 15:53 ` Daniel Lezcano
2020-06-30 15:53 ` Daniel Lezcano
2020-06-30 15:53 ` Daniel Lezcano
2020-06-30 16:56 ` Andrzej Pietrasiewicz
2020-06-30 16:56 ` Andrzej Pietrasiewicz
2020-06-30 16:56 ` Andrzej Pietrasiewicz
2020-06-30 18:33 ` Daniel Lezcano
2020-06-30 18:33 ` Daniel Lezcano
2020-06-30 18:33 ` Daniel Lezcano
2020-07-01 10:23 ` Andrzej Pietrasiewicz
2020-07-01 10:23 ` Andrzej Pietrasiewicz
2020-07-01 10:23 ` Andrzej Pietrasiewicz
2020-07-01 14:25 ` Daniel Lezcano
2020-07-01 14:25 ` Daniel Lezcano
2020-07-01 14:25 ` Daniel Lezcano
2020-07-02 13:47 ` Daniel Lezcano
2020-07-02 13:47 ` Daniel Lezcano
2020-07-02 13:47 ` Daniel Lezcano
2020-07-02 13:53 ` Andrzej Pietrasiewicz
2020-07-02 13:53 ` Andrzej Pietrasiewicz
2020-07-02 13:53 ` Andrzej Pietrasiewicz
2020-07-02 14:58 ` Daniel Lezcano
2020-07-02 14:58 ` Daniel Lezcano
2020-07-02 14:58 ` Daniel Lezcano
2020-07-02 17:01 ` Daniel Lezcano
2020-07-02 17:01 ` Daniel Lezcano
2020-07-02 17:01 ` Daniel Lezcano
2020-07-02 17:19 ` Andrzej Pietrasiewicz
2020-07-02 17:19 ` Andrzej Pietrasiewicz
2020-07-02 17:19 ` Andrzej Pietrasiewicz
2020-07-02 17:49 ` Daniel Lezcano
2020-07-02 17:49 ` Daniel Lezcano
2020-07-02 17:49 ` Daniel Lezcano
2020-07-02 17:52 ` Daniel Lezcano
2020-07-02 17:52 ` Daniel Lezcano
2020-07-02 17:52 ` Daniel Lezcano
2020-07-03 1:49 ` Zhang Rui
2020-07-03 1:49 ` Zhang Rui
2020-07-03 1:49 ` Zhang Rui
2020-07-03 6:38 ` Daniel Lezcano [this message]
2020-07-03 6:38 ` Daniel Lezcano
2020-07-03 6:38 ` Daniel Lezcano
2020-07-03 10:45 ` Andrzej Pietrasiewicz
2020-07-03 10:45 ` Andrzej Pietrasiewicz
2020-07-03 10:45 ` Andrzej Pietrasiewicz
2020-07-03 11:05 ` Daniel Lezcano
2020-07-03 11:05 ` Daniel Lezcano
2020-07-03 11:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58265668-fc6d-729a-c126-0c73c2ea853b@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=allison@lohutok.net \
--cc=amit.kucheria@verdurent.com \
--cc=andrzej.p@collabora.com \
--cc=andy@infradead.org \
--cc=b.zolnierkie@samsung.com \
--cc=baolin.wang7@gmail.com \
--cc=davem@davemloft.net \
--cc=dvhart@infradead.org \
--cc=emmanuel.grumbach@intel.com \
--cc=festevam@gmail.com \
--cc=gayatri.kammela@intel.com \
--cc=heiko@sntech.de \
--cc=idosch@mellanox.com \
--cc=info@metux.net \
--cc=jiri@mellanox.com \
--cc=johannes.berg@intel.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=kvalo@codeaurora.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=orsonzhai@gmail.com \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tglx@linutronix.de \
--cc=vishal@chelsio.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.