From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: <linux-gpio@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: Read irq trigger type from DT
Date: Thu, 5 Dec 2019 17:01:14 +0200 [thread overview]
Message-ID: <5837a37d-479d-5c33-45b5-c1b32b0cdc52@ti.com> (raw)
In-Reply-To: <20191205144508.31339-1-vigneshr@ti.com>
On 05/12/2019 16:45, Vignesh Raghavendra wrote:
> Instead of hardcoding irq trigger type to IRQF_TRIGGER_LOW, let's
> respect settings specified in DT. Default to IRQF_TRIGGER_LOW,
> if DT does not provide a flag.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/gpio/gpio-pca953x.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6652bee01966..e0e2a77ef6ad 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -744,6 +744,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
> struct irq_chip *irq_chip = &chip->irq_chip;
> DECLARE_BITMAP(reg_direction, MAX_LINE);
> DECLARE_BITMAP(irq_stat, MAX_LINE);
> + unsigned long irqflags;
> int ret;
>
> if (!client->irq)
> @@ -768,10 +769,14 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
> bitmap_and(chip->irq_stat, irq_stat, reg_direction, chip->gpio_chip.ngpio);
> mutex_init(&chip->irq_lock);
>
> + irqflags = irq_get_trigger_type(client->irq);
> + if (irqflags == IRQF_TRIGGER_NONE)
> + irqflags = IRQF_TRIGGER_LOW;
I think you can just drop IRQF_TRIGGER_LOW:
- for paltform code it will be set from resources in platform_get_irq_optional()
- for DT code it will be set in __setup_irq()
> + irqflags |= IRQF_ONESHOT | IRQF_SHARED;
> +
> ret = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, pca953x_irq_handler,
> - IRQF_TRIGGER_LOW | IRQF_ONESHOT |
> - IRQF_SHARED,
> + irqflags,
> dev_name(&client->dev), chip);
> if (ret) {
> dev_err(&client->dev, "failed to request irq %d\n",
>
--
Best regards,
grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: pca953x: Read irq trigger type from DT
Date: Thu, 5 Dec 2019 17:01:14 +0200 [thread overview]
Message-ID: <5837a37d-479d-5c33-45b5-c1b32b0cdc52@ti.com> (raw)
In-Reply-To: <20191205144508.31339-1-vigneshr@ti.com>
On 05/12/2019 16:45, Vignesh Raghavendra wrote:
> Instead of hardcoding irq trigger type to IRQF_TRIGGER_LOW, let's
> respect settings specified in DT. Default to IRQF_TRIGGER_LOW,
> if DT does not provide a flag.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/gpio/gpio-pca953x.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6652bee01966..e0e2a77ef6ad 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -744,6 +744,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
> struct irq_chip *irq_chip = &chip->irq_chip;
> DECLARE_BITMAP(reg_direction, MAX_LINE);
> DECLARE_BITMAP(irq_stat, MAX_LINE);
> + unsigned long irqflags;
> int ret;
>
> if (!client->irq)
> @@ -768,10 +769,14 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
> bitmap_and(chip->irq_stat, irq_stat, reg_direction, chip->gpio_chip.ngpio);
> mutex_init(&chip->irq_lock);
>
> + irqflags = irq_get_trigger_type(client->irq);
> + if (irqflags == IRQF_TRIGGER_NONE)
> + irqflags = IRQF_TRIGGER_LOW;
I think you can just drop IRQF_TRIGGER_LOW:
- for paltform code it will be set from resources in platform_get_irq_optional()
- for DT code it will be set in __setup_irq()
> + irqflags |= IRQF_ONESHOT | IRQF_SHARED;
> +
> ret = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, pca953x_irq_handler,
> - IRQF_TRIGGER_LOW | IRQF_ONESHOT |
> - IRQF_SHARED,
> + irqflags,
> dev_name(&client->dev), chip);
> if (ret) {
> dev_err(&client->dev, "failed to request irq %d\n",
>
--
Best regards,
grygorii
next prev parent reply other threads:[~2019-12-05 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 14:45 [PATCH] gpio: pca953x: Read irq trigger type from DT Vignesh Raghavendra
2019-12-05 14:45 ` Vignesh Raghavendra
2019-12-05 15:01 ` Grygorii Strashko [this message]
2019-12-05 15:01 ` Grygorii Strashko
2019-12-09 5:15 ` Vignesh Raghavendra
2019-12-09 5:15 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5837a37d-479d-5c33-45b5-c1b32b0cdc52@ti.com \
--to=grygorii.strashko@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.