From: Murali Karicheri <m-karicheri2@ti.com> To: Rob Herring <robh@kernel.org> Cc: <netdev@vger.kernel.org>, <linux-omap@vger.kernel.org>, <grygorii.strashko@ti.com>, <mugunthanvnm@ti.com>, <linux-kernel@vger.kernel.org>, <arnd@arndb.de>, <davem@davemloft.net>, <devicetree@vger.kernel.org>, <mark.rutland@arm.com> Subject: Re: [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap Date: Thu, 5 Jan 2017 15:42:38 -0500 [thread overview] Message-ID: <586EAFBE.1000500@ti.com> (raw) In-Reply-To: <20161222212409.arhurpl4bpqf2yw6@rob-hp-laptop> Rob, On 12/22/2016 04:24 PM, Rob Herring wrote: > On Tue, Dec 20, 2016 at 05:09:44PM -0500, Murali Karicheri wrote: >> From: WingMan Kwok <w-kwok2@ti.com> >> >> 10gbe phy driver needs to access the 10gbe subsystem control >> register during phy initialization. To facilitate the shared >> access of the subsystem register region between the 10gbe Ethernet >> driver and the phy driver, this patch adds support of the >> subsystem register region defined by a syscon node in the dts. >> >> Although there is no shared access to the gbe subsystem register >> region, using syscon for that is for the sake of consistency. >> >> This change is backward compatible with previously released gbe >> devicetree bindings. >> >> Signed-off-by: WingMan Kwok <w-kwok2@ti.com> >> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> >> Signed-off-by: Sekhar Nori <nsekhar@ti.com> >> --- >> .../devicetree/bindings/net/keystone-netcp.txt | 16 ++- >> drivers/net/ethernet/ti/netcp_ethss.c | 140 +++++++++++++++++---- >> 2 files changed, 127 insertions(+), 29 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/keystone-netcp.txt b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> index 04ba1dc..0854a73 100644 >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> @@ -72,20 +72,24 @@ Required properties: >> "ti,netcp-gbe-2" for 1GbE N NetCP 1.5 (N=2) >> "ti,netcp-xgbe" for 10 GbE >> >> +- syscon-subsys: phandle to syscon node of the switch >> + subsystem registers. >> + >> - reg: register location and the size for the following register >> regions in the specified order. >> - switch subsystem registers >> + - sgmii module registers > > This needs to go on the end of the list. Otherwise, it is not backwards > compatible. Thanks for your review! I assumed backward compatibility means new kernel should work with old DTB. The driver code is adjusted to work with both DTBs. Isn't that enough? Murali > >> - sgmii port3/4 module registers (only for NetCP 1.4) >> - switch module registers >> - serdes registers (only for 10G) >> >> NetCP 1.4 ethss, here is the order >> - index #0 - switch subsystem registers >> + index #0 - sgmii module registers >> index #1 - sgmii port3/4 module registers >> index #2 - switch module registers >> >> NetCP 1.5 ethss 9 port, 5 port and 2 port >> - index #0 - switch subsystem registers >> + index #0 - sgmii module registers >> index #1 - switch module registers >> index #2 - serdes registers >> >> @@ -145,6 +149,11 @@ Optional properties: >> >> Example binding: >> >> +gbe_subsys: subsys@2090000 { >> + compatible = "syscon"; >> + reg = <0x02090000 0x100>; >> +}; >> + >> netcp: netcp@2000000 { >> reg = <0x2620110 0x8>; >> reg-names = "efuse"; >> @@ -163,7 +172,8 @@ netcp: netcp@2000000 { >> ranges; >> gbe@90000 { >> label = "netcp-gbe"; >> - reg = <0x90000 0x300>, <0x90400 0x400>, <0x90800 0x700>; >> + syscon-subsys = <&gbe_subsys>; >> + reg = <0x90100 0x200>, <0x90400 0x200>, <0x90800 0x700>; >> /* enable-ale; */ >> tx-queue = <648>; >> tx-channel = <8>; > -- Murali Karicheri Linux Kernel, Keystone
WARNING: multiple messages have this Message-ID (diff)
From: Murali Karicheri <m-karicheri2@ti.com> To: Rob Herring <robh@kernel.org> Cc: netdev@vger.kernel.org, linux-omap@vger.kernel.org, grygorii.strashko@ti.com, mugunthanvnm@ti.com, linux-kernel@vger.kernel.org, arnd@arndb.de, davem@davemloft.net, devicetree@vger.kernel.org, mark.rutland@arm.com Subject: Re: [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap Date: Thu, 5 Jan 2017 15:42:38 -0500 [thread overview] Message-ID: <586EAFBE.1000500@ti.com> (raw) In-Reply-To: <20161222212409.arhurpl4bpqf2yw6@rob-hp-laptop> Rob, On 12/22/2016 04:24 PM, Rob Herring wrote: > On Tue, Dec 20, 2016 at 05:09:44PM -0500, Murali Karicheri wrote: >> From: WingMan Kwok <w-kwok2@ti.com> >> >> 10gbe phy driver needs to access the 10gbe subsystem control >> register during phy initialization. To facilitate the shared >> access of the subsystem register region between the 10gbe Ethernet >> driver and the phy driver, this patch adds support of the >> subsystem register region defined by a syscon node in the dts. >> >> Although there is no shared access to the gbe subsystem register >> region, using syscon for that is for the sake of consistency. >> >> This change is backward compatible with previously released gbe >> devicetree bindings. >> >> Signed-off-by: WingMan Kwok <w-kwok2@ti.com> >> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> >> Signed-off-by: Sekhar Nori <nsekhar@ti.com> >> --- >> .../devicetree/bindings/net/keystone-netcp.txt | 16 ++- >> drivers/net/ethernet/ti/netcp_ethss.c | 140 +++++++++++++++++---- >> 2 files changed, 127 insertions(+), 29 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/keystone-netcp.txt b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> index 04ba1dc..0854a73 100644 >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt >> @@ -72,20 +72,24 @@ Required properties: >> "ti,netcp-gbe-2" for 1GbE N NetCP 1.5 (N=2) >> "ti,netcp-xgbe" for 10 GbE >> >> +- syscon-subsys: phandle to syscon node of the switch >> + subsystem registers. >> + >> - reg: register location and the size for the following register >> regions in the specified order. >> - switch subsystem registers >> + - sgmii module registers > > This needs to go on the end of the list. Otherwise, it is not backwards > compatible. Thanks for your review! I assumed backward compatibility means new kernel should work with old DTB. The driver code is adjusted to work with both DTBs. Isn't that enough? Murali > >> - sgmii port3/4 module registers (only for NetCP 1.4) >> - switch module registers >> - serdes registers (only for 10G) >> >> NetCP 1.4 ethss, here is the order >> - index #0 - switch subsystem registers >> + index #0 - sgmii module registers >> index #1 - sgmii port3/4 module registers >> index #2 - switch module registers >> >> NetCP 1.5 ethss 9 port, 5 port and 2 port >> - index #0 - switch subsystem registers >> + index #0 - sgmii module registers >> index #1 - switch module registers >> index #2 - serdes registers >> >> @@ -145,6 +149,11 @@ Optional properties: >> >> Example binding: >> >> +gbe_subsys: subsys@2090000 { >> + compatible = "syscon"; >> + reg = <0x02090000 0x100>; >> +}; >> + >> netcp: netcp@2000000 { >> reg = <0x2620110 0x8>; >> reg-names = "efuse"; >> @@ -163,7 +172,8 @@ netcp: netcp@2000000 { >> ranges; >> gbe@90000 { >> label = "netcp-gbe"; >> - reg = <0x90000 0x300>, <0x90400 0x400>, <0x90800 0x700>; >> + syscon-subsys = <&gbe_subsys>; >> + reg = <0x90100 0x200>, <0x90400 0x200>, <0x90800 0x700>; >> /* enable-ale; */ >> tx-queue = <648>; >> tx-channel = <8>; > -- Murali Karicheri Linux Kernel, Keystone
next prev parent reply other threads:[~2017-01-05 21:55 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-20 22:09 [PATCH net-next 00/10] netcp: enhancements and minor fixes Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 01/10] net: netcp: ethss: add support of subsystem register region regmap Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-22 21:24 ` Rob Herring 2016-12-22 21:24 ` Rob Herring 2017-01-05 20:42 ` Murali Karicheri [this message] 2017-01-05 20:42 ` Murali Karicheri 2017-01-05 22:08 ` Murali Karicheri 2017-01-05 22:08 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 02/10] net: netcp: ethss: add support of 10gbe pcsr link status Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-22 22:30 ` Rob Herring 2016-12-20 22:09 ` [PATCH net-next 03/10] net: netcp: extract eflag from desc for rx_hook handling Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 04/10] net: netcp: remove the redundant memmov() Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 05/10] net: netcp: store network statistics in 64 bits Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 06/10] net: netcp: ethss: get phy-handle only if link interface is MAC-to-PHY Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 07/10] net: netcp: use hw capability to remove FCS word from rx packets Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 08/10] net: netcp: ale: update to support unknown vlan controls for NU switch Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 09/10] net: netcp: ale: use ale_status to size the ale table Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` [PATCH net-next 10/10] net: netcp: ale: add proper ale entry mask bits for netcp switch ALE Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-20 22:09 ` Murali Karicheri 2016-12-21 0:03 ` [PATCH net-next 00/10] netcp: enhancements and minor fixes David Miller 2016-12-21 23:50 ` Murali Karicheri 2016-12-21 23:50 ` Murali Karicheri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=586EAFBE.1000500@ti.com \ --to=m-karicheri2@ti.com \ --cc=arnd@arndb.de \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=grygorii.strashko@ti.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mugunthanvnm@ti.com \ --cc=netdev@vger.kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.