From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: linux-fbdev@vger.kernel.org,
Teddy Wang <teddy.wang@siliconmotion.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH 06/11] staging/lynxfb: Use pci aperture helper
Date: Wed, 11 Jan 2023 17:05:08 +0100 [thread overview]
Message-ID: <589bfc44-1f0b-bc47-fa6d-82c649103157@suse.de> (raw)
In-Reply-To: <20230111154112.90575-6-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1916 bytes --]
Hi
Am 11.01.23 um 16:41 schrieb Daniel Vetter:
> It exists! Note that since this is an exact copy, there shouldn't be
> any functional difference here.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Cc: Teddy Wang <teddy.wang@siliconmotion.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/staging/sm750fb/sm750.c | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index effc7fcc3703..22ace3168723 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -989,20 +989,6 @@ static int sm750fb_framebuffer_alloc(struct sm750_dev *sm750_dev, int fbidx)
> return err;
> }
>
> -static int lynxfb_kick_out_firmware_fb(struct pci_dev *pdev)
> -{
> - resource_size_t base = pci_resource_start(pdev, 0);
> - resource_size_t size = pci_resource_len(pdev, 0);
> - bool primary = false;
> -
> -#ifdef CONFIG_X86
> - primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> - IORESOURCE_ROM_SHADOW;
> -#endif
> -
> - return aperture_remove_conflicting_devices(base, size, primary, "sm750_fb1");
This still had the primary argument, it needs to be handled in an early
patch in some way.
> -}
> -
> static int lynxfb_pci_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> {
> @@ -1011,7 +997,7 @@ static int lynxfb_pci_probe(struct pci_dev *pdev,
> int fbidx;
> int err;
>
> - err = lynxfb_kick_out_firmware_fb(pdev);
> + err = aperture_remove_conflicting_pci_devices(pdev, "sm750_fb1");
> if (err)
> return err;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: linux-fbdev@vger.kernel.org,
Teddy Wang <teddy.wang@siliconmotion.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 06/11] staging/lynxfb: Use pci aperture helper
Date: Wed, 11 Jan 2023 17:05:08 +0100 [thread overview]
Message-ID: <589bfc44-1f0b-bc47-fa6d-82c649103157@suse.de> (raw)
In-Reply-To: <20230111154112.90575-6-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1916 bytes --]
Hi
Am 11.01.23 um 16:41 schrieb Daniel Vetter:
> It exists! Note that since this is an exact copy, there shouldn't be
> any functional difference here.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Cc: Teddy Wang <teddy.wang@siliconmotion.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/staging/sm750fb/sm750.c | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index effc7fcc3703..22ace3168723 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -989,20 +989,6 @@ static int sm750fb_framebuffer_alloc(struct sm750_dev *sm750_dev, int fbidx)
> return err;
> }
>
> -static int lynxfb_kick_out_firmware_fb(struct pci_dev *pdev)
> -{
> - resource_size_t base = pci_resource_start(pdev, 0);
> - resource_size_t size = pci_resource_len(pdev, 0);
> - bool primary = false;
> -
> -#ifdef CONFIG_X86
> - primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> - IORESOURCE_ROM_SHADOW;
> -#endif
> -
> - return aperture_remove_conflicting_devices(base, size, primary, "sm750_fb1");
This still had the primary argument, it needs to be handled in an early
patch in some way.
> -}
> -
> static int lynxfb_pci_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> {
> @@ -1011,7 +997,7 @@ static int lynxfb_pci_probe(struct pci_dev *pdev,
> int fbidx;
> int err;
>
> - err = lynxfb_kick_out_firmware_fb(pdev);
> + err = aperture_remove_conflicting_pci_devices(pdev, "sm750_fb1");
> if (err)
> return err;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 06/11] staging/lynxfb: Use pci aperture helper
Date: Wed, 11 Jan 2023 17:05:08 +0100 [thread overview]
Message-ID: <589bfc44-1f0b-bc47-fa6d-82c649103157@suse.de> (raw)
In-Reply-To: <20230111154112.90575-6-daniel.vetter@ffwll.ch>
[-- Attachment #1.1: Type: text/plain, Size: 1916 bytes --]
Hi
Am 11.01.23 um 16:41 schrieb Daniel Vetter:
> It exists! Note that since this is an exact copy, there shouldn't be
> any functional difference here.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Cc: Teddy Wang <teddy.wang@siliconmotion.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/staging/sm750fb/sm750.c | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index effc7fcc3703..22ace3168723 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -989,20 +989,6 @@ static int sm750fb_framebuffer_alloc(struct sm750_dev *sm750_dev, int fbidx)
> return err;
> }
>
> -static int lynxfb_kick_out_firmware_fb(struct pci_dev *pdev)
> -{
> - resource_size_t base = pci_resource_start(pdev, 0);
> - resource_size_t size = pci_resource_len(pdev, 0);
> - bool primary = false;
> -
> -#ifdef CONFIG_X86
> - primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> - IORESOURCE_ROM_SHADOW;
> -#endif
> -
> - return aperture_remove_conflicting_devices(base, size, primary, "sm750_fb1");
This still had the primary argument, it needs to be handled in an early
patch in some way.
> -}
> -
> static int lynxfb_pci_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> {
> @@ -1011,7 +997,7 @@ static int lynxfb_pci_probe(struct pci_dev *pdev,
> int fbidx;
> int err;
>
> - err = lynxfb_kick_out_firmware_fb(pdev);
> + err = aperture_remove_conflicting_pci_devices(pdev, "sm750_fb1");
> if (err)
> return err;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-01-11 16:05 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 15:41 [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 02/11] drm/gma500: " Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-12 9:04 ` Thomas Zimmermann
2023-01-12 9:04 ` Thomas Zimmermann
2023-01-12 9:04 ` [Intel-gfx] " Thomas Zimmermann
2023-01-12 9:59 ` Daniel Vetter
2023-01-12 9:59 ` Daniel Vetter
2023-01-12 9:59 ` [Intel-gfx] " Daniel Vetter
2023-01-12 10:24 ` Thomas Zimmermann
2023-01-12 10:24 ` [Intel-gfx] " Thomas Zimmermann
2023-01-12 10:45 ` Daniel Vetter
2023-01-12 10:45 ` Daniel Vetter
2023-01-12 10:45 ` [Intel-gfx] " Daniel Vetter
2023-01-12 12:15 ` Thomas Zimmermann
2023-01-12 12:15 ` [Intel-gfx] " Thomas Zimmermann
2023-01-12 15:32 ` Daniel Vetter
2023-01-12 15:32 ` Daniel Vetter
2023-01-12 15:32 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` [PATCH 03/11] drm/aperture: Remove primary argument Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:49 ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 15:49 ` Thomas Zimmermann
2023-01-11 15:49 ` Thomas Zimmermann
2023-01-11 15:49 ` Thomas Zimmermann
2023-01-11 15:49 ` Thomas Zimmermann
2023-01-11 15:41 ` [PATCH 04/11] video/aperture: use generic code to figure out the vga default device Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:59 ` Thomas Zimmermann
2023-01-11 15:59 ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 15:59 ` Thomas Zimmermann
2023-01-11 16:51 ` Daniel Vetter
2023-01-11 16:51 ` [Intel-gfx] " Daniel Vetter
2023-01-11 16:51 ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 05/11] video/aperture: Only kick vgacon when the pdev is decoding vga Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 16:03 ` Thomas Zimmermann
2023-01-11 16:03 ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 16:03 ` Thomas Zimmermann
2023-01-11 16:55 ` Daniel Vetter
2023-01-11 16:55 ` [Intel-gfx] " Daniel Vetter
2023-01-11 16:55 ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 06/11] staging/lynxfb: Use pci aperture helper Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 16:05 ` Thomas Zimmermann [this message]
2023-01-11 16:05 ` Thomas Zimmermann
2023-01-11 16:05 ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 15:41 ` [PATCH 07/11] fbdev/radeon: use pci aperture helpers Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 08/11] fbdev/hyperv: " Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-17 18:42 ` Dexuan Cui
2023-01-17 18:42 ` Dexuan Cui
2023-01-11 15:41 ` [PATCH 09/11] video/aperture: Move vga handling to pci function Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:41 ` [PATCH 10/11] video/aperture: Drop primary argument Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 16:09 ` Thomas Zimmermann
2023-01-11 16:09 ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 16:09 ` Thomas Zimmermann
2023-01-11 15:41 ` [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device Daniel Vetter
2023-01-11 15:41 ` Daniel Vetter
2023-01-11 15:41 ` [Intel-gfx] " Daniel Vetter
2023-01-11 16:20 ` Thomas Zimmermann
2023-01-11 16:20 ` Thomas Zimmermann
2023-01-11 16:20 ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 16:37 ` Daniel Vetter
2023-01-11 16:37 ` Daniel Vetter
2023-01-11 16:37 ` [Intel-gfx] " Daniel Vetter
2023-01-12 7:48 ` Thomas Zimmermann
2023-01-12 7:48 ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 16:43 ` Javier Martinez Canillas
2023-01-11 16:43 ` [Intel-gfx] " Javier Martinez Canillas
2023-01-11 16:58 ` Javier Martinez Canillas
2023-01-11 16:58 ` Javier Martinez Canillas
2023-01-11 16:58 ` [Intel-gfx] " Javier Martinez Canillas
2023-01-11 19:21 ` Aaron Plattner
2023-01-11 19:21 ` Aaron Plattner
2023-01-11 19:21 ` [Intel-gfx] " Aaron Plattner
2023-01-12 7:55 ` Thomas Zimmermann
2023-01-12 7:55 ` [Intel-gfx] " Thomas Zimmermann
2023-01-12 7:55 ` Thomas Zimmermann
2023-01-12 8:44 ` Javier Martinez Canillas
2023-01-12 8:44 ` Javier Martinez Canillas
2023-01-12 8:44 ` [Intel-gfx] " Javier Martinez Canillas
2023-01-11 15:48 ` [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers Thomas Zimmermann
2023-01-11 15:48 ` [Intel-gfx] " Thomas Zimmermann
2023-01-11 15:48 ` Thomas Zimmermann
2023-01-11 17:02 ` Daniel Vetter
2023-01-11 17:02 ` Daniel Vetter
2023-01-11 17:02 ` [Intel-gfx] " Daniel Vetter
2023-01-11 16:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] " Patchwork
2023-01-11 16:38 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-01-12 9:41 ` [PATCH 01/11] " Thomas Zimmermann
2023-01-12 9:41 ` Thomas Zimmermann
2023-01-12 9:41 ` [Intel-gfx] " Thomas Zimmermann
2023-04-04 14:45 ` Thomas Zimmermann
2023-04-04 14:45 ` [Intel-gfx] " Thomas Zimmermann
2023-04-04 14:45 ` Thomas Zimmermann
2023-04-18 0:53 ` Jammy Huang
2023-04-18 0:53 ` [Intel-gfx] " Jammy Huang
2023-04-18 0:53 ` Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=589bfc44-1f0b-bc47-fa6d-82c649103157@suse.de \
--to=tzimmermann@suse.de \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.