From: Yuehaibing <yuehaibing@huawei.com>
To: "Life is hard, and then you die" <ronald@innovation.ch>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: <nikolas@gnu.org>, <linux-kernel@vger.kernel.org>,
<linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: applespi - Fix build error
Date: Tue, 30 Jul 2019 15:22:43 +0800 [thread overview]
Message-ID: <59344451-4752-8610-22cd-2aa9b34e21ed@huawei.com> (raw)
In-Reply-To: <20190730070117.GB20206@innovation.ch>
On 2019/7/30 15:01, Life is hard, and then you die wrote:
>
> On Mon, Jul 29, 2019 at 04:04:38PM +0200, Dmitry Torokhov wrote:
>> On Mon, Jul 29, 2019 at 11:14:55AM +0800, YueHaibing wrote:
>>> If CONFIG_KEYBOARD_APPLESPI=y but CONFIG_LEDS_CLASS=m
>>> building fails:
>>>
>>> drivers/input/keyboard/applespi.o: In function `applespi_probe':
>>> applespi.c:(.text+0x1fcd): undefined reference to `devm_led_classdev_register_ext'
>>>
>>> Wrap it in LEDS_CLASS macro to fix this.
>>
>> No, we should add "depends on LEDS_CLASS" to the Konfig instead.
>
> While the loss of keyboard-backlight functionality is certainly not
> critical, in practice when building a kernel for desktops/laptops
> (i.e. where this module would be used) I see no real reason why you'd
> not have/want LEDS_CLASS enabled. So I'd agree with Dmitry that a
> Kconfig depends-on is probably the preferred approach.
Thanks, will send v2 as suggestion.
>
>
> Cheers,
>
> Ronald
>
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: Yuehaibing <yuehaibing@huawei.com>
To: "Life is hard, and then you die" <ronald@innovation.ch>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: nikolas@gnu.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: applespi - Fix build error
Date: Tue, 30 Jul 2019 15:22:43 +0800 [thread overview]
Message-ID: <59344451-4752-8610-22cd-2aa9b34e21ed@huawei.com> (raw)
In-Reply-To: <20190730070117.GB20206@innovation.ch>
On 2019/7/30 15:01, Life is hard, and then you die wrote:
>
> On Mon, Jul 29, 2019 at 04:04:38PM +0200, Dmitry Torokhov wrote:
>> On Mon, Jul 29, 2019 at 11:14:55AM +0800, YueHaibing wrote:
>>> If CONFIG_KEYBOARD_APPLESPI=y but CONFIG_LEDS_CLASS=m
>>> building fails:
>>>
>>> drivers/input/keyboard/applespi.o: In function `applespi_probe':
>>> applespi.c:(.text+0x1fcd): undefined reference to `devm_led_classdev_register_ext'
>>>
>>> Wrap it in LEDS_CLASS macro to fix this.
>>
>> No, we should add "depends on LEDS_CLASS" to the Konfig instead.
>
> While the loss of keyboard-backlight functionality is certainly not
> critical, in practice when building a kernel for desktops/laptops
> (i.e. where this module would be used) I see no real reason why you'd
> not have/want LEDS_CLASS enabled. So I'd agree with Dmitry that a
> Kconfig depends-on is probably the preferred approach.
Thanks, will send v2 as suggestion.
>
>
> Cheers,
>
> Ronald
>
>
> .
>
next prev parent reply other threads:[~2019-07-30 7:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 3:14 [PATCH] Input: applespi - Fix build error YueHaibing
2019-07-29 3:14 ` YueHaibing
2019-07-29 14:04 ` Dmitry Torokhov
2019-07-30 7:01 ` Life is hard, and then you die
2019-07-30 7:22 ` Yuehaibing [this message]
2019-07-30 7:22 ` Yuehaibing
2019-07-30 13:34 ` [PATCH v2] " YueHaibing
2019-07-30 13:34 ` YueHaibing
2019-07-31 13:49 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59344451-4752-8610-22cd-2aa9b34e21ed@huawei.com \
--to=yuehaibing@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikolas@gnu.org \
--cc=ronald@innovation.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.