From: "Heiko Stübner" <heiko@sntech.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] pinctrl: rockchip: remove unneeded (void *) casts in of_match_table
Date: Wed, 26 Apr 2017 00:11:32 +0200 [thread overview]
Message-ID: <59735505.eYpuzA7ihW@diego> (raw)
In-Reply-To: <1493156063-8446-2-git-send-email-yamada.masahiro@socionext.com>
Hi,
Am Mittwoch, 26. April 2017, 06:34:22 CEST schrieb Masahiro Yamada:
> of_device_id::data is an opaque pointer. No explicit cast is needed.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index 7813599..da1a38f 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -2769,25 +2769,25 @@ static struct rockchip_pin_ctrl rk3399_pin_ctrl = {
>
> static const struct of_device_id rockchip_pinctrl_dt_match[] = {
> { .compatible = "rockchip,rk1108-pinctrl",
> - .data = (void *)&rk1108_pin_ctrl },
> + .data = &rk1108_pin_ctrl },
You should base your pinctrl-patches on top of Linus' branch, especially
as the rk1108->rv1108 is in there:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/drivers/pinctrl/pinctrl-rockchip.c?h=for-next&id=b9c6dcab265e93c47bdcd99ab7c6acda90ed669b
With the above fixed:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pinctrl: rockchip: remove unneeded (void *) casts in of_match_table
Date: Wed, 26 Apr 2017 00:11:32 +0200 [thread overview]
Message-ID: <59735505.eYpuzA7ihW@diego> (raw)
In-Reply-To: <1493156063-8446-2-git-send-email-yamada.masahiro@socionext.com>
Hi,
Am Mittwoch, 26. April 2017, 06:34:22 CEST schrieb Masahiro Yamada:
> of_device_id::data is an opaque pointer. No explicit cast is needed.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index 7813599..da1a38f 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -2769,25 +2769,25 @@ static struct rockchip_pin_ctrl rk3399_pin_ctrl = {
>
> static const struct of_device_id rockchip_pinctrl_dt_match[] = {
> { .compatible = "rockchip,rk1108-pinctrl",
> - .data = (void *)&rk1108_pin_ctrl },
> + .data = &rk1108_pin_ctrl },
You should base your pinctrl-patches on top of Linus' branch, especially
as the rk1108->rv1108 is in there:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/drivers/pinctrl/pinctrl-rockchip.c?h=for-next&id=b9c6dcab265e93c47bdcd99ab7c6acda90ed669b
With the above fixed:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Heiko
next prev parent reply other threads:[~2017-04-25 22:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 21:34 [PATCH 0/2] pinctrl: trivial: remove unneeded (void *) casts in of_match_table Masahiro Yamada
2017-04-25 21:34 ` Masahiro Yamada
2017-04-25 21:34 ` Masahiro Yamada
2017-04-25 21:34 ` [PATCH 1/2] pinctrl: rockchip: " Masahiro Yamada
2017-04-25 21:34 ` Masahiro Yamada
2017-04-25 22:11 ` Heiko Stübner [this message]
2017-04-25 22:11 ` Heiko Stübner
2017-04-25 21:34 ` [PATCH 2/2] pinctrl: samsung: " Masahiro Yamada
2017-04-25 21:34 ` Masahiro Yamada
2017-04-25 21:34 ` Masahiro Yamada
2017-04-26 7:21 ` Krzysztof Kozlowski
2017-04-26 7:21 ` Krzysztof Kozlowski
2017-05-15 17:04 ` Krzysztof Kozlowski
2017-05-15 17:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59735505.eYpuzA7ihW@diego \
--to=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.