From: "Arnd Bergmann" <arnd@arndb.de>
To: "Christoph Hellwig" <hch@lst.de>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Manuel Lauss" <manuel.lauss@gmail.com>,
"Yangbo Lu" <yangbo.lu@nxp.com>,
"Joshua Kinard" <kumba@gentoo.org>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
linux-arm-kernel@lists.infradead.org,
"open list" <linux-kernel@vger.kernel.org>,
"linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH 2/5] mmc: au1xmmc: force non-modular build and remove symbol_get usage
Date: Wed, 02 Aug 2023 10:31:54 +0200 [thread overview]
Message-ID: <599b845c-80d9-467c-b9ac-2ce844ee256e@app.fastmail.com> (raw)
In-Reply-To: <20230801173544.1929519-3-hch@lst.de>
On Tue, Aug 1, 2023, at 19:35, Christoph Hellwig wrote:
> au1xmmc is split somewhat awkwardly into the main mmc subsystem driver,
> and callbacks in platform_data that sit under arch/mips/ and are
> always built in. The latter than call mmc_detect_change through
> symbol_get. Remove the use of symbol_get by requiring the driver
> to be built in. In the future the interrupt handlers for card
> insert/eject detection should probably be moved into the main driver,
> and which point it can be built modular again.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Good idea.
> of Alcor Micro PCI-E card reader
>
> config MMC_AU1X
> - tristate "Alchemy AU1XX0 MMC Card Interface support"
> + bool "Alchemy AU1XX0 MMC Card Interface support"
> depends on MIPS_ALCHEMY
> help
This needs a
depends on MMC=y
otherwise you get a link failure with CONFIG_MMC=m and
CONFIG_MMC_AU1X=y.
With that fixed,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
WARNING: multiple messages have this Message-ID (diff)
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Christoph Hellwig" <hch@lst.de>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Manuel Lauss" <manuel.lauss@gmail.com>,
"Yangbo Lu" <yangbo.lu@nxp.com>,
"Joshua Kinard" <kumba@gentoo.org>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
linux-arm-kernel@lists.infradead.org,
"open list" <linux-kernel@vger.kernel.org>,
"linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
linux-rtc@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH 2/5] mmc: au1xmmc: force non-modular build and remove symbol_get usage
Date: Wed, 02 Aug 2023 10:31:54 +0200 [thread overview]
Message-ID: <599b845c-80d9-467c-b9ac-2ce844ee256e@app.fastmail.com> (raw)
In-Reply-To: <20230801173544.1929519-3-hch@lst.de>
On Tue, Aug 1, 2023, at 19:35, Christoph Hellwig wrote:
> au1xmmc is split somewhat awkwardly into the main mmc subsystem driver,
> and callbacks in platform_data that sit under arch/mips/ and are
> always built in. The latter than call mmc_detect_change through
> symbol_get. Remove the use of symbol_get by requiring the driver
> to be built in. In the future the interrupt handlers for card
> insert/eject detection should probably be moved into the main driver,
> and which point it can be built modular again.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Good idea.
> of Alcor Micro PCI-E card reader
>
> config MMC_AU1X
> - tristate "Alchemy AU1XX0 MMC Card Interface support"
> + bool "Alchemy AU1XX0 MMC Card Interface support"
> depends on MIPS_ALCHEMY
> help
This needs a
depends on MMC=y
otherwise you get a link failure with CONFIG_MMC=m and
CONFIG_MMC_AU1X=y.
With that fixed,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-02 8:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 17:35 require EXPORT_SYMBOL_GPL symbols for symbol_get v2 Christoph Hellwig
2023-08-01 17:35 ` Christoph Hellwig
2023-08-01 17:35 ` [PATCH 1/5] ARM: pxa: remove use of symbol_get() Christoph Hellwig
2023-08-01 17:35 ` Christoph Hellwig
2023-08-01 17:35 ` [PATCH 2/5] mmc: au1xmmc: force non-modular build and remove symbol_get usage Christoph Hellwig
2023-08-01 17:35 ` Christoph Hellwig
2023-08-02 7:12 ` Manuel Lauss
2023-08-02 7:12 ` Manuel Lauss
2023-08-02 8:31 ` Arnd Bergmann [this message]
2023-08-02 8:31 ` Arnd Bergmann
2023-08-08 9:15 ` Ulf Hansson
2023-08-08 9:15 ` Ulf Hansson
2023-08-01 17:35 ` [PATCH 3/5] net: enetc: use EXPORT_SYMBOL_GPL for enetc_phc_index Christoph Hellwig
2023-08-01 17:35 ` Christoph Hellwig
2023-08-01 17:35 ` [PATCH 4/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff Christoph Hellwig
2023-08-01 17:35 ` Christoph Hellwig
2023-08-01 17:35 ` [PATCH 5/5] modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules Christoph Hellwig
2023-08-01 17:35 ` Christoph Hellwig
2023-10-18 0:30 ` David Woodhouse
2023-10-18 0:30 ` David Woodhouse
2023-10-18 5:31 ` Christoph Hellwig
2023-10-18 5:31 ` Christoph Hellwig
2023-10-18 18:25 ` Luis Chamberlain
2023-10-18 18:25 ` Luis Chamberlain
2023-08-01 17:45 ` require EXPORT_SYMBOL_GPL symbols for symbol_get v2 Luis Chamberlain
2023-08-01 17:45 ` Luis Chamberlain
2023-08-02 11:56 ` Christoph Hellwig
2023-08-02 11:56 ` Christoph Hellwig
2023-08-02 18:19 ` Luis Chamberlain
2023-08-02 18:19 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=599b845c-80d9-467c-b9ac-2ce844ee256e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@zonque.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=hch@lst.de \
--cc=kumba@gentoo.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=ulf.hansson@linaro.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.