Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

From: jeffy <jeffy.chen@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh@kernel.org>,
	linux-kernel@vger.kernel.org, dgreid@chromium.org,
	briannorris@chromium.org, mka@chromium.org,
	dianders@chromium.org, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi
Date: Mon, 18 Sep 2017 19:20:07 +0800	[thread overview]
Message-ID: <59BFABE7.5050904@rock-chips.com> (raw)
In-Reply-To: <1972340.u0BEiYTrvM@phil>

Hi Heiko,

Thanks for your reply.

On 09/18/2017 05:30 PM, Heiko Stuebner wrote:
>>>> > >>
>>>> > >>-- compatible : "realtek,rt5514".
>>>> > >>+- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c".
>>> > >
>>> > >There's no need for the -spi or -i2c compatibles. This is implied by
>>> > >being a child of those controllers.
>> >heiko mentioned i should add it in the binding in:
>> >https://patchwork.kernel.org/patch/9918987/
> If you add a new compatible you need to add it to the binding. I think what
> Rob means is, that both the i2c and spi side can have the_same_
> compatible without the -i2c or -spi, as you can check wether they are
> children of either a spi or i2c controller in the code itself.
>
ok, got it.

i sent a new patch to check the bus_type instead :)