Re: [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps

From: Robin Murphy <robin.murphy@arm.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix NanoPC-T4 cooling maps
Date: Mon, 18 Nov 2019 12:09:38 +0000	[thread overview]
Message-ID: <59e03b94-87af-6d75-6036-c02b9dd89dbe@arm.com> (raw)
In-Reply-To: <4249681.hKoAvgd4aH@phil>

On 18/11/2019 12:52 am, Heiko Stuebner wrote:
> Am Samstag, 16. November 2019, 13:47:19 CET schrieb Robin Murphy:
>> Although it appeared to follow logically from the bindings, apparently
>> the thermal framework can't properly cope with a single cooling device
>> being shared between multiple maps. The CPU zone is probably easier to
>> overheat, so remove the references to the (optional) fan from the GPU
>> cooling zone to avoid things getting confused. Hopefully GPU-intensive
>> tasks will leak enough heat across to the CPU zone to still hit the
>> fan trips before reaching critical GPU temperatures.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> 
> applied, after little bit of editing.
> 
>>   &i2s0 {
>>   	status = "okay";
>>   };
> 
> although my nano-pc dts does not seem to have that &i2s0 node yet.
> Did I miss a patch somewhere?

Oops, no, my fault - there were more changes in the middle of my local 
branch which I thought were entirely orthogonal. I should have checked 
the diff context more closely... thanks for cleaning it up!

Robin.