From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
kgene@kernel.org, Tomasz Figa <tomasz.figa@gmail.com>,
chanwoo@kernel.org, Jaehoon Chung <jh80.chung@samsung.com>,
Inki Dae <inki.dae@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 0/9] soc: samsung: Add support of suspend-to-RAM on Exynos5433
Date: Wed, 10 Jan 2018 18:19:50 +0900 [thread overview]
Message-ID: <5A55DAB6.2020808@samsung.com> (raw)
In-Reply-To: <CAJKOXPcJPbVR+WqAzhM8Tuud1Pd9W2p_23iTUveXc5aJtgTJCg@mail.gmail.com>
On 2018년 01월 09일 20:56, Krzysztof Kozlowski wrote:
> On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> In the mainline, there is no case to support the suspend-to-RAM for Samsung
>> Exynos SoC. This patchset support the suspend-to-RAM for 64bit Exynos SoC.
>>
>> For 32bit, arch/arm/mach-exynos/* directoy contains the suspend-related
>> codes such as suspend.c/exynos.c. But, 64bit Exynos should contain
>> the suspend-related codes in the drivers/soc/samsung/*. So, this patchset
>> develop the patch4/5 for drivers/soc/samsung/exynos-pm.c. to support suspend
>> 64bit Exynos SoC.
>>
>> But, I'm not sure what is proper approach for both 32/64bit Exynos.
>> - Approach1 : Split out the supend-related codes between 32/64bit.
>> : arch/arm/mach-exynos/* contains the suspend-related codes for 32bit.
>> : drivers/soc/samsung/* contains the suspend-related codes for 64bit.
>> - Approach2 : Consolidate the all suspend-related codes to drivers/soc/samsung/.
>
> I prefer approach #2 - consolidate the code... unless this creates
> some unmaintainable monster :)
I'll try to consolidate code.
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 0/9] soc: samsung: Add support of suspend-to-RAM on Exynos5433
Date: Wed, 10 Jan 2018 18:19:50 +0900 [thread overview]
Message-ID: <5A55DAB6.2020808@samsung.com> (raw)
In-Reply-To: <CAJKOXPcJPbVR+WqAzhM8Tuud1Pd9W2p_23iTUveXc5aJtgTJCg@mail.gmail.com>
On 2018? 01? 09? 20:56, Krzysztof Kozlowski wrote:
> On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> In the mainline, there is no case to support the suspend-to-RAM for Samsung
>> Exynos SoC. This patchset support the suspend-to-RAM for 64bit Exynos SoC.
>>
>> For 32bit, arch/arm/mach-exynos/* directoy contains the suspend-related
>> codes such as suspend.c/exynos.c. But, 64bit Exynos should contain
>> the suspend-related codes in the drivers/soc/samsung/*. So, this patchset
>> develop the patch4/5 for drivers/soc/samsung/exynos-pm.c. to support suspend
>> 64bit Exynos SoC.
>>
>> But, I'm not sure what is proper approach for both 32/64bit Exynos.
>> - Approach1 : Split out the supend-related codes between 32/64bit.
>> : arch/arm/mach-exynos/* contains the suspend-related codes for 32bit.
>> : drivers/soc/samsung/* contains the suspend-related codes for 64bit.
>> - Approach2 : Consolidate the all suspend-related codes to drivers/soc/samsung/.
>
> I prefer approach #2 - consolidate the code... unless this creates
> some unmaintainable monster :)
I'll try to consolidate code.
[snip]
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2018-01-10 9:19 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180109075904epcas2p302d58aacfbb2195e455a25c90a1c610b@epcas2p3.samsung.com>
2018-01-09 7:58 ` [RFC PATCH 0/9] soc: samsung: Add support of suspend-to-RAM on Exynos5433 Chanwoo Choi
2018-01-09 7:58 ` Chanwoo Choi
2018-01-09 7:58 ` Chanwoo Choi
[not found] ` <CGME20180109075905epcas1p1486543d8fec46f47d9d5ac350d841337@epcas1p1.samsung.com>
2018-01-09 7:58 ` [PATCH 1/9] clk: samsung: exynos5433: Add clock flag to support suspend-to-ram Chanwoo Choi
2018-01-09 7:58 ` Chanwoo Choi
2018-01-09 7:58 ` Chanwoo Choi
2018-01-09 11:44 ` Krzysztof Kozlowski
2018-01-09 11:44 ` Krzysztof Kozlowski
2018-01-09 11:44 ` Krzysztof Kozlowski
2018-01-10 9:31 ` Chanwoo Choi
2018-01-10 9:31 ` Chanwoo Choi
2018-01-12 13:24 ` Marek Szyprowski
2018-01-12 13:24 ` Marek Szyprowski
[not found] ` <CGME20180109075905epcas1p4e601230d86dd686db28796165178dafa@epcas1p4.samsung.com>
2018-01-09 7:58 ` [PATCH 2/9] soc: samsung: pmu: Add powerup_conf callback Chanwoo Choi
2018-01-09 7:58 ` Chanwoo Choi
2018-01-09 11:52 ` Krzysztof Kozlowski
2018-01-09 11:52 ` Krzysztof Kozlowski
[not found] ` <CGME20180109075905epcas1p321b8898a0d45287d63364e1aa768fdab@epcas1p3.samsung.com>
2018-01-09 7:59 ` [PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state Chanwoo Choi
2018-01-09 7:59 ` Chanwoo Choi
2018-01-09 12:23 ` Krzysztof Kozlowski
2018-01-09 12:23 ` Krzysztof Kozlowski
2018-01-09 12:23 ` Krzysztof Kozlowski
2018-01-11 5:39 ` Chanwoo Choi
2018-01-11 5:39 ` Chanwoo Choi
2018-01-11 5:39 ` Chanwoo Choi
2018-01-09 12:33 ` Krzysztof Kozlowski
2018-01-09 12:33 ` Krzysztof Kozlowski
2018-01-09 14:11 ` Sudeep Holla
2018-01-09 14:11 ` Sudeep Holla
2018-01-10 1:46 ` Chanwoo Choi
2018-01-10 1:46 ` Chanwoo Choi
2018-01-10 10:53 ` Sudeep Holla
2018-01-10 10:53 ` Sudeep Holla
2018-01-10 10:53 ` Sudeep Holla
2018-01-10 23:51 ` Chanwoo Choi
2018-01-10 23:51 ` Chanwoo Choi
[not found] ` <CGME20180109075905epcas1p40431a90ecc3530f2200ade028bf54594@epcas1p4.samsung.com>
2018-01-09 7:59 ` [RFC PATCH 4/9] soc: samsung: Add generic power-management driver for Exynos Chanwoo Choi
2018-01-09 7:59 ` Chanwoo Choi
2018-01-09 12:37 ` Krzysztof Kozlowski
2018-01-09 12:37 ` Krzysztof Kozlowski
2018-01-11 5:44 ` Chanwoo Choi
2018-01-11 5:44 ` Chanwoo Choi
[not found] ` <CGME20180109075905epcas2p1fe6b554b646dbc80e04273ad6dd8489c@epcas2p1.samsung.com>
2018-01-09 7:59 ` [RFC PATCH 5/9] soc: samsung: pm: Add support for suspend-to-ram of Exynos5433 Chanwoo Choi
2018-01-09 7:59 ` Chanwoo Choi
2018-01-09 12:45 ` Krzysztof Kozlowski
2018-01-09 12:45 ` Krzysztof Kozlowski
2018-01-09 12:45 ` Krzysztof Kozlowski
2018-01-11 5:40 ` Chanwoo Choi
2018-01-11 5:40 ` Chanwoo Choi
[not found] ` <CGME20180109075905epcas2p4aa0174854c0796cc7fa75bdf8a273791@epcas2p4.samsung.com>
2018-01-09 7:59 ` [PATCH 6/9] arm64: dts: exynos: Add iRAM device-tree node for Exynos5433 Chanwoo Choi
2018-01-09 7:59 ` Chanwoo Choi
2018-01-09 12:46 ` Krzysztof Kozlowski
2018-01-09 12:46 ` Krzysztof Kozlowski
2018-01-09 12:46 ` Krzysztof Kozlowski
[not found] ` <CGME20180109075905epcas2p156b0f057a13fe5ab96753bf77f2bf652@epcas2p1.samsung.com>
2018-01-09 7:59 ` [PATCH 7/9] arm64: dts: exynos: Use power key as a wakeup source on TM2/TM2E board Chanwoo Choi
2018-01-09 7:59 ` Chanwoo Choi
[not found] ` <CGME20180109075906epcas1p15df259f70311dd96fc2c9ff256b2b615@epcas1p1.samsung.com>
2018-01-09 7:59 ` [PATCH 8/9] arm64: dts: exynos: Add cpu_suspend property of PSCI for exynos5433 Chanwoo Choi
2018-01-09 7:59 ` Chanwoo Choi
2018-01-09 7:59 ` Chanwoo Choi
[not found] ` <CGME20180109075906epcas1p288212118a5d58bc15d62a2d828772a49@epcas1p2.samsung.com>
2018-01-09 7:59 ` [PATCH 9/9] arm64: dts: exynos: Add cpu topology information for Exynos5433 SoC Chanwoo Choi
2018-01-09 7:59 ` Chanwoo Choi
2018-01-09 11:56 ` [RFC PATCH 0/9] soc: samsung: Add support of suspend-to-RAM on Exynos5433 Krzysztof Kozlowski
2018-01-09 11:56 ` Krzysztof Kozlowski
2018-01-10 9:19 ` Chanwoo Choi [this message]
2018-01-10 9:19 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A55DAB6.2020808@samsung.com \
--to=cw00.choi@samsung.com \
--cc=chanwoo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inki.dae@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.