From: JeffyChen <jeffy.chen@rock-chips.com> To: Daniel Kurtz <djkurtz@chromium.org> Cc: linux-kernel@vger.kernel.org, Ricky Liang <jcliang@chromium.org>, Robin Murphy <robin.murphy@arm.com>, xxm <xxm@rock-chips.com>, Tomasz Figa <tfiga@chromium.org>, Heiko Stuebner <heiko@sntech.de>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 11/14] iommu/rockchip: Use OF_IOMMU to attach devices automatically Date: Wed, 04 Apr 2018 19:10:20 +0800 [thread overview] Message-ID: <5AC4B29C.8090002@rock-chips.com> (raw) In-Reply-To: <CAGS+omCN7cXY0APvFuL_wmZeXihivu4hF0+ZfLFffvdZyK9f6A@mail.gmail.com> Hi Daniel, Thanks for your reply. On 04/04/2018 12:11 AM, Daniel Kurtz wrote: > Hi Jeffy, > > Sorry for delayed response. > > On Mon, Mar 26, 2018 at 1:58 AM JeffyChen <jeffy.chen@rock-chips.com> wrote: > >> Hi Daniel, > >> Thanks for your reply. > >> On 03/26/2018 02:31 PM, Daniel Kurtz wrote: >>>>> +struct rk_iommudata { >>>>> + struct rk_iommu *iommu; >>>>> +}; >>> Why do we need this struct? Can't we just assign a pointer to struct >>> rk_iommu directly to dev->archdata.iommu? >>> >> hmmm, i was trying to add more device related data in patch[13]: > >> struct rk_iommudata { >> + struct device_link *link; /* runtime PM link from IOMMU to master > */ >> struct rk_iommu *iommu; >> }; >>> > > Can't you just add link to rk_iommu directly? adding link to rk_iommu would be fine if we only have one master device per rk_iommu. but now we are supporting multiple master devices sharing a iommu device :) > > >
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (JeffyChen) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v8 11/14] iommu/rockchip: Use OF_IOMMU to attach devices automatically Date: Wed, 04 Apr 2018 19:10:20 +0800 [thread overview] Message-ID: <5AC4B29C.8090002@rock-chips.com> (raw) In-Reply-To: <CAGS+omCN7cXY0APvFuL_wmZeXihivu4hF0+ZfLFffvdZyK9f6A@mail.gmail.com> Hi Daniel, Thanks for your reply. On 04/04/2018 12:11 AM, Daniel Kurtz wrote: > Hi Jeffy, > > Sorry for delayed response. > > On Mon, Mar 26, 2018 at 1:58 AM JeffyChen <jeffy.chen@rock-chips.com> wrote: > >> Hi Daniel, > >> Thanks for your reply. > >> On 03/26/2018 02:31 PM, Daniel Kurtz wrote: >>>>> +struct rk_iommudata { >>>>> + struct rk_iommu *iommu; >>>>> +}; >>> Why do we need this struct? Can't we just assign a pointer to struct >>> rk_iommu directly to dev->archdata.iommu? >>> >> hmmm, i was trying to add more device related data in patch[13]: > >> struct rk_iommudata { >> + struct device_link *link; /* runtime PM link from IOMMU to master > */ >> struct rk_iommu *iommu; >> }; >>> > > Can't you just add link to rk_iommu directly? adding link to rk_iommu would be fine if we only have one master device per rk_iommu. but now we are supporting multiple master devices sharing a iommu device :) > > >
next prev parent reply other threads:[~2018-04-04 11:10 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-23 7:38 [PATCH v8 00/14] iommu/rockchip: Use OF_IOMMU Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 01/14] iommu/rockchip: Prohibit unbind and remove Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 02/14] iommu/rockchip: Fix error handling in probe Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 03/14] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 04/14] iommu/rockchip: Fix error handling in attach Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 05/14] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 06/14] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 07/14] ARM: dts: rockchip: add clocks in iommu nodes Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-04-09 14:41 ` Tomeu Vizoso 2018-04-09 14:41 ` Tomeu Vizoso 2018-04-09 14:41 ` Tomeu Vizoso 2018-04-09 15:44 ` Heiko Stübner 2018-04-09 15:44 ` Heiko Stübner 2018-04-09 15:44 ` Heiko Stübner 2018-04-09 15:53 ` Robin Murphy 2018-04-09 15:53 ` Robin Murphy 2018-04-09 15:53 ` Robin Murphy 2018-04-09 15:55 ` Heiko Stübner 2018-04-09 15:55 ` Heiko Stübner 2018-04-09 15:55 ` Heiko Stübner 2018-04-09 21:49 ` Heiko Stübner 2018-04-09 21:49 ` Heiko Stübner 2018-04-09 21:49 ` Heiko Stübner 2018-04-10 10:54 ` Heiko Stuebner 2018-04-10 10:54 ` Heiko Stuebner 2018-04-10 10:54 ` Heiko Stuebner 2018-04-10 11:46 ` Heiko Stuebner 2018-04-10 11:46 ` Heiko Stuebner 2018-04-10 11:46 ` Heiko Stuebner 2018-03-23 7:38 ` [PATCH v8 08/14] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 09/14] dt-bindings: iommu/rockchip: Add clock property Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-25 23:52 ` Rob Herring 2018-03-25 23:52 ` Rob Herring 2018-03-25 23:52 ` Rob Herring 2018-03-23 7:38 ` [PATCH v8 10/14] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 11/14] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-26 6:31 ` Daniel Kurtz 2018-03-26 6:31 ` Daniel Kurtz 2018-03-26 6:31 ` Daniel Kurtz [not found] ` <CAGS+omDUve9DTMJY8FdWBBxQgCOACLYLsRuzmQzd3Fh7TeekDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-26 7:57 ` JeffyChen 2018-04-03 16:11 ` Daniel Kurtz 2018-04-03 16:11 ` Daniel Kurtz 2018-04-04 11:10 ` JeffyChen [this message] 2018-04-04 11:10 ` JeffyChen 2018-03-23 7:38 ` [PATCH v8 12/14] iommu/rockchip: Fix error handling in init Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 13/14] iommu/rockchip: Add runtime PM support Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` [PATCH v8 14/14] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-23 7:38 ` Jeffy Chen 2018-03-29 10:24 ` [PATCH v8 00/14] iommu/rockchip: Use OF_IOMMU Joerg Roedel 2018-03-29 10:24 ` Joerg Roedel 2018-03-29 10:24 ` Joerg Roedel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5AC4B29C.8090002@rock-chips.com \ --to=jeffy.chen@rock-chips.com \ --cc=djkurtz@chromium.org \ --cc=heiko@sntech.de \ --cc=jcliang@chromium.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=robin.murphy@arm.com \ --cc=tfiga@chromium.org \ --cc=xxm@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.