Re: [Xen-devel] [PATCH] xen: Remove event channel notification through Xen PCI platform device

From: "Raslan, KarimAllah" <karahmed@amazon.de>
To: David Vrabel <david.vrabel@citrix.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>,
	Ross Lagerwall <ross.lagerwall@citrix.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"Paul Gortmaker" <paul.gortmaker@windriver.com>,
	Julien Grall <julien.grall@citrix.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Liguori, Anthony" <aliguori@amazon.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen: Remove event channel notification through Xen PCI platform device
Date: Mon, 10 Apr 2017 12:28:38 +0000	[thread overview]
Message-ID: <5E59C7DE-9640-4D97-A633-BFFDC4BF1352@amazon.de> (raw)
In-Reply-To: <57EE7AB7.4020405@citrix.com>

Unfortunately, this commit is potentially a candidate for reverting. After a
lengthy qualification I realized that there is a function called:
"xen_strict_xenbus_quirk()" that is being called in the offending path that
short-circuits the offending code!

So at the moment any domU kernel with this commit will not boot on any Xen
version < 4.0!  So nobody with Xen < 4.0 was complaining not because nobody is
using it but rather because there is a short-circuit in the code that avoids
hitting the offending code in the first place! So the original assumption that
the code is dead might no be 100% correct!

So even though the code for INTx is broken for any Xen > 4.0, the right thing
to do now is to actually fix the INTx properly and completely revert this
commit (actually now also commit da72ff5bfcb0 needs to be reverted to cleanly
revert this commit) to avoid any potential regression.

David,
Does this make sense to you?

I will send a patch to fix INTx shortly as well.

On 9/30/16, 4:46 PM, "David Vrabel" <david.vrabel@citrix.com> wrote:

    On 26/08/16 22:55, KarimAllah Ahmed wrote:
    > Ever since commit 254d1a3f02eb ("xen/pv-on-hvm kexec: shutdown watches
    > from old kernel") using the INTx interrupt from Xen PCI platform device for
    > event channel notification would just lockup the guest during bootup.
    > postcore_initcall now calls xs_reset_watches which will eventually try to read
    > a value from XenStore and will get stuck on read_reply at XenBus forever since
    > the platform driver is not probed yet and its INTx interrupt handler is not
    > registered yet. That means that the guest can not be notified at this moment of
    > any pending event channels and none of the per-event handlers will ever be
    > invoked (including the XenStore one) and the reply will never be picked up by
    > the kernel.

    Applied to for-linus-4.9, thanks.

    David

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B