From: "Martin Povišer" <povik+lin@cutebit.org>
To: wangweidong.a@awinic.com
Cc: cezary.rojewski@intel.com, steve@sk2.org, llvm@lists.linux.dev,
Linux-ALSA <alsa-devel@alsa-project.org>,
linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org,
krzysztof.kozlowski+dt@linaro.org, yangxiaohua@everest-semi.com,
lkp@intel.com, daniel.beer@igorinstitute.com,
pierre-louis.bossart@linux.intel.com, flatmax@flatmax.com,
devicetree@vger.kernel.org, ckeepax@opensource.cirrus.com,
zhaolei@awinic.com, james.schulman@cirrus.com,
rf@opensource.cirrus.com, robh+dt@kernel.org,
oe-kbuild-all@lists.linux.dev, jonathan.albrieux@gmail.com,
tiwai@suse.com, liweilei@awinic.com, lgirdwood@gmail.com,
yijiangtao@awinic.com, Mark Brown <broonie@kernel.org>,
13691752556@139.com
Subject: Re: [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile
Date: Wed, 11 Jan 2023 09:38:47 +0100 [thread overview]
Message-ID: <5EA7B038-9B49-4E5D-8209-8689C0D03071@cutebit.org> (raw)
In-Reply-To: <20230111020233.4306-1-wangweidong.a@awinic.com>
> On 11. 1. 2023, at 3:02, wangweidong.a@awinic.com wrote:
>
> On 09/01/2023 03:00, kernel test robot wrote:
>> All errors (new ones prefixed by >>):
>
>>>> ld.lld: error: undefined symbol: crc8_populate_lsb
>>>>> referenced by aw883xx_bin_parse.c:1049 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1049)
>>>>> vmlinux.o:(aw883xx_dev_load_acf_check)
>> --
>>>> ld.lld: error: undefined symbol: crc8
>>>>> referenced by aw883xx_bin_parse.c:963 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:963)
>>>>> vmlinux.o:(aw883xx_dev_load_acf_check)
>>>>> referenced by aw883xx_bin_parse.c:1022 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1022)
>>>>> vmlinux.o:(aw883xx_dev_load_acf_check)
>>>>> did you mean: crc4
>>>>> defined in: vmlinux.o
>
> This looks like a false positive. crc8_populate_lsb is defined in the lib/crc8.c file.
> I also could not reproduce it with GCC.
Hi,
the issue here would be that it’s possible to select your driver for compilation without
having selected the CRC8 functions, leading to the linkage error.
You can fix that by adding ’select CRC8’ under the Kconfig section of your driver, similarly
to how the SND_SOC_SIGMADSP symbol selects CRC32.
Best regards,
Martin
>
> Best regards,
> Weidong Wang
WARNING: multiple messages have this Message-ID (diff)
From: "Martin Povišer" <povik+lin@cutebit.org>
To: wangweidong.a@awinic.com
Cc: lkp@intel.com, 13691752556@139.com,
Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
cezary.rojewski@intel.com, ckeepax@opensource.cirrus.com,
daniel.beer@igorinstitute.com, devicetree@vger.kernel.org,
flatmax@flatmax.com, james.schulman@cirrus.com,
jonathan.albrieux@gmail.com, krzysztof.kozlowski+dt@linaro.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
liweilei@awinic.com, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, rf@opensource.cirrus.com,
robh+dt@kernel.org, srinivas.kandagatla@linaro.org,
steve@sk2.org, tiwai@suse.com, yangxiaohua@everest-semi.com,
yijiangtao@awinic.com, zhaolei@awinic.com
Subject: Re: [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile
Date: Wed, 11 Jan 2023 09:38:47 +0100 [thread overview]
Message-ID: <5EA7B038-9B49-4E5D-8209-8689C0D03071@cutebit.org> (raw)
In-Reply-To: <20230111020233.4306-1-wangweidong.a@awinic.com>
> On 11. 1. 2023, at 3:02, wangweidong.a@awinic.com wrote:
>
> On 09/01/2023 03:00, kernel test robot wrote:
>> All errors (new ones prefixed by >>):
>
>>>> ld.lld: error: undefined symbol: crc8_populate_lsb
>>>>> referenced by aw883xx_bin_parse.c:1049 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1049)
>>>>> vmlinux.o:(aw883xx_dev_load_acf_check)
>> --
>>>> ld.lld: error: undefined symbol: crc8
>>>>> referenced by aw883xx_bin_parse.c:963 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:963)
>>>>> vmlinux.o:(aw883xx_dev_load_acf_check)
>>>>> referenced by aw883xx_bin_parse.c:1022 (sound/soc/codecs/aw883xx/aw883xx_bin_parse.c:1022)
>>>>> vmlinux.o:(aw883xx_dev_load_acf_check)
>>>>> did you mean: crc4
>>>>> defined in: vmlinux.o
>
> This looks like a false positive. crc8_populate_lsb is defined in the lib/crc8.c file.
> I also could not reproduce it with GCC.
Hi,
the issue here would be that it’s possible to select your driver for compilation without
having selected the CRC8 functions, leading to the linkage error.
You can fix that by adding ’select CRC8’ under the Kconfig section of your driver, similarly
to how the SND_SOC_SIGMADSP symbol selects CRC32.
Best regards,
Martin
>
> Best regards,
> Weidong Wang
next prev parent reply other threads:[~2023-01-11 8:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 3:28 [PATCH V9 0/5] ASoC: codecs: Add Awinic AW883XX audio amplifier driver wangweidong.a
2023-01-06 3:28 ` wangweidong.a
2023-01-06 3:28 ` [PATCH V9 1/5] ASoC: codecs: Add i2c and codec registration for aw883xx and their associated operation functions wangweidong.a
2023-01-06 3:28 ` wangweidong.a
2023-01-06 3:28 ` [PATCH V9 2/5] ASoC: codecs: Aw883xx function for ACF file parse and check wangweidong.a
2023-01-06 3:28 ` wangweidong.a
2023-01-06 3:28 ` [PATCH V9 3/5] ASoC: codecs: Aw883xx common function for ALSA Audio Driver wangweidong.a
2023-01-06 3:28 ` wangweidong.a
2023-01-06 3:28 ` [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile wangweidong.a
2023-01-06 3:28 ` wangweidong.a
2023-01-06 12:40 ` kernel test robot
2023-01-06 12:40 ` kernel test robot
2023-01-09 19:00 ` kernel test robot
2023-01-09 19:00 ` kernel test robot
2023-01-11 2:02 ` wangweidong.a
2023-01-11 2:02 ` wangweidong.a
2023-01-11 8:38 ` Martin Povišer [this message]
2023-01-11 8:38 ` Martin Povišer
2023-01-13 3:46 ` wangweidong.a
2023-01-13 3:46 ` wangweidong.a
2023-01-11 8:53 ` Krzysztof Kozlowski
2023-01-11 8:53 ` Krzysztof Kozlowski
2023-01-06 3:28 ` [PATCH V9 5/5] ASoC: dt-bindings: Add schema for "awinic,aw88395" wangweidong.a
2023-01-06 3:28 ` wangweidong.a
2023-01-06 8:30 ` Krzysztof Kozlowski
2023-01-06 8:30 ` [PATCH V9 5/5] ASoC: dt-bindings: Add schema for "awinic, aw88395" Krzysztof Kozlowski
2023-01-08 13:31 [PATCH V9 4/5] ASoC: codecs: Aw883xx chip register file, data type file and Kconfig Makefile kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EA7B038-9B49-4E5D-8209-8689C0D03071@cutebit.org \
--to=povik+lin@cutebit.org \
--cc=13691752556@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=daniel.beer@igorinstitute.com \
--cc=devicetree@vger.kernel.org \
--cc=flatmax@flatmax.com \
--cc=james.schulman@cirrus.com \
--cc=jonathan.albrieux@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=steve@sk2.org \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=yangxiaohua@everest-semi.com \
--cc=yijiangtao@awinic.com \
--cc=zhaolei@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.