From: Joe Perches <joe@perches.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
shuah <shuah@kernel.org>, Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <linux@arm.linux.org.uk>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Chris Lameter <cl@linux.com>,
Ben Maurer <bmaurer@fb.com>, rostedt <rostedt@goodmis.org>,
Josh Triplett <josh@joshtriplett.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Joel Fernandes <joelaf@google.com>
Subject: Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates
Date: Fri, 03 May 2019 14:46:17 -0700 [thread overview]
Message-ID: <5a671727418034dd1de54ad67f3f028f3cde9516.camel@perches.com> (raw)
In-Reply-To: <1137649333.995.1556911352713.JavaMail.zimbra@efficios.com>
On Fri, 2019-05-03 at 15:22 -0400, Mathieu Desnoyers wrote:
> ----- On May 3, 2019, at 2:53 PM, shuah shuah@kernel.org wrote:
> > ERROR: need consistent spacing around '%' (ctx:WxV)
> > #227: FILE: tools/testing/selftests/rseq/rseq-x86.h:104:
> > + RSEQ_ASM_CMP_CPU_ID(cpu_id, RSEQ_CPU_ID_OFFSET(%[rseq_abi]), %l[error1])
> >
> > Will you be able to fix them and resend?
[]
> (CCing the che checkpatch maintainers)
>
> checkpatch appears to be wrong for these errors. I suspect it thinks those are
> '%' modulo operators (for which the style requires space before/after),
> but those are actually part of the asm input and goto target operands.
checkpatch doesn't really understand asm.
Ignore checkpatch when it's silly.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
shuah <shuah@kernel.org>, Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Andy Lutomirski <luto@amacapital.net>,
Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <linux@arm.linux.org.uk>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Chris Lameter <cl@linux.com>,
Ben Maurer <bmaurer@fb.com>, rostedt <rostedt@goodmis.org>,
Josh Triplett <josh@joshtriplett.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will
Subject: Re: [PATCH for 5.2 00/12] Restartable Sequences selftests updates
Date: Fri, 03 May 2019 14:46:17 -0700 [thread overview]
Message-ID: <5a671727418034dd1de54ad67f3f028f3cde9516.camel@perches.com> (raw)
In-Reply-To: <1137649333.995.1556911352713.JavaMail.zimbra@efficios.com>
On Fri, 2019-05-03 at 15:22 -0400, Mathieu Desnoyers wrote:
> ----- On May 3, 2019, at 2:53 PM, shuah shuah@kernel.org wrote:
> > ERROR: need consistent spacing around '%' (ctx:WxV)
> > #227: FILE: tools/testing/selftests/rseq/rseq-x86.h:104:
> > + RSEQ_ASM_CMP_CPU_ID(cpu_id, RSEQ_CPU_ID_OFFSET(%[rseq_abi]), %l[error1])
> >
> > Will you be able to fix them and resend?
[]
> (CCing the che checkpatch maintainers)
>
> checkpatch appears to be wrong for these errors. I suspect it thinks those are
> '%' modulo operators (for which the style requires space before/after),
> but those are actually part of the asm input and goto target operands.
checkpatch doesn't really understand asm.
Ignore checkpatch when it's silly.
next prev parent reply other threads:[~2019-05-03 21:46 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 15:27 [PATCH for 5.2 00/12] Restartable Sequences selftests updates Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` [PATCH for 5.2 01/12] rseq/selftests: x86: Work-around bogus gcc-8 optimisation Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` mathieu.desnoyers
2019-04-29 15:27 ` [PATCH for 5.2 02/12] rseq/selftests: Add __rseq_exit_point_array section for debuggers Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` mathieu.desnoyers
2019-04-29 15:27 ` [PATCH for 5.2 03/12] rseq/selftests: Introduce __rseq_cs_ptr_array, rename __rseq_table to __rseq_cs Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` mathieu.desnoyers
2019-04-29 15:27 ` [PATCH for 5.2 04/12] rseq/selftests: Use __rseq_handled symbol to coexist with glibc Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` [PATCH for 5.2 05/12] rseq/selftests: s390: use jg instruction for jumps outside of the asm Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` mathieu.desnoyers
2019-04-29 15:27 ` [PATCH for 5.2 06/12] rseq/selftests: x86: use ud1 instruction as RSEQ_SIG opcode Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` mathieu.desnoyers
2019-04-29 15:27 ` [PATCH for 5.2 07/12] rseq/selftests: s390: use trap4 for RSEQ_SIG Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-05-16 20:39 ` shuah
2019-05-16 20:39 ` shuah
2019-05-16 20:49 ` Mathieu Desnoyers
2019-05-16 20:49 ` Mathieu Desnoyers
2019-04-29 15:27 ` [PATCH for 5.2 08/12] rseq/selftests: arm: use udf instruction " Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` Mathieu Desnoyers
2019-04-29 15:27 ` mathieu.desnoyers
2019-05-03 19:38 ` [PATCH v2 " Mathieu Desnoyers
2019-05-03 19:38 ` Mathieu Desnoyers
2019-05-03 19:38 ` Mathieu Desnoyers
2019-05-03 19:38 ` mathieu.desnoyers
2019-06-06 18:02 ` Mathieu Desnoyers
2019-06-06 18:02 ` Mathieu Desnoyers
2019-06-06 18:02 ` Mathieu Desnoyers
2019-06-06 18:02 ` Mathieu Desnoyers
2019-06-06 18:02 ` mathieu.desnoyers
2019-06-08 15:52 ` Mathieu Desnoyers
2019-06-08 15:52 ` Mathieu Desnoyers
2019-06-08 15:52 ` Mathieu Desnoyers
2019-06-08 15:52 ` Mathieu Desnoyers
2019-06-08 15:52 ` mathieu.desnoyers
2019-04-29 15:28 ` [PATCH for 5.2 09/12] rseq/selftests: aarch64 code signature: handle big-endian environment Mathieu Desnoyers
2019-04-29 15:28 ` Mathieu Desnoyers
2019-04-29 15:28 ` Mathieu Desnoyers
2019-04-29 15:28 ` mathieu.desnoyers
2019-04-29 15:28 ` [PATCH for 5.2 10/12] rseq/selftests: powerpc code signature: generate valid instructions Mathieu Desnoyers
2019-04-29 15:28 ` Mathieu Desnoyers
2019-04-29 15:28 ` Mathieu Desnoyers
2019-04-29 15:28 ` [PATCH for 5.2 11/12] rseq/selftests: mips: use break instruction for RSEQ_SIG Mathieu Desnoyers
2019-04-29 15:28 ` Mathieu Desnoyers
2019-04-29 15:28 ` [PATCH for 5.2 12/12] rseq/selftests: add -no-integrated-as for clang Mathieu Desnoyers
2019-04-29 15:28 ` Mathieu Desnoyers
2019-04-29 15:28 ` Mathieu Desnoyers
2019-04-29 15:28 ` mathieu.desnoyers
2019-04-29 17:03 ` Nick Desaulniers
2019-04-29 17:03 ` Nick Desaulniers
2019-04-29 17:03 ` Nick Desaulniers
2019-04-29 17:03 ` ndesaulniers
2019-04-29 20:28 ` Mathieu Desnoyers
2019-04-29 20:28 ` Mathieu Desnoyers
2019-04-29 20:28 ` Mathieu Desnoyers
2019-04-29 20:28 ` mathieu.desnoyers
2019-04-29 20:30 ` Nick Desaulniers
2019-04-29 20:30 ` Nick Desaulniers
2019-04-29 20:30 ` Nick Desaulniers
2019-04-29 20:30 ` ndesaulniers
2019-05-03 18:36 ` [PATCH for 5.2 00/12] Restartable Sequences selftests updates Mathieu Desnoyers
2019-05-03 18:36 ` Mathieu Desnoyers
2019-05-03 18:53 ` shuah
2019-05-03 18:53 ` shuah
2019-05-03 19:22 ` Mathieu Desnoyers
2019-05-03 19:22 ` Mathieu Desnoyers
2019-05-03 21:46 ` Joe Perches [this message]
2019-05-03 21:46 ` Joe Perches
2019-05-03 22:59 ` shuah
2019-05-03 22:59 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a671727418034dd1de54ad67f3f028f3cde9516.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=apw@canonical.com \
--cc=bmaurer@fb.com \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=davejwatson@fb.com \
--cc=hpa@zytor.com \
--cc=joelaf@google.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=luto@amacapital.net \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.