From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Will Deacon <will@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, stable@vger.kernel.org, James Morse <james.morse@arm.com>, Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Subject: Re: [PATCH] arm64: Extend workaround for erratum 1024718 to all versions of Cortex-A55 Date: Fri, 5 Feb 2021 17:41:05 +0000 [thread overview] Message-ID: <5a8ea892-98bb-e02e-cced-9ffa7e0bbda9@arm.com> (raw) In-Reply-To: <20210204095457.GA20361@willie-the-truck> Hi Will On 2/4/21 9:54 AM, Will Deacon wrote: > Hi Suzuki, > > On Wed, Feb 03, 2021 at 11:00:57PM +0000, Suzuki K Poulose wrote: >> The erratum 1024718 affects Cortex-A55 r0p0 to r2p0. However >> we apply the work around for r0p0 - r1p0. Unfortunately this >> won't be fixed for the future revisions for the CPU. Thus >> extend the work around for all versions of A55, to cover >> for r2p0 and any future revisions. >> >> Cc: stable@vger.kernel.org >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will@kernel.org> >> Cc: James Morse <james.morse@arm.com> >> Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> --- >> arch/arm64/kernel/cpufeature.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c >> index e99eddec0a46..db400ca77427 100644 >> --- a/arch/arm64/kernel/cpufeature.c >> +++ b/arch/arm64/kernel/cpufeature.c >> @@ -1455,7 +1455,7 @@ static bool cpu_has_broken_dbm(void) >> /* List of CPUs which have broken DBM support. */ >> static const struct midr_range cpus[] = { >> #ifdef CONFIG_ARM64_ERRATUM_1024718 >> - MIDR_RANGE(MIDR_CORTEX_A55, 0, 0, 1, 0), // A55 r0p0 -r1p0 >> + MIDR_ALL_VERSIONS(MIDR_CORTEX_A55), > > I think we have bigger problems with this erratum, since cpu_has_hw_af() > doesn't taken this erratum into account at all, meaning that > arch_faults_on_old_pte() will return the wrong value on any system with an > A55. Please note that we enable HW_AF on these CPUs even with this erratum as they are not affected. It is only the DBM that we selectively disable. Thus the AF flag checks are still valid (See __cpu_setup in arch/arm64/mm/proc.S). Or am I miss something ? Kind regards Suzuki > > Please can you fix that along with this patch? You'll need to pay extra > attention to the stuff I've queued on for-next/faultaround, where we will > actually want arch_wants_old_prefaulted_pte() to return 'true' if any of the > CPUs have DBM, since it's a pure performance thing. > > Cheers, > > Will >
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Will Deacon <will@kernel.org> Cc: catalin.marinas@arm.com, Kunihiko Hayashi <hayashi.kunihiko@socionext.com>, James Morse <james.morse@arm.com>, stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: Extend workaround for erratum 1024718 to all versions of Cortex-A55 Date: Fri, 5 Feb 2021 17:41:05 +0000 [thread overview] Message-ID: <5a8ea892-98bb-e02e-cced-9ffa7e0bbda9@arm.com> (raw) In-Reply-To: <20210204095457.GA20361@willie-the-truck> Hi Will On 2/4/21 9:54 AM, Will Deacon wrote: > Hi Suzuki, > > On Wed, Feb 03, 2021 at 11:00:57PM +0000, Suzuki K Poulose wrote: >> The erratum 1024718 affects Cortex-A55 r0p0 to r2p0. However >> we apply the work around for r0p0 - r1p0. Unfortunately this >> won't be fixed for the future revisions for the CPU. Thus >> extend the work around for all versions of A55, to cover >> for r2p0 and any future revisions. >> >> Cc: stable@vger.kernel.org >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will@kernel.org> >> Cc: James Morse <james.morse@arm.com> >> Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> --- >> arch/arm64/kernel/cpufeature.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c >> index e99eddec0a46..db400ca77427 100644 >> --- a/arch/arm64/kernel/cpufeature.c >> +++ b/arch/arm64/kernel/cpufeature.c >> @@ -1455,7 +1455,7 @@ static bool cpu_has_broken_dbm(void) >> /* List of CPUs which have broken DBM support. */ >> static const struct midr_range cpus[] = { >> #ifdef CONFIG_ARM64_ERRATUM_1024718 >> - MIDR_RANGE(MIDR_CORTEX_A55, 0, 0, 1, 0), // A55 r0p0 -r1p0 >> + MIDR_ALL_VERSIONS(MIDR_CORTEX_A55), > > I think we have bigger problems with this erratum, since cpu_has_hw_af() > doesn't taken this erratum into account at all, meaning that > arch_faults_on_old_pte() will return the wrong value on any system with an > A55. Please note that we enable HW_AF on these CPUs even with this erratum as they are not affected. It is only the DBM that we selectively disable. Thus the AF flag checks are still valid (See __cpu_setup in arch/arm64/mm/proc.S). Or am I miss something ? Kind regards Suzuki > > Please can you fix that along with this patch? You'll need to pay extra > attention to the stuff I've queued on for-next/faultaround, where we will > actually want arch_wants_old_prefaulted_pte() to return 'true' if any of the > CPUs have DBM, since it's a pure performance thing. > > Cheers, > > Will > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-05 19:12 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-03 23:00 [PATCH] arm64: Extend workaround for erratum 1024718 to all versions of Cortex-A55 Suzuki K Poulose 2021-02-03 23:00 ` Suzuki K Poulose 2021-02-04 9:54 ` Will Deacon 2021-02-04 9:54 ` Will Deacon 2021-02-05 17:41 ` Suzuki K Poulose [this message] 2021-02-05 17:41 ` Suzuki K Poulose 2021-02-08 12:29 ` Will Deacon 2021-02-08 12:29 ` Will Deacon 2021-02-08 14:55 ` Will Deacon 2021-02-08 14:55 ` Will Deacon 2021-03-01 12:15 FAILED: patch "[PATCH] arm64: Extend workaround for erratum 1024718 to all versions" failed to apply to 5.4-stable tree gregkh 2021-03-01 12:54 ` [PATCH] arm64: Extend workaround for erratum 1024718 to all versions of Cortex-A55 Suzuki K Poulose
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5a8ea892-98bb-e02e-cced-9ffa7e0bbda9@arm.com \ --to=suzuki.poulose@arm.com \ --cc=catalin.marinas@arm.com \ --cc=hayashi.kunihiko@socionext.com \ --cc=james.morse@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=stable@vger.kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.