From: Robin Murphy <robin.murphy@arm.com>
To: Will Deacon <will@kernel.org>
Cc: joro@8bytes.org, iommu@lists.linux-foundation.org,
sven@svenpeter.dev, robdclark@gmail.com,
m.szyprowski@samsung.com, baolu.lu@linux.intel.com,
yong.wu@mediatek.com, mjrosato@linux.ibm.com,
gerald.schaefer@linux.ibm.com, zhang.lyra@gmail.com,
thierry.reding@gmail.com, vdumpa@nvidia.com,
jean-philippe@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/13] iommu/arm-smmu: Clean up bus_set_iommu()
Date: Wed, 20 Apr 2022 17:05:03 +0100 [thread overview]
Message-ID: <5ae51610-5027-777e-36e3-7bdb92e00752@arm.com> (raw)
In-Reply-To: <20220419144042.GA6186@willie-the-truck>
On 2022-04-19 15:40, Will Deacon wrote:
> On Thu, Apr 14, 2022 at 01:42:33PM +0100, Robin Murphy wrote:
>> Stop calling bus_set_iommu() since it's now unnecessary. With device
>> probes now replayed for every IOMMU instance registration, the whole
>> sorry ordering workaround for legacy DT bindings goes too, hooray!
>
> Ha, I hope you tested this!
Oh alright then, since it's you... :)
I've hacked up a Juno DT with the old bindings, and (after needing a
while to remember that they're fundamentally incompatible with
disable_bypass), can confirm that with my whole dev branch including
this series applied, it boots and creates IOMMU groups as expected. I
then made the mistake of trying without the branch to check whether the
squawks from iommu_setup_dma_ops() were new or not, and... well... plain
rc3 doesn't even boot on the same setup - it's somehow blowing up in the
failure cleanup path of iommu_bus_init(), apparently calling
iommu_release_device() on something where dev->iommu->iommu_dev is NULL,
for reasons that are far from clear and I'm not sure I can really be
bothered to debug further... :/
Cheers,
Robin.
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>> drivers/iommu/arm/arm-smmu/arm-smmu.c | 84 +--------------------------
>> 1 file changed, 2 insertions(+), 82 deletions(-)
>
> Assuming it works,
>
> Acked-by: Will Deacon <will@kernel.org>
>
> Will
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Will Deacon <will@kernel.org>
Cc: jean-philippe@linaro.org, zhang.lyra@gmail.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org,
gerald.schaefer@linux.ibm.com
Subject: Re: [PATCH 04/13] iommu/arm-smmu: Clean up bus_set_iommu()
Date: Wed, 20 Apr 2022 17:05:03 +0100 [thread overview]
Message-ID: <5ae51610-5027-777e-36e3-7bdb92e00752@arm.com> (raw)
In-Reply-To: <20220419144042.GA6186@willie-the-truck>
On 2022-04-19 15:40, Will Deacon wrote:
> On Thu, Apr 14, 2022 at 01:42:33PM +0100, Robin Murphy wrote:
>> Stop calling bus_set_iommu() since it's now unnecessary. With device
>> probes now replayed for every IOMMU instance registration, the whole
>> sorry ordering workaround for legacy DT bindings goes too, hooray!
>
> Ha, I hope you tested this!
Oh alright then, since it's you... :)
I've hacked up a Juno DT with the old bindings, and (after needing a
while to remember that they're fundamentally incompatible with
disable_bypass), can confirm that with my whole dev branch including
this series applied, it boots and creates IOMMU groups as expected. I
then made the mistake of trying without the branch to check whether the
squawks from iommu_setup_dma_ops() were new or not, and... well... plain
rc3 doesn't even boot on the same setup - it's somehow blowing up in the
failure cleanup path of iommu_bus_init(), apparently calling
iommu_release_device() on something where dev->iommu->iommu_dev is NULL,
for reasons that are far from clear and I'm not sure I can really be
bothered to debug further... :/
Cheers,
Robin.
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>> drivers/iommu/arm/arm-smmu/arm-smmu.c | 84 +--------------------------
>> 1 file changed, 2 insertions(+), 82 deletions(-)
>
> Assuming it works,
>
> Acked-by: Will Deacon <will@kernel.org>
>
> Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Will Deacon <will@kernel.org>
Cc: jean-philippe@linaro.org, mjrosato@linux.ibm.com,
sven@svenpeter.dev, zhang.lyra@gmail.com, joro@8bytes.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
robdclark@gmail.com, thierry.reding@gmail.com,
linux-arm-kernel@lists.infradead.org,
gerald.schaefer@linux.ibm.com, baolu.lu@linux.intel.com,
yong.wu@mediatek.com, m.szyprowski@samsung.com
Subject: Re: [PATCH 04/13] iommu/arm-smmu: Clean up bus_set_iommu()
Date: Wed, 20 Apr 2022 17:05:03 +0100 [thread overview]
Message-ID: <5ae51610-5027-777e-36e3-7bdb92e00752@arm.com> (raw)
In-Reply-To: <20220419144042.GA6186@willie-the-truck>
On 2022-04-19 15:40, Will Deacon wrote:
> On Thu, Apr 14, 2022 at 01:42:33PM +0100, Robin Murphy wrote:
>> Stop calling bus_set_iommu() since it's now unnecessary. With device
>> probes now replayed for every IOMMU instance registration, the whole
>> sorry ordering workaround for legacy DT bindings goes too, hooray!
>
> Ha, I hope you tested this!
Oh alright then, since it's you... :)
I've hacked up a Juno DT with the old bindings, and (after needing a
while to remember that they're fundamentally incompatible with
disable_bypass), can confirm that with my whole dev branch including
this series applied, it boots and creates IOMMU groups as expected. I
then made the mistake of trying without the branch to check whether the
squawks from iommu_setup_dma_ops() were new or not, and... well... plain
rc3 doesn't even boot on the same setup - it's somehow blowing up in the
failure cleanup path of iommu_bus_init(), apparently calling
iommu_release_device() on something where dev->iommu->iommu_dev is NULL,
for reasons that are far from clear and I'm not sure I can really be
bothered to debug further... :/
Cheers,
Robin.
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>> drivers/iommu/arm/arm-smmu/arm-smmu.c | 84 +--------------------------
>> 1 file changed, 2 insertions(+), 82 deletions(-)
>
> Assuming it works,
>
> Acked-by: Will Deacon <will@kernel.org>
>
> Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-20 16:05 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220414124252eucas1p1f2d8689ef5d281ea70d619888108d2fe@eucas1p1.samsung.com>
2022-04-14 12:42 ` [PATCH 00/13] iommu: Retire bus_set_iommu() Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 01/13] iommu: Always register bus notifiers Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 02/13] iommu: Move bus setup to IOMMU device registration Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-16 0:04 ` Lu Baolu
2022-04-16 0:04 ` Lu Baolu
2022-04-16 0:04 ` Lu Baolu
2022-04-18 22:09 ` Robin Murphy
2022-04-18 22:09 ` Robin Murphy
2022-04-18 22:09 ` Robin Murphy
2022-04-18 23:37 ` Lu Baolu
2022-04-18 23:37 ` Lu Baolu
2022-04-18 23:37 ` Lu Baolu
2022-04-19 7:20 ` Robin Murphy
2022-04-19 7:20 ` Robin Murphy
2022-04-19 7:20 ` Robin Murphy
2022-04-19 10:13 ` Lu Baolu
2022-04-19 10:13 ` Lu Baolu
2022-04-19 10:13 ` Lu Baolu
2022-04-23 8:01 ` Lu Baolu
2022-04-23 8:01 ` Lu Baolu
2022-04-23 8:01 ` Lu Baolu
2022-04-23 8:37 ` Robin Murphy
2022-04-23 8:37 ` Robin Murphy
2022-04-23 8:37 ` Robin Murphy
2022-04-23 8:51 ` Lu Baolu
2022-04-23 8:51 ` Lu Baolu
2022-04-23 8:51 ` Lu Baolu
2022-04-23 9:00 ` Lu Baolu
2022-04-23 9:00 ` Lu Baolu
2022-04-23 9:00 ` Lu Baolu
2022-04-23 9:41 ` Lu Baolu
2022-04-23 9:41 ` Lu Baolu
2022-04-23 9:41 ` Lu Baolu
2022-04-22 18:37 ` Krishna Reddy via iommu
2022-04-22 18:37 ` Krishna Reddy
2022-04-22 18:37 ` Krishna Reddy
2022-04-22 19:02 ` Robin Murphy
2022-04-22 19:02 ` Robin Murphy
2022-04-22 19:02 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 03/13] iommu/amd: Clean up bus_set_iommu() Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 04/13] iommu/arm-smmu: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-19 14:40 ` Will Deacon
2022-04-19 14:40 ` Will Deacon
2022-04-19 14:40 ` Will Deacon
2022-04-20 16:05 ` Robin Murphy [this message]
2022-04-20 16:05 ` Robin Murphy
2022-04-20 16:05 ` Robin Murphy
2022-04-21 8:33 ` Will Deacon
2022-04-21 8:33 ` Will Deacon
2022-04-21 8:33 ` Will Deacon
2022-04-14 12:42 ` [PATCH 05/13] iommu/arm-smmu-v3: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-19 14:42 ` Will Deacon
2022-04-19 14:42 ` Will Deacon
2022-04-19 14:42 ` Will Deacon
2022-04-14 12:42 ` [PATCH 06/13] iommu/dart: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-15 14:28 ` Sven Peter
2022-04-15 14:28 ` Sven Peter via iommu
2022-04-15 14:28 ` Sven Peter
2022-04-14 12:42 ` [PATCH 07/13] iommu/exynos: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 08/13] iommu/ipmmu-vmsa: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 09/13] iommu/mtk: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 10/13] iommu/omap: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 11/13] iommu/tegra-smmu: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 12/13] iommu/virtio: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-21 17:12 ` Jean-Philippe Brucker
2022-04-21 17:12 ` Jean-Philippe Brucker
2022-04-21 17:12 ` Jean-Philippe Brucker
2022-04-21 19:44 ` Robin Murphy
2022-04-21 19:44 ` Robin Murphy
2022-04-21 19:44 ` Robin Murphy
2022-04-14 12:42 ` [PATCH 13/13] iommu: " Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 12:42 ` Robin Murphy
2022-04-14 21:00 ` [PATCH 00/13] iommu: Retire bus_set_iommu() Marek Szyprowski
2022-04-14 21:00 ` Marek Szyprowski
2022-04-14 21:00 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ae51610-5027-777e-36e3-7bdb92e00752@arm.com \
--to=robin.murphy@arm.com \
--cc=baolu.lu@linux.intel.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mjrosato@linux.ibm.com \
--cc=robdclark@gmail.com \
--cc=sven@svenpeter.dev \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.