From: Marc Zyngier <maz@kernel.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <treding@nvidia.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>, Will Deacon <will@kernel.org>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Michal Simek <michal.simek@xilinx.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: Aw: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling
Date: Mon, 01 Mar 2021 13:31:34 +0000 [thread overview]
Message-ID: <5afd1d656299d87c43bdf31b8ced2d5f@kernel.org> (raw)
In-Reply-To: <trinity-9fa6d24e-f9de-4741-bf44-86f6197b174d-1614600961297@3c-app-gmx-bap67>
Frank,
>> > i guess it's a bug in ath10k driver or my r64 board (it is a v1.1
>> > which has missing capacitors on tx lines).
>>
>> No, this definitely looks like a bug in the MTK PCIe driver,
>> where the mutex is either not properly initialised, corrupted,
>> or the wrong pointer is passed.
>
> but why does it happen only with the ath10k-card and not the mt7612 in
> same slot?
Does mt7612 use MSI? What we have here is a bogus mutex in the
MTK PCIe driver, and the only way not to get there would be
to avoid using MSIs.
>
>> This r64 machine is supposed to have working MSIs, right?
>
> imho mt7622 have working MSI
>
>> Do you get the same issue without this series?
>
> tested 5.11.0 [1] without this series (but with your/thomas' patch
> from discussion about my old patch) and got same trace. so this series
> does not break anything here.
Can you retest without any additional patch on top of 5.11?
These two patches only affect platforms that do *not* have MSIs at all.
>
>> > Tried with an mt7612e, this seems to work without any errors.
>> >
>> > so for mt7622/mt7623
>> >
>> > Tested-by: Frank Wunderlich <frank-w@public-files.de>
>>
>> We definitely need to understand the above.
>
> there is a hardware-bug which may cause this...afair i saw this with
> the card in r64 with earlier Kernel-versions where other cards work
> (like the mt7612e).
I don't think a HW bug affecting PCI would cause what we are seeing
here, unless it results in memory corruption.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <thierry.reding@gmail.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Will Deacon <will@kernel.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Rob Herring <robh@kernel.org>, Wei Liu <wei.liu@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Michal Simek <michal.simek@xilinx.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Ryder Lee <ryder.lee@mediatek.com>,
linux-mediatek@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-tegra@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: Aw: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling
Date: Mon, 01 Mar 2021 13:31:34 +0000 [thread overview]
Message-ID: <5afd1d656299d87c43bdf31b8ced2d5f@kernel.org> (raw)
In-Reply-To: <trinity-9fa6d24e-f9de-4741-bf44-86f6197b174d-1614600961297@3c-app-gmx-bap67>
Frank,
>> > i guess it's a bug in ath10k driver or my r64 board (it is a v1.1
>> > which has missing capacitors on tx lines).
>>
>> No, this definitely looks like a bug in the MTK PCIe driver,
>> where the mutex is either not properly initialised, corrupted,
>> or the wrong pointer is passed.
>
> but why does it happen only with the ath10k-card and not the mt7612 in
> same slot?
Does mt7612 use MSI? What we have here is a bogus mutex in the
MTK PCIe driver, and the only way not to get there would be
to avoid using MSIs.
>
>> This r64 machine is supposed to have working MSIs, right?
>
> imho mt7622 have working MSI
>
>> Do you get the same issue without this series?
>
> tested 5.11.0 [1] without this series (but with your/thomas' patch
> from discussion about my old patch) and got same trace. so this series
> does not break anything here.
Can you retest without any additional patch on top of 5.11?
These two patches only affect platforms that do *not* have MSIs at all.
>
>> > Tried with an mt7612e, this seems to work without any errors.
>> >
>> > so for mt7622/mt7623
>> >
>> > Tested-by: Frank Wunderlich <frank-w@public-files.de>
>>
>> We definitely need to understand the above.
>
> there is a hardware-bug which may cause this...afair i saw this with
> the card in r64 with earlier Kernel-versions where other cards work
> (like the mt7612e).
I don't think a HW bug affecting PCI would cause what we are seeing
here, unless it results in memory corruption.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <thierry.reding@gmail.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Will Deacon <will@kernel.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Rob Herring <robh@kernel.org>, Wei Liu <wei.liu@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Michal Simek <michal.simek@xilinx.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Ryder Lee <ryder.lee@mediatek.com>,
linux-mediatek@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-tegra@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: Aw: Re: [PATCH 09/13] PCI: mediatek: Advertise lack of MSI handling
Date: Mon, 01 Mar 2021 13:31:34 +0000 [thread overview]
Message-ID: <5afd1d656299d87c43bdf31b8ced2d5f@kernel.org> (raw)
In-Reply-To: <trinity-9fa6d24e-f9de-4741-bf44-86f6197b174d-1614600961297@3c-app-gmx-bap67>
Frank,
>> > i guess it's a bug in ath10k driver or my r64 board (it is a v1.1
>> > which has missing capacitors on tx lines).
>>
>> No, this definitely looks like a bug in the MTK PCIe driver,
>> where the mutex is either not properly initialised, corrupted,
>> or the wrong pointer is passed.
>
> but why does it happen only with the ath10k-card and not the mt7612 in
> same slot?
Does mt7612 use MSI? What we have here is a bogus mutex in the
MTK PCIe driver, and the only way not to get there would be
to avoid using MSIs.
>
>> This r64 machine is supposed to have working MSIs, right?
>
> imho mt7622 have working MSI
>
>> Do you get the same issue without this series?
>
> tested 5.11.0 [1] without this series (but with your/thomas' patch
> from discussion about my old patch) and got same trace. so this series
> does not break anything here.
Can you retest without any additional patch on top of 5.11?
These two patches only affect platforms that do *not* have MSIs at all.
>
>> > Tried with an mt7612e, this seems to work without any errors.
>> >
>> > so for mt7622/mt7623
>> >
>> > Tested-by: Frank Wunderlich <frank-w@public-files.de>
>>
>> We definitely need to understand the above.
>
> there is a hardware-bug which may cause this...afair i saw this with
> the card in r64 with earlier Kernel-versions where other cards work
> (like the mt7612e).
I don't think a HW bug affecting PCI would cause what we are seeing
here, unless it results in memory corruption.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-01 13:32 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 15:10 [PATCH 00/13] PCI: MSI: Getting rid of msi_controller, and other cleanups Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 01/13] PCI: tegra: Convert to MSI domains Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 02/13] PCI: rcar: " Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-28 18:48 ` Marek Vasut
2021-02-28 18:48 ` Marek Vasut
2021-02-28 18:48 ` Marek Vasut
2021-02-25 15:10 ` [PATCH 03/13] PCI: xilinx: " Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-03-22 12:21 ` Lorenzo Pieralisi
2021-03-22 12:21 ` Lorenzo Pieralisi
2021-03-22 12:21 ` Lorenzo Pieralisi
2021-03-22 12:33 ` Michal Simek
2021-03-22 12:33 ` Michal Simek
2021-03-22 12:33 ` Michal Simek
2021-03-22 14:04 ` Marc Zyngier
2021-03-22 14:04 ` Marc Zyngier
2021-03-22 14:04 ` Marc Zyngier
2021-03-22 12:23 ` Lorenzo Pieralisi
2021-03-22 12:23 ` Lorenzo Pieralisi
2021-03-22 12:23 ` Lorenzo Pieralisi
2021-03-22 12:33 ` Michal Simek
2021-03-22 12:33 ` Michal Simek
2021-03-22 12:33 ` Michal Simek
2021-03-22 14:04 ` Marc Zyngier
2021-03-22 14:04 ` Marc Zyngier
2021-03-22 14:04 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 04/13] PCI: hyperv: Drop msi_controller structure Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-03-01 4:24 ` Michael Kelley
2021-03-01 4:24 ` Michael Kelley
2021-03-01 4:24 ` Michael Kelley
2021-02-25 15:10 ` [PATCH 05/13] PCI: MSI: Drop use of msi_controller from core code Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 06/13] PCI: MSI: Kill msi_controller structure Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 07/13] PCI: MSI: Kill default_teardown_msi_irqs() Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 08/13] PCI: MSI: Let PCI host bridges declare their lack of MSI handling Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 09/13] PCI: mediatek: Advertise " Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-03-01 10:43 ` Aw: " Frank Wunderlich
2021-03-01 10:43 ` Frank Wunderlich
2021-03-01 10:43 ` Frank Wunderlich
2021-03-01 11:49 ` Marc Zyngier
2021-03-01 11:49 ` Marc Zyngier
2021-03-01 11:49 ` Marc Zyngier
2021-03-01 12:16 ` Aw: " Frank Wunderlich
2021-03-01 12:16 ` Frank Wunderlich
2021-03-01 12:16 ` Frank Wunderlich
2021-03-01 13:31 ` Marc Zyngier [this message]
2021-03-01 13:31 ` Marc Zyngier
2021-03-01 13:31 ` Marc Zyngier
2021-03-01 14:06 ` Aw: " Frank Wunderlich
2021-03-01 14:06 ` Frank Wunderlich
2021-03-01 14:06 ` Frank Wunderlich
2021-03-02 10:35 ` Robin Murphy
2021-03-02 10:35 ` Robin Murphy
2021-03-02 10:35 ` Robin Murphy
2021-02-25 15:10 ` [PATCH 10/13] PCI: MSI: Let PCI host bridges declare their reliance on MSI domains Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 11/13] PCI: Make pci_host_common_probe() declare its " Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 12/13] PCI: MSI: Document the various ways of ending up with NO_MSI Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` [PATCH 13/13] PCI: quirks: Refactor advertising of the NO_MSI flag Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-02-25 15:10 ` Marc Zyngier
2021-03-10 19:29 ` [PATCH 00/13] PCI: MSI: Getting rid of msi_controller, and other cleanups Bjorn Helgaas
2021-03-10 19:29 ` Bjorn Helgaas
2021-03-10 19:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5afd1d656299d87c43bdf31b8ced2d5f@kernel.org \
--to=maz@kernel.org \
--cc=bhelgaas@google.com \
--cc=frank-w@public-files.de \
--cc=haiyangz@microsoft.com \
--cc=jonathanh@nvidia.com \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.