From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3
Date: Mon, 23 May 2022 14:41:06 +0200 [thread overview]
Message-ID: <5b71f5e8-c3df-46ef-094f-9739dd7a0f5f@linaro.org> (raw)
In-Reply-To: <Yos0IOkCd4R9a9YZ@atomide.com>
Hi Tony,
On 23/05/2022 09:13, Tony Lindgren wrote:
> Hi,
>
> * Daniel Lezcano <daniel.lezcano@linaro.org> [220520 15:24]:
>> On 08/04/2022 12:17, Tony Lindgren wrote:
>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>> --- a/drivers/clocksource/Kconfig
>>> +++ b/drivers/clocksource/Kconfig
>>> @@ -22,7 +22,7 @@ config CLKEVT_I8253
>>> config I8253_LOCK
>>> bool
>>> -config OMAP_DM_TIMER
>>> +config OMAP_DM_SYSTIMER
>>> bool
>>> select TIMER_OF
>>> @@ -56,6 +56,12 @@ config DIGICOLOR_TIMER
>>> help
>>> Enables the support for the digicolor timer driver.
>>> +config OMAP_DM_TIMER
>>> + tristate "OMAP dual-mode timer driver" if ARCH_K3 || COMPILE_TEST
>>
>> Actually, I missed this. Could you convert to a 'bool' there is no module in
>> the timer drivers ATM.
>
> OK sure will do.
>
> Did you notice some loadable module usage issues for timers that are not
> system timers? Just wondering if there are some issues that I did not
> notice.
I think the removal won't be supported. We already had a proposal to
move one of the timer as a module but I wanted to have more insights
about the changes, not just do that because of a GKI Android.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3
Date: Mon, 23 May 2022 14:41:06 +0200 [thread overview]
Message-ID: <5b71f5e8-c3df-46ef-094f-9739dd7a0f5f@linaro.org> (raw)
In-Reply-To: <Yos0IOkCd4R9a9YZ@atomide.com>
Hi Tony,
On 23/05/2022 09:13, Tony Lindgren wrote:
> Hi,
>
> * Daniel Lezcano <daniel.lezcano@linaro.org> [220520 15:24]:
>> On 08/04/2022 12:17, Tony Lindgren wrote:
>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>> --- a/drivers/clocksource/Kconfig
>>> +++ b/drivers/clocksource/Kconfig
>>> @@ -22,7 +22,7 @@ config CLKEVT_I8253
>>> config I8253_LOCK
>>> bool
>>> -config OMAP_DM_TIMER
>>> +config OMAP_DM_SYSTIMER
>>> bool
>>> select TIMER_OF
>>> @@ -56,6 +56,12 @@ config DIGICOLOR_TIMER
>>> help
>>> Enables the support for the digicolor timer driver.
>>> +config OMAP_DM_TIMER
>>> + tristate "OMAP dual-mode timer driver" if ARCH_K3 || COMPILE_TEST
>>
>> Actually, I missed this. Could you convert to a 'bool' there is no module in
>> the timer drivers ATM.
>
> OK sure will do.
>
> Did you notice some loadable module usage issues for timers that are not
> system timers? Just wondering if there are some issues that I did not
> notice.
I think the removal won't be supported. We already had a proposal to
move one of the timer as a module but I wanted to have more insights
about the changes, not just do that because of a GKI Android.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-23 12:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 10:17 [PATCHv2 0/3] TI timer changes for am6 Tony Lindgren
2022-04-08 10:17 ` Tony Lindgren
2022-04-08 10:17 ` [PATCH 1/3] clocksource/drivers/timer-ti-dm: Move inline functions to driver " Tony Lindgren
2022-04-08 10:17 ` Tony Lindgren
2022-07-28 10:44 ` [tip: timers/core] " tip-bot2 for Tony Lindgren
2022-04-08 10:17 ` [PATCH 2/3] clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3 Tony Lindgren
2022-04-08 10:17 ` Tony Lindgren
2022-05-20 15:28 ` Daniel Lezcano
2022-05-20 15:28 ` Daniel Lezcano
2022-05-23 7:13 ` Tony Lindgren
2022-05-23 7:13 ` Tony Lindgren
2022-05-23 12:41 ` Daniel Lezcano [this message]
2022-05-23 12:41 ` Daniel Lezcano
2022-05-23 14:33 ` Tony Lindgren
2022-05-23 14:33 ` Tony Lindgren
2022-07-28 10:44 ` [tip: timers/core] " tip-bot2 for Tony Lindgren
2022-04-08 10:17 ` [PATCH 3/3] clocksource/drivers/timer-ti-dm: Add compatible for am6 SoCs Tony Lindgren
2022-04-08 10:17 ` Tony Lindgren
2022-07-28 10:44 ` [tip: timers/core] " tip-bot2 for Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b71f5e8-c3df-46ef-094f-9739dd7a0f5f@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.