From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yong Wu <yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tomasz Figa <tfiga-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Daniel Kurtz <djkurtz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 01/13] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI
Date: Sun, 16 Sep 2018 17:26:16 -0500 [thread overview]
Message-ID: <5b9f3f52.1c69fb81.a7f7c.f34e@mx.google.com> (raw)
In-Reply-To: <1535954502-30646-2-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Mon, Sep 03, 2018 at 02:01:30PM +0800, Yong Wu wrote:
> This patch adds decriptions for mt8183 IOMMU and SMI.
>
> mt8183 has one M4U like mt8173 and is also MTK IOMMU gen2 which
> uses ARM Short-Descriptor translation table format.
>
> The mt8183 M4U-SMI HW diagram is as below:
>
> EMI
> |
> M4U
> |
> ----------
> | |
> gals0-rx gals1-rx
> | |
> | |
> gals0-tx gals1-tx
> | |
> ------------
> SMI Common
> ------------
> |
> +-----+-----+--------+-----+-----+-------+-------+
> | | | | | | | |
> | | gals-rx gals-rx | gals-rx gals-rx gals-rx
> | | | | | | | |
> | | | | | | | |
> | | gals-tx gals-tx | gals-tx gals-tx gals-tx
> | | | | | | | |
> larb0 larb1 larb2 larb3 larb4 larb5 larb6 CCU
> disp vdec IPU0 IPU1 venc IPU1 cam
>
> All the connections are HW fixed, SW can NOT adjust it.
>
> Compared with mt8173, we add a GALS(Global Async Local Sync) module
> between SMI-common and M4U, and additional between larb2/3/5/6 and
> SMI-common. GALS can help synchronize for the modules in different
> clock frequence, it can be seen as a "asynchronous fifo".
s/frequence/frequency/
> GALS can only help transfer the command/data while it don't have the
> register, thus it has the special "smi" clock and it don't have the
> "apb" clock. From the diagram above, we add "gals0" and "gals1"
> clockes for smi-common and add a "gals" clock for smi-larb.
s/clockes/clocks/
s/don't/doesn't/
> From the diagram above, CCU(Camera Control Unit) is connected with
> smi-common directly, we can look it as "larb7" but its register space
> is different with the normal larb.
>
> Signed-off-by: Yong Wu <yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> .../devicetree/bindings/iommu/mediatek,iommu.txt | 15 ++-
> .../memory-controllers/mediatek,smi-common.txt | 11 +-
> .../memory-controllers/mediatek,smi-larb.txt | 3 +
> include/dt-bindings/memory/mt8183-larb-port.h | 130 +++++++++++++++++++++
> 4 files changed, 153 insertions(+), 6 deletions(-)
> create mode 100644 include/dt-bindings/memory/mt8183-larb-port.h
With those fixed,
Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/13] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI
Date: Sun, 16 Sep 2018 17:26:16 -0500 [thread overview]
Message-ID: <5b9f3f52.1c69fb81.a7f7c.f34e@mx.google.com> (raw)
In-Reply-To: <1535954502-30646-2-git-send-email-yong.wu@mediatek.com>
On Mon, Sep 03, 2018 at 02:01:30PM +0800, Yong Wu wrote:
> This patch adds decriptions for mt8183 IOMMU and SMI.
>
> mt8183 has one M4U like mt8173 and is also MTK IOMMU gen2 which
> uses ARM Short-Descriptor translation table format.
>
> The mt8183 M4U-SMI HW diagram is as below:
>
> EMI
> |
> M4U
> |
> ----------
> | |
> gals0-rx gals1-rx
> | |
> | |
> gals0-tx gals1-tx
> | |
> ------------
> SMI Common
> ------------
> |
> +-----+-----+--------+-----+-----+-------+-------+
> | | | | | | | |
> | | gals-rx gals-rx | gals-rx gals-rx gals-rx
> | | | | | | | |
> | | | | | | | |
> | | gals-tx gals-tx | gals-tx gals-tx gals-tx
> | | | | | | | |
> larb0 larb1 larb2 larb3 larb4 larb5 larb6 CCU
> disp vdec IPU0 IPU1 venc IPU1 cam
>
> All the connections are HW fixed, SW can NOT adjust it.
>
> Compared with mt8173, we add a GALS(Global Async Local Sync) module
> between SMI-common and M4U, and additional between larb2/3/5/6 and
> SMI-common. GALS can help synchronize for the modules in different
> clock frequence, it can be seen as a "asynchronous fifo".
s/frequence/frequency/
> GALS can only help transfer the command/data while it don't have the
> register, thus it has the special "smi" clock and it don't have the
> "apb" clock. From the diagram above, we add "gals0" and "gals1"
> clockes for smi-common and add a "gals" clock for smi-larb.
s/clockes/clocks/
s/don't/doesn't/
> From the diagram above, CCU(Camera Control Unit) is connected with
> smi-common directly, we can look it as "larb7" but its register space
> is different with the normal larb.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> .../devicetree/bindings/iommu/mediatek,iommu.txt | 15 ++-
> .../memory-controllers/mediatek,smi-common.txt | 11 +-
> .../memory-controllers/mediatek,smi-larb.txt | 3 +
> include/dt-bindings/memory/mt8183-larb-port.h | 130 +++++++++++++++++++++
> 4 files changed, 153 insertions(+), 6 deletions(-)
> create mode 100644 include/dt-bindings/memory/mt8183-larb-port.h
With those fixed,
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2018-09-16 22:26 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 6:01 [PATCH 00/13] MT8183 IOMMU SUPPORT Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 01/13] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
[not found] ` <1535954502-30646-2-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-09-16 22:26 ` Rob Herring [this message]
2018-09-16 22:26 ` Rob Herring
2018-09-17 6:15 ` Yong Wu
2018-09-17 6:15 ` Yong Wu
2018-09-17 6:15 ` Yong Wu
2018-09-03 6:01 ` [PATCH 02/13] iommu/mediatek: Use a struct as the platform data Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 03/13] memory: mtk-smi: Use a general config_port interface Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 04/13] iommu/io-pgtable-arm-v7s: Extend MediaTek 4GB mode Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-20 5:54 ` Yong Wu
2018-09-20 5:54 ` Yong Wu
2018-09-20 5:54 ` Yong Wu
2018-09-20 11:54 ` Robin Murphy
2018-09-20 11:54 ` Robin Murphy
2018-09-20 11:54 ` Robin Murphy
2018-09-20 17:31 ` Robin Murphy
2018-09-20 17:31 ` Robin Murphy
2018-09-20 17:31 ` Robin Murphy
2018-09-24 9:26 ` Yong Wu
2018-09-24 9:26 ` Yong Wu
2018-09-24 9:26 ` Yong Wu
2018-09-03 6:01 ` [PATCH 05/13] iommu/mediatek: Add mt8183 IOMMU support Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 06/13] iommu/mediatek: Add mmu1 support Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 07/13] memory: mtk-smi: Invoke pm runtime_callback to enable clocks Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 08/13] memory: mtk-smi: Use a struct for the platform data for smi-common Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 09/13] memory: mtk-smi: Add bus_sel for mt8183 Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 10/13] iommu/mediatek: Add VLD_PA_RANGE register backup when suspend Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 11/13] iommu/mediatek: Add shutdown callback Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 12/13] memory: mtk-smi: Get rid of need_larbid Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` [PATCH 13/13] iommu/mediatek: Switch to SPDX license identifier Yong Wu
2018-09-03 6:01 ` Yong Wu
2018-09-03 6:01 ` Yong Wu
[not found] ` <1535954502-30646-14-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-09-17 5:44 ` Rob Herring
2018-09-17 5:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b9f3f52.1c69fb81.a7f7c.f34e@mx.google.com \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=djkurtz-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
--cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=tfiga-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
--cc=yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.