From: Michael Riesch <michael.riesch@wolfvision.net>
To: Conor Dooley <conor@kernel.org>
Cc: "Mehdi Djait" <mehdi.djait.k@gmail.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 04/14] media: dt-bindings: media: rockchip,px30-vip: allow for different variants
Date: Fri, 23 Feb 2024 08:03:20 +0100 [thread overview]
Message-ID: <5bb0b0a9-3d4c-4303-aa43-38789bee286d@wolfvision.net> (raw)
In-Reply-To: <20240220-catchy-cupcake-e600e5af7650@spud>
Hi Conor,
On 2/20/24 19:58, Conor Dooley wrote:
> Hey,
>
> On Tue, Feb 20, 2024 at 10:39:14AM +0100, Michael Riesch wrote:
>> Move the documentation of clocks and resets to a allOf: structure in order
>> to allow for different variants of the IP block.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>> .../bindings/media/rockchip,px30-vip.yaml | 58 ++++++++++++++--------
>> 1 file changed, 37 insertions(+), 21 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> index 675a1ea47210..7168f166798c 100644
>> --- a/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> @@ -24,32 +24,16 @@ properties:
>> interrupts:
>> maxItems: 1
>>
>> - clocks:
>> - items:
>> - - description: ACLK
>> - - description: HCLK
>> - - description: PCLK
>> -
>> - clock-names:
>> - items:
>> - - const: aclk
>> - - const: hclk
>> - - const: pclk
>> + clocks: true
>> +
>> + clock-names: true
>
> This is, unfortunately, not how we like multiple soc support to be
> handled. Instead, the widest constraints are added at the top level
> and constrained by the allOf. If none of the names etc are shared, at
> least the widest constraints for minItems and maxItems should be able to
> be here.
Just to make sure I got it right:
clocks:
minItems: 3
maxItems: 4
items:
- const: aclk
- const: hclk
...
allOf:
...
- if:
properties:
compatible:
contains:
const: rockchip,rk3568-vicap
then:
properties:
clocks:
- const: aclk
- const: hclk
- const: dclk
- const: iclk
Is this the desired way?
> That said, this patch should be squashed with the patch that actually
> adds the other device to the binding.
That can be arranged.
Best regards,
Michael
>
> Cheers,
> Conor.
>
>>
>> iommus:
>> maxItems: 1
>>
>> - resets:
>> - items:
>> - - description: AXI
>> - - description: AHB
>> - - description: PCLK IN
>> + resets: true
>>
>> - reset-names:
>> - items:
>> - - const: axi
>> - - const: ahb
>> - - const: pclkin
>> + reset-names: true
>>
>> power-domains:
>> maxItems: 1
>> @@ -85,6 +69,38 @@ required:
>> - clocks
>> - ports
>>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: rockchip,px30-vip
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: ACLK
>> + - description: HCLK
>> + - description: PCLK
>> +
>> + clock-names:
>> + items:
>> + - const: aclk
>> + - const: hclk
>> + - const: pclk
>> +
>> + resets:
>> + items:
>> + - description: AXI
>> + - description: AHB
>> + - description: PCLK IN
>> +
>> + reset-names:
>> + items:
>> + - const: axi
>> + - const: ahb
>> + - const: pclkin
>> +
>> additionalProperties: false
>>
>> examples:
>>
>> --
>> 2.30.2
>>
WARNING: multiple messages have this Message-ID (diff)
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Conor Dooley <conor@kernel.org>
Cc: "Mehdi Djait" <mehdi.djait.k@gmail.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 04/14] media: dt-bindings: media: rockchip,px30-vip: allow for different variants
Date: Fri, 23 Feb 2024 08:03:20 +0100 [thread overview]
Message-ID: <5bb0b0a9-3d4c-4303-aa43-38789bee286d@wolfvision.net> (raw)
In-Reply-To: <20240220-catchy-cupcake-e600e5af7650@spud>
Hi Conor,
On 2/20/24 19:58, Conor Dooley wrote:
> Hey,
>
> On Tue, Feb 20, 2024 at 10:39:14AM +0100, Michael Riesch wrote:
>> Move the documentation of clocks and resets to a allOf: structure in order
>> to allow for different variants of the IP block.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>> .../bindings/media/rockchip,px30-vip.yaml | 58 ++++++++++++++--------
>> 1 file changed, 37 insertions(+), 21 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> index 675a1ea47210..7168f166798c 100644
>> --- a/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> @@ -24,32 +24,16 @@ properties:
>> interrupts:
>> maxItems: 1
>>
>> - clocks:
>> - items:
>> - - description: ACLK
>> - - description: HCLK
>> - - description: PCLK
>> -
>> - clock-names:
>> - items:
>> - - const: aclk
>> - - const: hclk
>> - - const: pclk
>> + clocks: true
>> +
>> + clock-names: true
>
> This is, unfortunately, not how we like multiple soc support to be
> handled. Instead, the widest constraints are added at the top level
> and constrained by the allOf. If none of the names etc are shared, at
> least the widest constraints for minItems and maxItems should be able to
> be here.
Just to make sure I got it right:
clocks:
minItems: 3
maxItems: 4
items:
- const: aclk
- const: hclk
...
allOf:
...
- if:
properties:
compatible:
contains:
const: rockchip,rk3568-vicap
then:
properties:
clocks:
- const: aclk
- const: hclk
- const: dclk
- const: iclk
Is this the desired way?
> That said, this patch should be squashed with the patch that actually
> adds the other device to the binding.
That can be arranged.
Best regards,
Michael
>
> Cheers,
> Conor.
>
>>
>> iommus:
>> maxItems: 1
>>
>> - resets:
>> - items:
>> - - description: AXI
>> - - description: AHB
>> - - description: PCLK IN
>> + resets: true
>>
>> - reset-names:
>> - items:
>> - - const: axi
>> - - const: ahb
>> - - const: pclkin
>> + reset-names: true
>>
>> power-domains:
>> maxItems: 1
>> @@ -85,6 +69,38 @@ required:
>> - clocks
>> - ports
>>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: rockchip,px30-vip
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: ACLK
>> + - description: HCLK
>> + - description: PCLK
>> +
>> + clock-names:
>> + items:
>> + - const: aclk
>> + - const: hclk
>> + - const: pclk
>> +
>> + resets:
>> + items:
>> + - description: AXI
>> + - description: AHB
>> + - description: PCLK IN
>> +
>> + reset-names:
>> + items:
>> + - const: axi
>> + - const: ahb
>> + - const: pclkin
>> +
>> additionalProperties: false
>>
>> examples:
>>
>> --
>> 2.30.2
>>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Conor Dooley <conor@kernel.org>
Cc: "Mehdi Djait" <mehdi.djait.k@gmail.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 04/14] media: dt-bindings: media: rockchip,px30-vip: allow for different variants
Date: Fri, 23 Feb 2024 08:03:20 +0100 [thread overview]
Message-ID: <5bb0b0a9-3d4c-4303-aa43-38789bee286d@wolfvision.net> (raw)
In-Reply-To: <20240220-catchy-cupcake-e600e5af7650@spud>
Hi Conor,
On 2/20/24 19:58, Conor Dooley wrote:
> Hey,
>
> On Tue, Feb 20, 2024 at 10:39:14AM +0100, Michael Riesch wrote:
>> Move the documentation of clocks and resets to a allOf: structure in order
>> to allow for different variants of the IP block.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>> .../bindings/media/rockchip,px30-vip.yaml | 58 ++++++++++++++--------
>> 1 file changed, 37 insertions(+), 21 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> index 675a1ea47210..7168f166798c 100644
>> --- a/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> @@ -24,32 +24,16 @@ properties:
>> interrupts:
>> maxItems: 1
>>
>> - clocks:
>> - items:
>> - - description: ACLK
>> - - description: HCLK
>> - - description: PCLK
>> -
>> - clock-names:
>> - items:
>> - - const: aclk
>> - - const: hclk
>> - - const: pclk
>> + clocks: true
>> +
>> + clock-names: true
>
> This is, unfortunately, not how we like multiple soc support to be
> handled. Instead, the widest constraints are added at the top level
> and constrained by the allOf. If none of the names etc are shared, at
> least the widest constraints for minItems and maxItems should be able to
> be here.
Just to make sure I got it right:
clocks:
minItems: 3
maxItems: 4
items:
- const: aclk
- const: hclk
...
allOf:
...
- if:
properties:
compatible:
contains:
const: rockchip,rk3568-vicap
then:
properties:
clocks:
- const: aclk
- const: hclk
- const: dclk
- const: iclk
Is this the desired way?
> That said, this patch should be squashed with the patch that actually
> adds the other device to the binding.
That can be arranged.
Best regards,
Michael
>
> Cheers,
> Conor.
>
>>
>> iommus:
>> maxItems: 1
>>
>> - resets:
>> - items:
>> - - description: AXI
>> - - description: AHB
>> - - description: PCLK IN
>> + resets: true
>>
>> - reset-names:
>> - items:
>> - - const: axi
>> - - const: ahb
>> - - const: pclkin
>> + reset-names: true
>>
>> power-domains:
>> maxItems: 1
>> @@ -85,6 +69,38 @@ required:
>> - clocks
>> - ports
>>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: rockchip,px30-vip
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: ACLK
>> + - description: HCLK
>> + - description: PCLK
>> +
>> + clock-names:
>> + items:
>> + - const: aclk
>> + - const: hclk
>> + - const: pclk
>> +
>> + resets:
>> + items:
>> + - description: AXI
>> + - description: AHB
>> + - description: PCLK IN
>> +
>> + reset-names:
>> + items:
>> + - const: axi
>> + - const: ahb
>> + - const: pclkin
>> +
>> additionalProperties: false
>>
>> examples:
>>
>> --
>> 2.30.2
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-23 7:03 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 9:39 [PATCH 00/14] media: rockchip: cif: add support for rk3568 vicap Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 01/14] media: dt-bindings: media: video-interfaces: add defines for sampling modes Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-23 0:26 ` Rob Herring
2024-02-23 0:26 ` Rob Herring
2024-02-23 0:26 ` Rob Herring
2024-02-20 9:39 ` [PATCH 02/14] media: dt-bindings: media: rockchip-cif: add port definitions Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-23 0:28 ` Rob Herring
2024-02-23 0:28 ` Rob Herring
2024-02-23 0:28 ` Rob Herring
2024-02-23 6:53 ` Michael Riesch
2024-02-23 6:53 ` Michael Riesch
2024-02-23 6:53 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 03/14] media: dt-bindings: media: rockchip,px30-vip: add optional property iommus Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-23 0:29 ` Rob Herring
2024-02-23 0:29 ` Rob Herring
2024-02-23 0:29 ` Rob Herring
2024-02-20 9:39 ` [PATCH 04/14] media: dt-bindings: media: rockchip,px30-vip: allow for different variants Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 18:58 ` Conor Dooley
2024-02-20 18:58 ` Conor Dooley
2024-02-20 18:58 ` Conor Dooley
2024-02-23 7:03 ` Michael Riesch [this message]
2024-02-23 7:03 ` Michael Riesch
2024-02-23 7:03 ` Michael Riesch
2024-02-23 18:56 ` Conor Dooley
2024-02-23 18:56 ` Conor Dooley
2024-02-23 18:56 ` Conor Dooley
2024-02-20 9:39 ` [PATCH 05/14] media: dt-bindings: media: rockchip,px30-vip: add rk3568-vicap compatible Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 06/14] media: rockchip: cif: store endpoint information in private data Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 07/14] media: rockchip: cif: fix formatting of find_output_fmt Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 08/14] media: rockchip: cif: use port definitions from new header file Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 09/14] media: rockchip: cif: add support for grf Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 10/14] media: rockchip: cif: add variant specific input format list Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 11/14] media: rockchip: cif: make scaler support variant specific Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 12/14] media: rockchip: cif: make register access " Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 13/14] media: rockchip: cif: add support for rk3568 vicap Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` [PATCH 14/14] arm64: dts: rockchip: add vicap node to rk356x Michael Riesch
2024-02-20 9:39 ` Michael Riesch
2024-02-20 9:39 ` Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bb0b0a9-3d4c-4303-aa43-38789bee286d@wolfvision.net \
--to=michael.riesch@wolfvision.net \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait.k@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.