From: Daniel Baluta <daniel.baluta@nxp.com>
To: Schrempf Frieder <frieder.schrempf@kontron.de>,
Adam Ford <aford173@gmail.com>, Anson Huang <Anson.Huang@nxp.com>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Li Jun <jun.li@nxp.com>, Lucas Stach <l.stach@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"etnaviv@lists.freedesktop.org" <etnaviv@lists.freedesktop.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/4] drm/etnaviv: Prevent IRQ triggering at probe time on i.MX8MM
Date: Thu, 30 Apr 2020 17:23:46 +0300 [thread overview]
Message-ID: <5c4c994b-8868-f68c-cd0d-7f7a2530f697@nxp.com> (raw)
In-Reply-To: <20200430124602.14463-2-frieder.schrempf@kontron.de>
On 4/30/20 3:46 PM, Schrempf Frieder wrote:
>
> + /*
> + * On i.MX8MM there is an interrupt getting triggered immediately
> + * after requesting the IRQ, which leads to a stall as the handler
> + * accesses the GPU registers whithout the clock being enabled.
> + * Enabling the clocks briefly seems to clear the IRQ state, so we do
> + * this here before requesting the IRQ.
> + */
> + err = etnaviv_gpu_clk_enable(gpu);
> + if (err)
> + return err;
> +
> + err = etnaviv_gpu_clk_disable(gpu);
> + if (err)
> + return err;
> +
> + err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
> + dev_name(gpu->dev), gpu);
> + if (err) {
> + dev_err(dev, "failed to request IRQ%u: %d\n", gpu->irq, err);
> + return err;
> + }
Shouldn't you disable the clk after devm_request_irq is called?
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Baluta <daniel.baluta@nxp.com>
To: Schrempf Frieder <frieder.schrempf@kontron.de>,
Adam Ford <aford173@gmail.com>, Anson Huang <Anson.Huang@nxp.com>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Li Jun <jun.li@nxp.com>, Lucas Stach <l.stach@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"etnaviv@lists.freedesktop.org" <etnaviv@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/4] drm/etnaviv: Prevent IRQ triggering at probe time on i.MX8MM
Date: Thu, 30 Apr 2020 17:23:46 +0300 [thread overview]
Message-ID: <5c4c994b-8868-f68c-cd0d-7f7a2530f697@nxp.com> (raw)
In-Reply-To: <20200430124602.14463-2-frieder.schrempf@kontron.de>
On 4/30/20 3:46 PM, Schrempf Frieder wrote:
>
> + /*
> + * On i.MX8MM there is an interrupt getting triggered immediately
> + * after requesting the IRQ, which leads to a stall as the handler
> + * accesses the GPU registers whithout the clock being enabled.
> + * Enabling the clocks briefly seems to clear the IRQ state, so we do
> + * this here before requesting the IRQ.
> + */
> + err = etnaviv_gpu_clk_enable(gpu);
> + if (err)
> + return err;
> +
> + err = etnaviv_gpu_clk_disable(gpu);
> + if (err)
> + return err;
> +
> + err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
> + dev_name(gpu->dev), gpu);
> + if (err) {
> + dev_err(dev, "failed to request IRQ%u: %d\n", gpu->irq, err);
> + return err;
> + }
Shouldn't you disable the clk after devm_request_irq is called?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Baluta <daniel.baluta@nxp.com>
To: Schrempf Frieder <frieder.schrempf@kontron.de>,
Adam Ford <aford173@gmail.com>, Anson Huang <Anson.Huang@nxp.com>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Li Jun <jun.li@nxp.com>, Lucas Stach <l.stach@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"etnaviv@lists.freedesktop.org" <etnaviv@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/4] drm/etnaviv: Prevent IRQ triggering at probe time on i.MX8MM
Date: Thu, 30 Apr 2020 17:23:46 +0300 [thread overview]
Message-ID: <5c4c994b-8868-f68c-cd0d-7f7a2530f697@nxp.com> (raw)
In-Reply-To: <20200430124602.14463-2-frieder.schrempf@kontron.de>
On 4/30/20 3:46 PM, Schrempf Frieder wrote:
>
> + /*
> + * On i.MX8MM there is an interrupt getting triggered immediately
> + * after requesting the IRQ, which leads to a stall as the handler
> + * accesses the GPU registers whithout the clock being enabled.
> + * Enabling the clocks briefly seems to clear the IRQ state, so we do
> + * this here before requesting the IRQ.
> + */
> + err = etnaviv_gpu_clk_enable(gpu);
> + if (err)
> + return err;
> +
> + err = etnaviv_gpu_clk_disable(gpu);
> + if (err)
> + return err;
> +
> + err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
> + dev_name(gpu->dev), gpu);
> + if (err) {
> + dev_err(dev, "failed to request IRQ%u: %d\n", gpu->irq, err);
> + return err;
> + }
Shouldn't you disable the clk after devm_request_irq is called?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-30 14:23 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 12:46 [RFC PATCH 0/4] Add support for i.MX8MM GPUs through Etnaviv Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 12:46 ` [RFC PATCH 1/4] drm/etnaviv: Prevent IRQ triggering at probe time on i.MX8MM Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 14:23 ` Daniel Baluta [this message]
2020-04-30 14:23 ` Daniel Baluta
2020-04-30 14:23 ` Daniel Baluta
2020-04-30 15:30 ` Schrempf Frieder
2020-04-30 15:30 ` Schrempf Frieder
2020-04-30 15:30 ` Schrempf Frieder
2020-04-30 14:32 ` Lucas Stach
2020-04-30 14:32 ` Lucas Stach
2020-04-30 14:32 ` Lucas Stach
2020-04-30 15:31 ` Schrempf Frieder
2020-04-30 15:31 ` Schrempf Frieder
2020-04-30 15:31 ` Schrempf Frieder
2020-04-30 16:14 ` Adam Ford
2020-04-30 16:14 ` Adam Ford
2020-04-30 16:14 ` Adam Ford
2020-04-30 12:46 ` [RFC PATCH 2/4] drm/etnaviv: Fix error path in etnaviv_gpu_clk_enable() Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 12:46 ` [RFC PATCH 3/4] drm/etnaviv: Change order of enabling clocks to fix boot on i.MX8MM Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 14:35 ` Lucas Stach
2020-04-30 14:35 ` Lucas Stach
2020-04-30 14:35 ` Lucas Stach
2020-04-30 15:35 ` Schrempf Frieder
2020-04-30 15:35 ` Schrempf Frieder
2020-04-30 15:35 ` Schrempf Frieder
2020-05-01 12:36 ` Peng Fan
2020-05-01 12:36 ` Peng Fan
2020-05-01 12:36 ` Peng Fan
2020-05-06 11:27 ` Schrempf Frieder
2020-05-06 11:27 ` Schrempf Frieder
2020-05-06 11:27 ` Schrempf Frieder
2020-04-30 12:46 ` [RFC PATCH 4/4] arm64: dts: imx8mm: Add GPU nodes for 2D and 3D core using Etnaviv Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-04-30 12:46 ` Schrempf Frieder
2020-05-03 14:49 ` Adam Ford
2020-05-03 14:49 ` Adam Ford
2020-05-03 14:49 ` Adam Ford
2020-05-04 8:07 ` Lucas Stach
2020-05-04 8:07 ` Lucas Stach
2020-05-04 8:07 ` Lucas Stach
2020-05-06 11:45 ` Schrempf Frieder
2020-05-06 11:45 ` Schrempf Frieder
2020-05-06 11:45 ` Schrempf Frieder
2020-05-06 11:59 ` Schrempf Frieder
2020-05-06 11:59 ` Schrempf Frieder
2020-05-06 11:59 ` Schrempf Frieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c4c994b-8868-f68c-cd0d-7f7a2530f697@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=Anson.Huang@nxp.com \
--cc=aford173@gmail.com \
--cc=christian.gmeiner@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.