From: Auger Eric <eric.auger@redhat.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Christoffer Dall <cdall@linaro.org>,
Andre Przywara <Andre.Przywara@arm.com>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
Shanker Donthineni <shankerd@codeaurora.org>
Subject: Re: [PATCH v5 11/26] KVM: arm/arm64: GICv4: Handle INT command applied to a VLPI
Date: Wed, 8 Nov 2017 15:14:07 +0100 [thread overview]
Message-ID: <5c6f1428-2cf8-0a28-7554-d45dd53f2179@redhat.com> (raw)
In-Reply-To: <26647099-f16c-f4ef-6902-ebbfb7a40a3a@arm.com>
Hi Marc,
On 08/11/2017 12:40, Marc Zyngier wrote:
> On 07/11/17 20:15, Auger Eric wrote:
>> Hi Marc,
>>
>> On 27/10/2017 16:28, Marc Zyngier wrote:
>>> If the guest issues an INT command targetting a VLPI, let's
>>> call into the irq_set_irqchip_state() helper to make it pending
>>> on the physical side.
>>>
>>> This works just as well if userspace decides to inject an interrupt
>>> using the normal userspace API...
>> There is also another path:
>> KVM_SIGNAL_MSI ioctl / kvm_send_userspace_msi / kvm_set_msi /
>> vgic_its_inject_msi / vgic_its_trigger_msi
>
> Isn't this path covered by this very patch?
I should have read the last sentence of the commit msg to see you
haven't ignored it ;-)
>
>> I wonder whether we shouldn't prevent the userspace from messing up with
>> the host irq pending state?
>
> What do we gain from that limitation? Here, we're just making sure
> things will work correctly, and we're not preventing userspace from
> doing something silly (the guest will only see spurious interrupts anyway).
OK. Just wanted to make sure this was not an issue.
Thanks
Eric
>
> Thanks,
>
> M.
>
>> Thanks
>>
>> Eric
>>>
>>> Acked-by: Christoffer Dall <cdall@linaro.org>
>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>> ---
>>> virt/kvm/arm/vgic/vgic-its.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
>>> index 89768d2b6a91..b2a678d131d0 100644
>>> --- a/virt/kvm/arm/vgic/vgic-its.c
>>> +++ b/virt/kvm/arm/vgic/vgic-its.c
>>> @@ -578,6 +578,10 @@ static int vgic_its_trigger_msi(struct kvm *kvm, struct vgic_its *its,
>>> if (err)
>>> return err;
>>>
>>> + if (irq->hw)
>>> + return irq_set_irqchip_state(irq->host_irq,
>>> + IRQCHIP_STATE_PENDING, true);
>>> +
>>> spin_lock(&irq->irq_lock);
>>> irq->pending_latch = true;
>>> vgic_queue_irq_unlock(kvm, irq);
>>>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: eric.auger@redhat.com (Auger Eric)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 11/26] KVM: arm/arm64: GICv4: Handle INT command applied to a VLPI
Date: Wed, 8 Nov 2017 15:14:07 +0100 [thread overview]
Message-ID: <5c6f1428-2cf8-0a28-7554-d45dd53f2179@redhat.com> (raw)
In-Reply-To: <26647099-f16c-f4ef-6902-ebbfb7a40a3a@arm.com>
Hi Marc,
On 08/11/2017 12:40, Marc Zyngier wrote:
> On 07/11/17 20:15, Auger Eric wrote:
>> Hi Marc,
>>
>> On 27/10/2017 16:28, Marc Zyngier wrote:
>>> If the guest issues an INT command targetting a VLPI, let's
>>> call into the irq_set_irqchip_state() helper to make it pending
>>> on the physical side.
>>>
>>> This works just as well if userspace decides to inject an interrupt
>>> using the normal userspace API...
>> There is also another path:
>> KVM_SIGNAL_MSI ioctl / kvm_send_userspace_msi / kvm_set_msi /
>> vgic_its_inject_msi / vgic_its_trigger_msi
>
> Isn't this path covered by this very patch?
I should have read the last sentence of the commit msg to see you
haven't ignored it ;-)
>
>> I wonder whether we shouldn't prevent the userspace from messing up with
>> the host irq pending state?
>
> What do we gain from that limitation? Here, we're just making sure
> things will work correctly, and we're not preventing userspace from
> doing something silly (the guest will only see spurious interrupts anyway).
OK. Just wanted to make sure this was not an issue.
Thanks
Eric
>
> Thanks,
>
> M.
>
>> Thanks
>>
>> Eric
>>>
>>> Acked-by: Christoffer Dall <cdall@linaro.org>
>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>> ---
>>> virt/kvm/arm/vgic/vgic-its.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
>>> index 89768d2b6a91..b2a678d131d0 100644
>>> --- a/virt/kvm/arm/vgic/vgic-its.c
>>> +++ b/virt/kvm/arm/vgic/vgic-its.c
>>> @@ -578,6 +578,10 @@ static int vgic_its_trigger_msi(struct kvm *kvm, struct vgic_its *its,
>>> if (err)
>>> return err;
>>>
>>> + if (irq->hw)
>>> + return irq_set_irqchip_state(irq->host_irq,
>>> + IRQCHIP_STATE_PENDING, true);
>>> +
>>> spin_lock(&irq->irq_lock);
>>> irq->pending_latch = true;
>>> vgic_queue_irq_unlock(kvm, irq);
>>>
>
>
next prev parent reply other threads:[~2017-11-08 14:14 UTC|newest]
Thread overview: 234+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 14:28 [PATCH v5 00/26] KVM/ARM: Add support for GICv4 Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` [PATCH v5 01/26] irqchip/gic-v3-its: Setup VLPI properties at map time Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-30 6:46 ` Christoffer Dall
2017-10-30 6:46 ` Christoffer Dall
2017-10-30 6:46 ` Christoffer Dall
2017-10-27 14:28 ` [PATCH v5 02/26] KVM: arm/arm64: register irq bypass consumer on ARM/ARM64 Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-30 6:47 ` Christoffer Dall
2017-10-30 6:47 ` Christoffer Dall
2017-10-30 6:47 ` Christoffer Dall
2017-10-27 14:28 ` [PATCH v5 03/26] KVM: arm/arm64: vgic: restructure kvm_vgic_(un)map_phys_irq Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` [PATCH v5 04/26] KVM: arm: Select ARM_GIC_V3 and ARM_GIC_V3_ITS Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` [PATCH v5 05/26] KVM: arm/arm64: vgic: Move kvm_vgic_destroy call around Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` [PATCH v5 06/26] KVM: arm/arm64: vITS: Add MSI translation helpers Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 20:34 ` Auger Eric
2017-11-07 20:34 ` Auger Eric
2017-11-07 20:34 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 07/26] KVM: arm/arm64: vITS: Add a helper to update the affinity of an LPI Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 13:44 ` Auger Eric
2017-11-07 13:44 ` Auger Eric
2017-11-07 13:44 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 08/26] KVM: arm/arm64: GICv4: Add property field and per-VM predicate Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 20:30 ` Auger Eric
2017-11-07 20:30 ` Auger Eric
2017-11-07 20:30 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 09/26] KVM: arm/arm64: GICv4: Add init/teardown of the per-VM vPE irq domain Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 13:08 ` Auger Eric
2017-11-07 13:08 ` Auger Eric
2017-11-07 13:08 ` Auger Eric
2017-11-10 8:20 ` Christoffer Dall
2017-11-10 8:20 ` Christoffer Dall
2017-11-10 8:20 ` Christoffer Dall
2017-11-10 8:55 ` Marc Zyngier
2017-11-10 8:55 ` Marc Zyngier
2017-11-10 8:55 ` Marc Zyngier
2017-11-07 13:09 ` Auger Eric
2017-11-07 13:09 ` Auger Eric
2017-11-07 13:09 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 10/26] KVM: arm/arm64: GICv4: Wire mapping/unmapping of VLPIs in VFIO irq bypass Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 13:06 ` Auger Eric
2017-11-07 13:06 ` Auger Eric
2017-11-07 13:06 ` Auger Eric
2017-11-07 14:42 ` Marc Zyngier
2017-11-07 14:42 ` Marc Zyngier
2017-11-07 14:42 ` Marc Zyngier
2017-11-07 15:59 ` Auger Eric
2017-11-07 15:59 ` Auger Eric
2017-11-07 15:59 ` Auger Eric
2017-11-08 11:30 ` Marc Zyngier
2017-11-08 11:30 ` Marc Zyngier
2017-11-08 11:30 ` Marc Zyngier
2017-11-10 8:28 ` Christoffer Dall
2017-11-10 8:28 ` Christoffer Dall
2017-11-10 8:28 ` Christoffer Dall
2017-11-10 9:05 ` Marc Zyngier
2017-11-10 9:05 ` Marc Zyngier
2017-11-10 9:05 ` Marc Zyngier
2017-11-10 9:41 ` Christoffer Dall
2017-11-10 9:41 ` Christoffer Dall
2017-11-10 9:41 ` Christoffer Dall
2017-10-27 14:28 ` [PATCH v5 11/26] KVM: arm/arm64: GICv4: Handle INT command applied to a VLPI Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 20:15 ` Auger Eric
2017-11-07 20:15 ` Auger Eric
2017-11-07 20:15 ` Auger Eric
2017-11-08 11:40 ` Marc Zyngier
2017-11-08 11:40 ` Marc Zyngier
2017-11-08 11:40 ` Marc Zyngier
2017-11-08 14:14 ` Auger Eric [this message]
2017-11-08 14:14 ` Auger Eric
2017-11-08 14:14 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 12/26] KVM: arm/arm64: GICv4: Unmap VLPI when freeing an LPI Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 20:28 ` Auger Eric
2017-11-07 20:28 ` Auger Eric
2017-11-07 20:28 ` Auger Eric
2017-11-08 11:52 ` Marc Zyngier
2017-11-08 11:52 ` Marc Zyngier
2017-11-08 11:52 ` Marc Zyngier
2017-11-08 14:14 ` Auger Eric
2017-11-08 14:14 ` Auger Eric
2017-11-08 14:14 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 13/26] KVM: arm/arm64: GICv4: Propagate affinity changes to the physical ITS Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:01 ` Auger Eric
2017-11-07 21:01 ` Auger Eric
2017-11-07 21:01 ` Auger Eric
2017-11-08 12:05 ` Marc Zyngier
2017-11-08 12:05 ` Marc Zyngier
2017-11-08 12:05 ` Marc Zyngier
2017-10-27 14:28 ` [PATCH v5 14/26] KVM: arm/arm64: GICv4: Handle CLEAR applied to a VLPI Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:04 ` Auger Eric
2017-11-07 21:04 ` Auger Eric
2017-11-07 21:04 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 15/26] KVM: arm/arm64: GICv4: Handle MOVALL applied to a vPE Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:06 ` Auger Eric
2017-11-07 21:06 ` Auger Eric
2017-11-07 21:06 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 16/26] KVM: arm/arm64: GICv4: Propagate property updates to VLPIs Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:28 ` Auger Eric
2017-11-07 21:28 ` Auger Eric
2017-11-07 21:28 ` Auger Eric
2017-11-08 15:08 ` Marc Zyngier
2017-11-08 15:08 ` Marc Zyngier
2017-11-08 15:08 ` Marc Zyngier
2017-11-10 8:37 ` Christoffer Dall
2017-11-10 8:37 ` Christoffer Dall
2017-11-10 8:37 ` Christoffer Dall
2017-11-10 8:58 ` Marc Zyngier
2017-11-10 8:58 ` Marc Zyngier
2017-11-10 8:58 ` Marc Zyngier
2017-10-27 14:28 ` [PATCH v5 17/26] KVM: arm/arm64: GICv4: Handle INVALL applied to a vPE Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:23 ` Auger Eric
2017-11-07 21:23 ` Auger Eric
2017-11-07 21:23 ` Auger Eric
2017-11-10 8:41 ` Christoffer Dall
2017-11-10 8:41 ` Christoffer Dall
2017-11-10 8:41 ` Christoffer Dall
2017-11-10 8:56 ` Marc Zyngier
2017-11-10 8:56 ` Marc Zyngier
2017-11-10 8:56 ` Marc Zyngier
2017-10-27 14:28 ` [PATCH v5 18/26] KVM: arm/arm64: GICv4: Use pending_last as a scheduling hint Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:38 ` Auger Eric
2017-11-07 21:38 ` Auger Eric
2017-11-07 21:38 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 19/26] KVM: arm/arm64: GICv4: Add doorbell interrupt handling Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:43 ` Auger Eric
2017-11-07 21:43 ` Auger Eric
2017-11-07 21:43 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 20/26] KVM: arm/arm64: GICv4: Use the doorbell interrupt as an unblocking source Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:45 ` Auger Eric
2017-11-07 21:45 ` Auger Eric
2017-11-07 21:45 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 21/26] KVM: arm/arm64: GICv4: Hook vPE scheduling into vgic flush/sync Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 21:54 ` Auger Eric
2017-11-07 21:54 ` Auger Eric
2017-11-07 21:54 ` Auger Eric
2017-11-07 22:14 ` Auger Eric
2017-11-07 22:14 ` Auger Eric
2017-11-07 22:14 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 22/26] KVM: arm/arm64: GICv4: Enable virtual cpuif if VLPIs can be delivered Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-08 8:46 ` Auger Eric
2017-11-08 8:46 ` Auger Eric
2017-11-08 8:46 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 23/26] KVM: arm/arm64: GICv4: Prevent a VM using GICv4 from being saved Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-07 15:24 ` Auger Eric
2017-11-07 15:24 ` Auger Eric
2017-11-07 15:24 ` Auger Eric
2017-11-07 15:38 ` Marc Zyngier
2017-11-07 15:38 ` Marc Zyngier
2017-11-07 15:38 ` Marc Zyngier
2017-11-07 16:12 ` Auger Eric
2017-11-07 16:12 ` Auger Eric
2017-11-07 16:12 ` Auger Eric
2017-11-07 16:34 ` Marc Zyngier
2017-11-07 16:34 ` Marc Zyngier
2017-11-07 16:34 ` Marc Zyngier
2017-11-07 22:24 ` Auger Eric
2017-11-07 22:24 ` Auger Eric
2017-11-07 22:24 ` Auger Eric
2017-11-08 9:35 ` Auger Eric
2017-11-08 9:35 ` Auger Eric
2017-11-08 9:35 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 24/26] KVM: arm/arm64: GICv4: Prevent userspace from changing doorbell affinity Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-30 6:51 ` Christoffer Dall
2017-10-30 6:51 ` Christoffer Dall
2017-10-30 6:51 ` Christoffer Dall
2017-11-07 22:17 ` Auger Eric
2017-11-07 22:17 ` Auger Eric
2017-11-07 22:17 ` Auger Eric
2017-10-27 14:28 ` [PATCH v5 25/26] KVM: arm/arm64: GICv4: Enable VLPI support Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-08 8:44 ` Auger Eric
2017-11-08 8:44 ` Auger Eric
2017-11-08 8:44 ` Auger Eric
2017-11-08 15:14 ` Marc Zyngier
2017-11-08 15:14 ` Marc Zyngier
2017-11-08 15:14 ` Marc Zyngier
2017-10-27 14:28 ` [PATCH v5 26/26] KVM: arm/arm64: GICv4: Theory of operations Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-10-27 14:28 ` Marc Zyngier
2017-11-08 9:13 ` Auger Eric
2017-11-08 9:13 ` Auger Eric
2017-11-08 9:13 ` Auger Eric
2017-11-08 15:19 ` Marc Zyngier
2017-11-08 15:19 ` Marc Zyngier
2017-11-08 15:19 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c6f1428-2cf8-0a28-7554-d45dd53f2179@redhat.com \
--to=eric.auger@redhat.com \
--cc=Andre.Przywara@arm.com \
--cc=cdall@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shankerd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.