From: John Garry <john.garry@huawei.com> To: Christoph Hellwig <hch@lst.de> Cc: <axboe@kernel.dk>, <damien.lemoal@opensource.wdc.com>, <bvanassche@acm.org>, <jejb@linux.ibm.com>, <martin.petersen@oracle.com>, <ming.lei@redhat.com>, <hare@suse.de>, <chenxiang66@hisilicon.com>, <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-ide@vger.kernel.org>, <linux-scsi@vger.kernel.org>, <dm-devel@redhat.com>, <beanhuo@micron.com> Subject: Re: [PATCH 04/11] scsi: libsas: Send SMP commands through the block layer Date: Tue, 22 Mar 2022 14:37:55 +0000 [thread overview] Message-ID: <5d33aa82-ed40-f4fb-a60d-99adc0f367ed@huawei.com> (raw) In-Reply-To: <20220322112331.GD29270@lst.de> On 22/03/2022 11:23, Christoph Hellwig wrote: > Wouldn't it make more sense to have a new member in th Scsi_Host_template > that gets called for these request early from ->queue_rq instead of the > new request_queue and custome ops? I had something like this before, but it also has its disadvantages. Let me revisit. > > FYI, I think reusing the block layer for all these command is a good > idea but the way it is done here seems a bit ugly and not very > maintainable. > Cheers, John
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com> To: Christoph Hellwig <hch@lst.de> Cc: axboe@kernel.dk, bvanassche@acm.org, martin.petersen@oracle.com, chenxiang66@hisilicon.com, damien.lemoal@opensource.wdc.com, linux-kernel@vger.kernel.org, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, dm-devel@redhat.com, linux-scsi@vger.kernel.org, jejb@linux.ibm.com, beanhuo@micron.com Subject: Re: [dm-devel] [PATCH 04/11] scsi: libsas: Send SMP commands through the block layer Date: Tue, 22 Mar 2022 14:37:55 +0000 [thread overview] Message-ID: <5d33aa82-ed40-f4fb-a60d-99adc0f367ed@huawei.com> (raw) In-Reply-To: <20220322112331.GD29270@lst.de> On 22/03/2022 11:23, Christoph Hellwig wrote: > Wouldn't it make more sense to have a new member in th Scsi_Host_template > that gets called for these request early from ->queue_rq instead of the > new request_queue and custome ops? I had something like this before, but it also has its disadvantages. Let me revisit. > > FYI, I think reusing the block layer for all these command is a good > idea but the way it is done here seems a bit ugly and not very > maintainable. > Cheers, John -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-03-22 14:38 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-22 10:39 [PATCH RFC 00/11] blk-mq/libata/scsi: SCSI driver tagging improvements John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 01/11] blk-mq: Add blk_mq_init_queue_ops() John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 11:18 ` Christoph Hellwig 2022-03-22 11:18 ` [dm-devel] " Christoph Hellwig 2022-03-22 11:33 ` John Garry 2022-03-22 11:33 ` [dm-devel] " John Garry 2022-03-22 12:16 ` Hannes Reinecke 2022-03-22 12:16 ` [dm-devel] " Hannes Reinecke 2022-03-22 12:30 ` John Garry 2022-03-22 12:30 ` [dm-devel] " John Garry 2022-03-22 14:03 ` Hannes Reinecke 2022-03-22 14:03 ` [dm-devel] " Hannes Reinecke 2022-03-22 15:17 ` John Garry 2022-03-22 15:17 ` [dm-devel] " John Garry 2022-03-22 15:31 ` Hannes Reinecke 2022-03-22 15:31 ` [dm-devel] " Hannes Reinecke 2022-03-23 2:57 ` Bart Van Assche 2022-03-23 2:57 ` [dm-devel] " Bart Van Assche 2022-03-23 9:01 ` John Garry 2022-03-23 9:01 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 02/11] scsi: core: Add SUBMITTED_BY_SCSI_CUSTOM_OPS John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 11:20 ` Christoph Hellwig 2022-03-22 11:20 ` [dm-devel] " Christoph Hellwig 2022-03-22 10:39 ` [PATCH 03/11] libata: Send internal commands through the block layer John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 11:20 ` Christoph Hellwig 2022-03-22 11:20 ` [dm-devel] " Christoph Hellwig 2022-03-22 11:36 ` John Garry 2022-03-22 11:36 ` [dm-devel] " John Garry 2022-04-07 14:32 ` John Garry 2022-04-07 14:32 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 04/11] scsi: libsas: Send SMP " John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 11:23 ` Christoph Hellwig 2022-03-22 11:23 ` [dm-devel] " Christoph Hellwig 2022-03-22 14:37 ` John Garry [this message] 2022-03-22 14:37 ` John Garry 2022-03-22 10:39 ` [PATCH 05/11] scsi: libsas: Send TMF " John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 06/11] scsi: core: Add scsi_alloc_request_hwq() John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 07/11] scsi: libsas: Send internal abort commands through the block layer John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 08/11] scsi: libsas: Change ATA support to deal with each qc having a SCSI command John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 09/11] scsi: libsas: Add sas_task_to_unique_tag() John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 10/11] scsi: libsas: Add sas_task_to_hwq() John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 10:39 ` [PATCH 11/11] scsi: hisi_sas: Remove private tag management John Garry 2022-03-22 10:39 ` [dm-devel] " John Garry 2022-03-22 11:30 ` [PATCH RFC 00/11] blk-mq/libata/scsi: SCSI driver tagging improvements Hannes Reinecke 2022-03-22 11:30 ` [dm-devel] " Hannes Reinecke 2022-03-22 12:17 ` John Garry 2022-03-22 12:17 ` [dm-devel] " John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5d33aa82-ed40-f4fb-a60d-99adc0f367ed@huawei.com \ --to=john.garry@huawei.com \ --cc=axboe@kernel.dk \ --cc=beanhuo@micron.com \ --cc=bvanassche@acm.org \ --cc=chenxiang66@hisilicon.com \ --cc=damien.lemoal@opensource.wdc.com \ --cc=dm-devel@redhat.com \ --cc=hare@suse.de \ --cc=hch@lst.de \ --cc=jejb@linux.ibm.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=ming.lei@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.